Better way to register where to place pixels when mouse down

[colbert2677 (ImagineerColbert)]

Just want to step in a second here and throw down my thread, as I feel it’s relevant here.

The While-Wait-Do Idiom, by cntkillme: Addressing while wait() loops

EDIT (08/09/2021): Yes, I’ve actually started seeing while task.wait(). Just so it’s clear, the document does cover yielding functions being used as conditions as well. task.wait() is not a better replacement and also falls under discouraged practice as per the below. Introduction Earlier today on my usual camp-out by the Scripting Support category, I stumbled across a piece of code that set off my nitpick ringer and reminded me of a document I stumbled across long ago. Today, after being prom…

This code is a perfect example of how to blatantly abuse conditions for while loops, specifically under yielding at the start of every iteration and thus producing finnicky results. What you should be doing is spawning the loop right when a draw action needs to be performed and terminating it when it no longer has use.

while hold do
    if ColorPicker.Visible then
        Draw:FireServer(mouse.X, mouse.Y) -- Bad for performance
    end
    wait() -- 1/30th second + additional time to search for free TS slot
end

You aren’t using a while loop anymore (which is good) so this is fairly moot, but I wanted to take the time to address that since it hasn’t already been addressed.