Can someone fix up this script?

MikeartsRBLX · April 22, 2024, 1:37pm

We won’t and can’t help you if you don’t tell us what how this code is supposed to work and what is supposed to happen.

LilGingerBoy1235 · April 22, 2024, 1:59pm

hey if it were me id just shove it into chatgpt, if it cant fix it it can prob tell you whats wrong

rusted010101 · April 22, 2024, 2:22pm

i forgor to say that, anyways the thingy like flickers and stuff and its messy and stuff, i didint know how to explain it, and i still dont know how

codycheck_com · April 22, 2024, 2:33pm

This script controls camera movements and visual effects based on raycasting.
Tween parameters are set for adjusting volume, camera field of view, and color tint.
Raycasting is performed to detect certain parts in the workspace.
If the raycast hits a part named “TurnAroundPart”, specific effects are triggered.
Camera movements are controlled using tween animations.
Color correction and sound volume adjustments are handled based on the raycast result.
The script connects to the RenderStepped event to update effects and raycasting continuously.

Good Luck

-- This script controls camera movements and visual effects based on raycasting.

local WorkspaceService = game.Workspace
local Sound = false

-- Tween parameters for adjusting volume
local VolumeTo = {
	Volume = 1
}

local VolumeBack = {
	Volume = 0
}

-- Tween animations for sound volume
local SoundTweenTo = game.TweenService:Create(script.HB, TweenInfo.new(1, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), VolumeTo)
local SoundTweenBack = game.TweenService:Create(script.HB, TweenInfo.new(1, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), VolumeBack)

-- Function to perform raycasting
function Raycast()
	local deb = false
	local camera = workspace.CurrentCamera
	local cameraCF = camera.CFrame
	local length = 1000
	local params = RaycastParams.new()

	-- Tween parameters for adjusting camera field of view
	local NumberTweenTo = {
		FieldOfView = 50
	}

	local NumberTweenBack = {
		FieldOfView = 70
	}

	-- Tween parameters for adjusting color tint
	local TintTo = {
		TintColor = Color3.fromRGB(255, 128, 128)
	}

	local TintBack = {
		TintColor = Color3.fromRGB(255, 255, 255)
	}
	
	-- Tween animations for color correction
	local TintToTween = game.TweenService:Create(game.Lighting.ColorCorrection, TweenInfo.new(1, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), TintTo)
	local TintBackTween = game.TweenService:Create(game.Lighting.ColorCorrection, TweenInfo.new(1, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), TintBack)

	-- Tween animations for camera field of view
	local MainTweenTo = game.TweenService:Create(game.Workspace.CurrentCamera, TweenInfo.new(4, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), NumberTweenTo)
	local MainTweenBack = game.TweenService:Create(game.Workspace.CurrentCamera, TweenInfo.new(2, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), NumberTweenBack)

	-- Perform raycast
	local raycastResult = workspace:Raycast(cameraCF.Position, cameraCF.LookVector * length, params)
	
	if raycastResult then
		if raycastResult.Instance then
			if raycastResult.Instance.Name == "TurnAroundPart" then
				if deb == false then
					deb = true
					MainTweenBack:Cancel()
					MainTweenTo:Play()
					wait(1.5)
					Sound = true
					SoundTweenTo:Play()
					wait(0.2)
					TintBackTween:Cancel()
					TintToTween:Play()
					wait(0.2)
					game.Lighting.ColorCorrection.Enabled = false
					game.Lighting.ColorCorrection2.Enabled = true
					wait(0.2)
					game.Lighting.ColorCorrection.Enabled = true
					game.Lighting.ColorCorrection2.Enabled = false
					wait(0.2)
					game.Lighting.ColorCorrection.Enabled = false
					game.Lighting.ColorCorrection2.Enabled = true
					wait(0.2)
					game.Lighting.ColorCorrection.Enabled = true
					game.Lighting.ColorCorrection2.Enabled = false
					wait(0.2)
					game.TweenService:Create(game.Lighting.ColorCorrection, TweenInfo.new(0.1, Enum.EasingStyle.Linear, Enum.EasingDirection.InOut, 0, false, 0), {TintColor = Color3.fromRGB(49, 0, 0)}):Play()
				else
					Sound = false
					deb = false
					MainTweenTo:Cancel()
					MainTweenBack:Play()
					TintToTween:Cancel()
					TintBackTween:Play()
				end
			else
				deb = false
				Sound = false
				MainTweenTo:Cancel()
				MainTweenBack:Play()
				TintToTween:Cancel()
				TintBackTween:Play()
			end
		else
			deb = false
			Sound = false
			MainTweenTo:Cancel()
			MainTweenBack:Play()
			TintToTween:Cancel()
			TintBackTween:Play()
		end
	end
end

-- Connect to the RenderStepped event to update effects and raycast
game["Run Service"].RenderStepped:Connect(function()
	if Sound == true then
		SoundTweenBack:Cancel()
		SoundTweenTo:Play()
		Raycast()
	else
		SoundTweenTo:Cancel()
		SoundTweenBack:Play()
		Raycast()
	end
end)

Sir_Highness · April 22, 2024, 3:12pm

Are you saying you don’t know what you want it to do? And you can’t explain what you expect it to do?

Let me help you start. So finish this sentence:

I’m trying to make a script that will…

Den_vers · April 22, 2024, 3:14pm

It’s making me uncomfortable how much space is between everything.

Clxzed · April 22, 2024, 5:21pm

Same. I’ve never seen that much spacing. Also, why did they use a table for each of the values… I feel like you could just use variables. Just specify sound.Volume = VolumeBack and VolumeBack = 0…

I guess we should remember this dude is 11 though.

Clxzed · April 22, 2024, 5:25pm

Also, PLEASE use task.wait(), I don’t care if it’s not intended, you need to.

Den_vers · April 22, 2024, 5:35pm

local RunService = game:GetService("RunService")
local TweenService = game:GetService("TweenService")

local camera = workspace.CurrentCamera

local VolumeTo = { Volume = 1 }
local VolumeBack = { Volume = 0 }

local SoundTweenTo = game.TweenService:Create(script.HB, TweenInfo.new(1, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), VolumeTo)
local SoundTweenBack = game.TweenService:Create(script.HB, TweenInfo.new(1, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), VolumeBack)

local Sound = false

local function Raycast()
	local deb = false
	local cameraCF = camera.CFrame

	local length = 1000
	local params = RaycastParams.new()

	local NumberTweenTo = { FieldOfView = 50 }
	local NumberTweenBack = { FieldOfView = 70 }
	local TintTo = ( TintColor = Color3.fromRGB(255, 128, 128) }
	local TintBack = { TintColor = Color3.fromRGB(255, 255, 255) }

	local TintToTween = game.TweenService:Create(game.Lighting.ColorCorrection, TweenInfo.new(1, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), TintTo)
	local TintBackTween = game.TweenService:Create(game.Lighting.ColorCorrection, TweenInfo.new(1, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), TintBack)
	local MainTweenTo = game.TweenService:Create(game.Workspace.CurrentCamera, TweenInfo.new(4, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), NumberTweenTo)
	local MainTweenBack = game.TweenService:Create(game.Workspace.CurrentCamera, TweenInfo.new(2, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), NumberTweenBack)

	local raycastResult = workspace:Raycast(cameraCF.Position, cameraCF.LookVector * length, params)

	if not raycastResult then return end

	if raycastResult.Instance then
		if raycastResult.Instance.Name == "TurnAroundPart" then
			if not deb then
				deb = true

				MainTweenBack:Cancel()
				MainTweenTo:Play()

				task.wait(1.5)

				Sound = true

				SoundTweenTo:Play()

				task.wait(0.2)

				TintBackTween:Cancel()

				TintToTween:Play()

				task.wait(0.2)

				game.Lighting.ColorCorrection.Enabled = false
				game.Lighting.ColorCorrection2.Enabled = true

				task.wait(0.2)

				game.Lighting.ColorCorrection.Enabled = true
				game.Lighting.ColorCorrection2.Enabled = false

				task.wait(0.2)

				game.Lighting.ColorCorrection.Enabled = false
				game.Lighting.ColorCorrection2.Enabled = true

				task.wait(0.2)

				game.Lighting.ColorCorrection.Enabled = true
				game.Lighting.ColorCorrection2.Enabled = false

				task.wait(0.2)

				game.TweenService:Create(game.Lighting.ColorCorrection, TweenInfo.new(0.1, Enum.EasingStyle.Linear, Enum.EasingDirection.InOut, 0, false, 0), {TintColor = Color3.fromRGB(49, 0, 0)}):Play()
			else
				Sound = false
				deb = false

				MainTweenTo:Cancel()
				MainTweenBack:Play()
				TintToTween:Cancel()
				TintBackTween:Play()
			end
		else
			deb = false
			Sound = false

			MainTweenTo:Cancel()
			MainTweenBack:Play()
			TintToTween:Cancel()
			TintBackTween:Play()
		end
	else
		deb = false
		Sound = false

		MainTweenTo:Cancel()
		MainTweenBack:Play()
		TintToTween:Cancel()
		TintBackTween:Play()
	end
end

RunService.RenderStepped:Connect(function()
	if Sound then
		SoundTweenBack:Cancel()
		SoundTweenTo:Play()

		Raycast()
	else
		SoundTweenTo:Cancel()
		SoundTweenBack:Play()

		Raycast()
	end
end)

I organized it a bit.

MikeartsRBLX · April 23, 2024, 1:12pm

I do not recommend to use ChatGPT for coding at all, given that it can screw up your script, or make code that doesn’t even work.

LilGingerBoy1235 · April 23, 2024, 1:57pm

hey i hear people say this all the time, and whats really the difference? just wondering

2112Jay · April 23, 2024, 2:28pm

ChatGPT is the worst programmer I’ve ever seen. I’d never rely on anything that thing has to say.

christofferlt · April 23, 2024, 2:35pm

well chatgpt is very good for such task since all the correct data is given by the user

its just chatgpt fails at making scripts

christofferlt · April 23, 2024, 2:38pm

-- Define constants and initial values
local WorkspaceService = game.Workspace
local Sound = false

local VolumeTo = { Volume = 1 }
local VolumeBack = { Volume = 0 }

-- Create tweens for sound volume
local SoundTweenTo = game.TweenService:Create(script.HB, TweenInfo.new(1, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), VolumeTo)
local SoundTweenBack = game.TweenService:Create(script.HB, TweenInfo.new(1, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), VolumeBack)

-- Function to perform raycasting
function Raycast()
    local deb = false
    local camera = workspace.CurrentCamera
    local cameraCF = camera.CFrame
    local length = 1000
    local params = RaycastParams.new()

    -- Define tweens for camera field of view and color correction
    local NumberTweenTo = { FieldOfView = 50 }
    local NumberTweenBack = { FieldOfView = 70 }
    local TintTo = { TintColor = Color3.fromRGB(255, 128, 128) }
    local TintBack = { TintColor = Color3.fromRGB(255, 255, 255) }
    local TintToTween = game.TweenService:Create(game.Lighting.ColorCorrection, TweenInfo.new(1, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), TintTo)
    local TintBackTween = game.TweenService:Create(game.Lighting.ColorCorrection, TweenInfo.new(1, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), TintBack)
    local MainTweenTo = game.TweenService:Create(game.Workspace.CurrentCamera, TweenInfo.new(4, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), NumberTweenTo)
    local MainTweenBack = game.TweenService:Create(game.Workspace.CurrentCamera, TweenInfo.new(2, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), NumberTweenBack)

    local raycastResult = workspace:Raycast(cameraCF.Position, cameraCF.LookVector * length, params)
    if raycastResult then
        if raycastResult.Instance and raycastResult.Instance.Name == "TurnAroundPart" then
            if not deb then
                deb = true
                MainTweenBack:Cancel()
                MainTweenTo:Play()
                wait(1.5)
                Sound = true
                SoundTweenTo:Play()
                wait(0.2)
                TintBackTween:Cancel()
                TintToTween:Play()
                wait(0.2)
                game.Lighting.ColorCorrection.Enabled = false
                game.Lighting.ColorCorrection2.Enabled = true
                for _ = 1, 2 do
                    wait(0.2)
                    game.Lighting.ColorCorrection.Enabled = not game.Lighting.ColorCorrection.Enabled
                    game.Lighting.ColorCorrection2.Enabled = not game.Lighting.ColorCorrection2.Enabled
                end
                game.TweenService:Create(game.Lighting.ColorCorrection, TweenInfo.new(0.1, Enum.EasingStyle.Linear, Enum.EasingDirection.InOut, 0, false, 0), {TintColor = Color3.fromRGB(49, 0, 0)}):Play()
            else
                Sound = false
                deb = false
                MainTweenTo:Cancel()
                MainTweenBack:Play()
                TintToTween:Cancel()
                TintBackTween:Play()
            end
        else
            deb = false
            Sound = false
            MainTweenTo:Cancel()
            MainTweenBack:Play()
            TintToTween:Cancel()
            TintBackTween:Play()
        end
    else
        deb = false
        Sound = false
        MainTweenTo:Cancel()
        MainTweenBack:Play()
        TintToTween:Cancel()
        TintBackTween:Play()
    end
end

-- Connect to RenderStepped event to update sound and raycast
game["Run Service"].RenderStepped:Connect(function()
    if Sound then
        SoundTweenBack:Cancel()
        SoundTweenTo:Play()
        Raycast()
    else
        SoundTweenTo:Cancel()
        SoundTweenBack:Play()
        Raycast()
    end
end)

just to prove my point chatgpt managed to organize the script

christofferlt · April 23, 2024, 3:09pm

Chatgpt can easily do very simple tasks such as i asked it to do. Although you would normally give it more context. (wich i didnt) most errors caused by chatgpt can easily be fixed manually. (or you could just ask chatgpt to replace it If you explain the problem)

I think chatgpt or the roblox assistant are great tools for simple task and for searching to luau documentation.

keep in mind this was just an example and there should be given more context to the prompts given to chatgpt. My prompt was simply organize this luau code

rusted010101 · April 25, 2024, 3:55pm

I didint use chat gpt… Tho uh idj

keyre124 · May 14, 2024, 12:34pm

Then what is BRO DOING ON THE DEVFORUM

ogether123 · May 14, 2024, 12:39pm

Oh,for this script.This script needs major inprovements

LilGingerBoy1235 · May 25, 2024, 10:59pm

well now that chatgpt 4o has come out and its free… its seriously has made entire functionalities for my extremely complex module scripts. “when in doubt, use ChatGPT 4o.”

2112Jay · June 27, 2024, 9:58pm

local RunService = game:GetService("RunService")
local TweenService = game:GetService("TweenService")
local Workspace = game:GetService("Workspace")
local Lighting = game:GetService("Lighting")

local Sound = false

local VolumeTo = { Volume = 1 }
local VolumeBack = { Volume = 0 }

local SoundTween = TweenService:Create(script.HB, TweenInfo.new(1, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), VolumeTo)

function Raycast()
    local camera = Workspace.CurrentCamera
    local cameraCF = camera.CFrame
    local length = 1000
    local params = RaycastParams.new()

    local NumberTweenTo = { FieldOfView = 50 }
    local NumberTweenBack = { FieldOfView = 70 }

    local TintTo = { TintColor = Color3.fromRGB(255, 128, 128) }
    local TintBack = { TintColor = Color3.fromRGB(255, 255, 255) }

    local TintToTween = TweenService:Create(Lighting.ColorCorrection, TweenInfo.new(1, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), TintTo)
    local TintBackTween = TweenService:Create(Lighting.ColorCorrection, TweenInfo.new(1, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), TintBack)

    local MainTweenTo = TweenService:Create(Workspace.CurrentCamera, TweenInfo.new(4, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), NumberTweenTo)
    local MainTweenBack = TweenService:Create(Workspace.CurrentCamera, TweenInfo.new(2, Enum.EasingStyle.Quart, Enum.EasingDirection.Out, 0, false, 0), NumberTweenBack)

    local raycastResult = Workspace:Raycast(cameraCF.Position, cameraCF.LookVector * length, params)

    if raycastResult and raycastResult.Instance and raycastResult.Instance.Name == "TurnAroundPart" then
        if not Sound then
            MainTweenBack:Cancel()
            MainTweenTo:Play()
            wait(1.5)
            Sound = true
            SoundTween:Play()
            wait(0.2)
            TintBackTween:Cancel()
            TintToTween:Play()
            for i = 1, 2 do
                wait(0.2)
                Lighting.ColorCorrection.Enabled = i % 2 == 0
                Lighting.ColorCorrection2.Enabled = i % 2 == 1
            end
            TweenService:Create(Lighting.ColorCorrection, TweenInfo.new(0.1, Enum.EasingStyle.Linear, Enum.EasingDirection.InOut, 0, false, 0), {TintColor = Color3.fromRGB(49, 0, 0)}):Play()
        else
            Sound = false
            MainTweenTo:Cancel()
            MainTweenBack:Play()
            TintToTween:Cancel()
            TintBackTween:Play()
        end
    else
        Sound = false
        MainTweenTo:Cancel()
        MainTweenBack:Play()
        TintToTween:Cancel()
        TintBackTween:Play()
    end
end

RunService.RenderStepped:Connect(Raycast)

Hope this helps …