Client not Receiving Remote Event after Respawn

[PigTPM_S3 (Pig)]

I have a remote event that fires after a Player.CharacterAdded event to the client, which works for the first time spawning in, but not after respawning.
The issue seems to be on the client side, as a print statement within the OnClientEvent only sends the first time. There are no errors in the output either, so I believe I am just making a simple mistake.
I spent a while trying to fix it myself, but couldn’t quite figure it out or find any topics on this issue.

--Function that fires the event
game.Players.PlayerAdded:Connect(function(player)
	player.CharacterAdded:Connect(function(character)
		local prompt = Instance.new("ProximityPrompt"):Clone()
		local root = character:WaitForChild("HumanoidRootPart")

		prompt.Parent = root
		prompt.Name = "PairPrompt"
		prompt.ObjectText = player.DisplayName
		prompt.ActionText = "Pair"
		prompt.RequiresLineOfSight = false
		
		RemoveEvent:FireClient(player)
		print("Fired")
	end)
end)

[Katrist]

Where do you put your client code, and what is your client code?

[PigTPM_S3 (Pig)]

Client code is in StarterCharacterScripts

local RemoveEvent = game:GetService("ReplicatedStorage"):WaitForChild("RemovePromptEvent")

RemoveEvent.OnClientEvent:Connect(function()
	print("Received")
	local plr = game.Players.LocalPlayer
	local chr = plr.Character
	local root = chr:WaitForChild("HumanoidRootPart")
	
	root:FindFirstChild("PairPrompt"):Destroy()
end)

[PigTPM_S3 (Pig)]

I moved the variables out of the function as it seemed to be unnecessary.

local RemoveEvent = game:GetService("ReplicatedStorage"):WaitForChild("RemovePromptEvent")

local plr = game.Players.LocalPlayer
local chr = plr.Character
local root = chr:WaitForChild("HumanoidRootPart")

RemoveEvent.OnClientEvent:Connect(function()
	print("Received")
	root:FindFirstChild("PairPrompt"):Destroy()
end)

[Katrist]

Why are you using a RemoteEvent instead of just using :Destroy on the client?

Code:

local plr = game.Players.LocalPlayer
local chr = plr.Character
local root = chr:WaitForChild("HumanoidRootPart")
root:WaitForChild("PairPrompt"):Destroy()

[PigTPM_S3 (Pig)]

Forgot it runs on respawn automatically, I was overthinking. Thanks.

[Katrist]

Also, unrelated, but you should be setting .Parent last.

PSA: Don't use Instance.new() with parent argument

I’ve discovered a pretty bad performance issue in one of top games that has to do with Instance.new and wanted to write about this, since this is not obvious unless you know the system inside out. Tthere are several ways to create a ROBLOX object in Lua: local obj = Instance.new(‘type’); fill obj fields local obj = Instance.new(‘type’, parent); fill obj fields local obj = util.Create(‘type’, { field1 = value1, … }) If you care at all about performance, please only use the first option - I wi…

So ideally, your server code should be this:

--Function that fires the event
local Players = game:GetService("Players")

Players .PlayerAdded:Connect(function(player)
	player.CharacterAdded:Connect(function(character)
		local root = character:WaitForChild("HumanoidRootPart")

		local prompt = Instance.new("ProximityPrompt"):Clone()
		prompt.Name = "PairPrompt"
		prompt.ObjectText = player.DisplayName
		prompt.ActionText = "Pair"
		prompt.RequiresLineOfSight = false
		prompt.Parent = root
	end)
end)