Datastore headache

[COUNTYL1MITS (wil)]

These two pcall functions can be simplified:

-- Original
    local success, data = pcall(function()
       return DataStore:GetAsync(player.UserId)
    end)

    local success = pcall(function()
        DataStore:SetAsync(player.UserId, data)
    end)

-- Simplified
local success, response = pcall(DataStore.GetAsync, DataStore, player.UserId)

local success = pcall(DataStore.SetAsync, DataStore, player.UserId, data)

Pcalls take a function to run and catches the error. Since there is only one function being executed within the pcalls, you should just pass the function being called. You can look at this post for more information:

Pcalls - When and how to use them

Introduction Protected calls, formally known as pcalls, can run functions without erroring and provide if your code was successfully ran but what’s the best way to use them and when should I? In this tutorial I will be covering the entirety of pcalls and where you’ll need them, so lets begin! Pcall basics First and foremost, we should learn what pcall’s syntax really looks like: pcall(f : function, ...args : any) Basically, you pass your desired function in as argument 1 and any arguments …