Out of curiosity have you tried declaring a variable such as local pets = {“Pet1”} and putting “pets” inside of the second argument of SetAsync?
As far as saving tables to datastore go, I’ve never heard it not working. I use it for all of my games and I’ve not had a single problem.
I think I’ve found the problem… When I Put
game.Players.PlayerAdded:Connect(function(player)
game:GetService("DataStoreService"):GetDataStore("Pets"):SetAsync(player.userId, "TESTPET")
print(game:GetService("DataStoreService"):GetDataStore("Pets"):GetAsync(player.userId))
end)
It prints “TESTPET”. So… something must be preventing the PlayerRemoving function from saving it to the DataStore…
From the code that you have proved the only thing I think could be causing SetAsync not to work is that your key isn’t a string:
tostring(player.UserId). You will also need to make the GetAsync() key a string as well.
I’ve tried that too. Still doesn’t work. I’m currently saving Data every 30ish seconds as a workaround…
The API page is weird because the key is automatically coerced into a string internally (I assume through tostring). You’ll notice that no error is thrown for a numeric key. Probably just says string to keep developers away from passing arbitrary datatypes as the DataStore key.
Oh and surprisingly, it’s working in-game. So, this is a Studio related bug or error…
You can save tables as a DataStore value and you don’t need to JSONEncode or JSONDecode the values as it is automatically done for you.
I organized the code a little. This should work.
Pets = game:GetService("DataStoreService"):GetDataStore("Pets")
game.Players.PlayerAdded:Connect(function(player)
local petsval = Pets:GetAsync(player.userId)
print(petsval)
end)
game.Players.PlayerRemoving:Connect(function(player)
Pets:SetAsync(player.userId, "NormalPet")
end)
Is Studio Access to API Services enabled?
If it was not enabled it would provide an error, but in OPs case that does not seem to be the case. It seems to return nil, meaning that the GetAsync call is working.
I can confirm I am having the same issue. The line before the SetAsync part in my script will print, but the line after it won’t print and my data wont save. Really annoying bug.
If you create a post about it, I guarantee others will see and try to do their best to help.
I’ve already had people try to help me on Discord plus I have tested it on multiple games (including completely new places) and the same issue still occurs.
When the player leaves, the server closes before the data gets saved. You will have to use BindToClose to save the data before the server shutdowns. Check out this post that explains how to save data properly.
Still doesn’t work. Currently impossible to play test in studio atm. Thank you for the suggestion though
Yeah, that is a Roblox issue at the moment. Try it in a live game and it should work. Also you should have a loop that saves data every minute. Check out this article Documentation - Roblox Creator Hub
If you want me to look over the code, send me a message and I’ll do my best to help.
I Know this is like 20 days ago but i had the same issue with that and the Studio/Server was force closing to fast and it would cancel any scripts running in that time and if the data has not requested to save then you get data loss but Adding this to your data script will make sure that if server is shutdown it will kick everyone then wait 10 seconds then close the server if your in studio it will disconnect your client then wait 3 second to close the server.
The code:
game:BindToClose(function()
if not RunService:IsStudio() then
local Aplayers = Players:GetPlayers()
for i = 1,#Aplayers do
Aplayers[i]:Kick(“Server is shutting down: Please rejoin, your data will be saved.”)
end
wait(10)
else
wait(3)
end
end)
It took me forever to find this out hope it helps
the working code:
game:BindToClose(function()
if not RunService:IsStudio() then
for v, i in next, game.Players:GetPlayers()) do
i:Kick(“Server is shutting down: Please rejoin, your data will be saved.”)
end
wait(10)
else
wait(3)
end
end)
Those waits are pointless. The server will close down the moment your operations finish, they don’t stall how long the server stays up for.
Don’t kick every player from the server from BindToClose: not only is this not the intended use of BindToClose, but it is also grossly unnecessary because all players will already be gone from the server. You should instead implement data saving techniques for leftover data sets that the server still tracks.
As well, two things about your loop:
While what variable names you use for the for loop don’t quite matter, you have the standard variable convention in reverse. The i should come first as it stands for index.
Where did people learn this unreadable way of writing for loops with in next? Use a proper generator. GetPlayers returns an array, so use ipairs to iterate over it.
Has anyone noticed “player.userId”. userId is supposed to be capitilised right? player.UserId…? Correct me if I’m wrong.