DataStore won't work at all

goldenstein64 · September 9, 2019, 7:42pm

It doesn’t look like there are any errors in your code. Have you made sure that the script is running in the first place?

Script is of class Script.
Script is not disabled.
Script is in Workspace or ServerScriptService.

Hokker3 · September 9, 2019, 7:53pm

Yep, it’s a script inside ServerScriptService

starmaq · September 9, 2019, 9:14pm

Ok this might be a dumb question, but is the game published? Datastore only works with published.
Also did you get any sort of error or http error?

HumbledDragon · September 9, 2019, 10:36pm

Hokker3:

local data1
local data2 
local success,errormessage = pcall(function() 
  data1 = MoneyStore:GetAsync(player.UserId.."cash") 
  data2 = LevelStore:GetAsync(player.UserId.."level") 
end)

Replace that with

local successCash, ReturnCash = pcall(function()
    return MoneyStore:GetAsync(player.UserId.."cash")
end)
local successLevel, ReturnLevel = pcall(function()
    return MoneyStore:GetAsync(player.UserId.."level")
end)

if successCash then
   MoneyInt.Value = ReturnCash
else
   warn(ReturnCash)
end
if successLevel then
   LevelInt.Value = ReturnLevel
else
   warn(ReturnLevel)
end

That should be basically the whole data saving option, I doubt this is the problem but it’s just pleasing to me. I infer that the PROBLEM is that you aren’t parenting the MoneyInt and LevelInt values created in the beginning of your script. But yea along the way it’s much more readable to write it in the way that’s up there ^^^. Yea though your problem isn’t the loading but more of actually not parenting the instances you’ve made which could easily be solved with DataFolder.Parent = Player , MoneyInt = DataFolder , and LevelInt = DataFolder . Also, make sure to make these changes inside the PlayerAdded event. Yea though, Hope that helped!

HumbledDragon · September 9, 2019, 10:47pm

That doesn’t make a difference.

colbert2677 · September 9, 2019, 11:03pm

Personally, I think the issue is that your players aren’t being registered at all. If you truly aren’t getting errors (check your console again) and you know you have all the game configurations set (DataStores do not need HttpEnabled), this is the only thing I can think of. Combat it using a catcher function. Essentially: take the anonymous function that listens to PlayerAdded and make it a defined function. Have it listen to PlayerAdded then run it on existing players.

local Players = game:GetService("Players")
-- DataStores up here, you should know how to move them over

local function playerAdded(player)
    -- All your PlayerAdded code here; I'm not filling it in for you
end

-- Might as well stick to new conventions and make things readable
local function playerRemoving(player)
    -- Your PlayerRemoving code here; I'm not filling it in for you
end

Players.PlayerAdded:Connect(playerAdded)
Players.PlayerRemoving:Connect(playerRemoving)

for _, player in pairs(Players:GetPlayers()) do
    playerAdded(player)
end

Some other recommendations, besides this, to make.

Look into using only a single DataStore for all player data instead of one per stat. Having two DataStores for each player can result in any of the following consequences: unreadability, maintenance trouble, data loss, throttled/hogged DataStore requests, et cetera.
Don’t use the parent argument with Instance.new, considering you set properties (even if it is just one) after instancing. Create the instance, name it then parent it.
You aren’t making good use of pcalls. One pcall should be responsible for wrapping one call, not several of them. Furthermore, the creation of the upvalues data1 and data2 is unnecessary; you can return the result of GetAsync or wrap the function directly.
Your data script should not be assuming that if the pcall is successful, then it’s clear to add data. If a player doesn’t have data stored, your script is setting the values of some ValueObjects to nil. That’s a no-no. Cannot hardset nil just because a call passes.

@serverModule It’s not. The indenting may be bad but you can pretty clearly see that PlayerRemoving is outside of the PlayerAdded function. Despite this, it wouldn’t make a difference.

Hokker3 · September 10, 2019, 5:50pm

I remade the script using some solutions you guys said:

local DSS = game:GetService("DataStoreService")
local DataStore = DSS:GetDataStore("Data")

function playerAdded(player)
	local DataFolder = Instance.new("Folder")
	DataFolder.Parent = player
	DataFolder.Name = "leaderstats"
	
	local MoneyInt = Instance.new("IntValue")
	MoneyInt.Parent = DataFolder
	MoneyInt.Name = "Money"
	
	local LevelInt = Instance.new("IntValue")
	LevelInt.Parent = DataFolder
	LevelInt.Name = "Rebirths"
	
	local successCash, returnCash = pcall(function()
		return DataStore:GetAsync(player.UserId..'Money')
	end)
	
	local succesLvl, returnLvl = pcall(function()
		return DataStore:GetAsync(player.UserId.."Level")
	end)
	
	if successCash then
		MoneyInt.Value = returnCash
	else
		warn(returnCash)
	end
	
	if succesLvl then
		LevelInt.Value = returnLvl
	else
		warn(returnLvl)
	end
end

function playerRemoving(player)
	local sucess, errormessage = pcall(function()
		DataStore:SetAsync(player.UserId..'Cash',player.leaderstats.Money.Value)
		DataStore:SetAsync(player.UserId..'Level',player.leaderstats.Rebirths.Value)
	end)
	
	if sucess then
		print("Succes saving data!")
	else
		warn(errormessage)
	end
end

game.Players.PlayerAdded:Connect(playerAdded)
game.Players.PlayerRemoving:Connect(playerRemoving)

for i, player in pairs(game.Players:GetPlayers()) do
	playerAdded(player)
end

It still doesn’t work. I double checked API and made the game public, yet it still doesn’t work.

colbert2677 · September 10, 2019, 5:54pm

This isn’t quite what I meant by flatten it down to one DataStore, but that’s beside the point, it was just a recommendation.

Need to know how specifically it isn’t working. Has anything appeared in your console? Please also print the returns of the pcalls. Adding prints on each line could help test what runs and what doesn’t, thus directing you to the problem code.

mobyboyy · September 10, 2019, 5:55pm

Try taking the datastore stuff out off the pcalls, the pcall could be masking most of the errors.

Hokker3 · September 10, 2019, 5:56pm

Nothing is in console besides an unrelated error saying game can’t find an image.

mobyboyy · September 10, 2019, 6:00pm

I just realized the biggest issue, You’re using return rather than setting it to a variable.

local cash -- variable placeholder
local success, errormessage = pcall(function()
	cash = datastore:GetAsync(player.UserId .. 'Money')
end)

if success then
	MoneyInt.Value = cash
else
	warn(errormessage)
end

Hokker3 · September 10, 2019, 6:02pm

Also found out that in Output in studio, loadstring isn’t available, is that the problem ?

Hokker3 · September 10, 2019, 6:03pm

I took out the pcalls and still, no errors

mobyboyy · September 10, 2019, 6:03pm

Nope, that only means something if you are using loadstring() in your code, but you’re not so It doesn’t matter.

Hokker3 · September 10, 2019, 6:04pm

Is there something else to do besides allowing API in Configure Game and enabling API from game settings through studio to make DataStore work ?

mobyboyy · September 10, 2019, 6:06pm

Did you try putting the functions back in pcalls and try using a local variable to store the cash and xp?

colbert2677 · September 10, 2019, 6:08pm

Pcall is a callback, this is a non-issue. If this was a problem, it’d throw for using a return. Note how the result is printed to the console via warn if success is false.

Guess I really need to write that pcall tutorial more than ever.

Hokker3 · September 10, 2019, 6:09pm

	local Data1
	local successCash, returnCash = pcall(function()
		Data1 = DataStore:GetAsync(player.UserId..'Money')
	end)
	
	local Data2
	local succesLvl, returnLvl = pcall(function()
		Data2 = DataStore:GetAsync(player.UserId.."Level")
	end)
	
	if successCash then
		MoneyInt.Value = Data1
	else
		warn(returnCash)
	end
	
	if succesLvl then
		LevelInt.Value = Data2
	else
		warn(returnLvl)
	end

Nope, still doesn’t work

colbert2677 · September 10, 2019, 6:09pm

Please reference what I asked beforehand. Doing debugging is very crucial here. I am unsure whether this is an implementation error or something else right now.

Hokker3 · September 10, 2019, 6:13pm

function playerAdded(player)
	local DataFolder = Instance.new("Folder")
	DataFolder.Parent = player
	DataFolder.Name = "leaderstats"
	
	local MoneyInt = Instance.new("IntValue")
	MoneyInt.Parent = DataFolder
	MoneyInt.Name = "Money"
	
	local LevelInt = Instance.new("IntValue")
	LevelInt.Parent = DataFolder
	LevelInt.Name = "Rebirths"
	
	local Data1
	local successCash, returnCash = pcall(function()
		Data1 = DataStore:GetAsync(player.UserId..'Money')
	end)
	
	local Data2
	local succesLvl, returnLvl = pcall(function()
		Data2 = DataStore:GetAsync(player.UserId..'Level')
	end)
	
	if successCash then
		print("succes")
		MoneyInt.Value = Data1
	else
		warn(returnCash)
	end
	
	if succesLvl then
		print("yeet")
		LevelInt.Value = Data2
	else
		warn(returnLvl)
	end
end

function playerRemoving(player)
	local sucess, errormessage = pcall(function()
		DataStore:SetAsync(player.UserId..'Cash',player.leaderstats.Money.Value)
		DataStore:SetAsync(player.UserId..'Level',player.leaderstats.Rebirths.Value)
	end)
	
	if sucess then
		print("Succes saving data!")
	else
		warn(errormessage)
	end
end

game.Players.PlayerAdded:Connect(playerAdded)
game.Players.PlayerRemoving:Connect(playerRemoving)

for i, player in pairs(game.Players:GetPlayers()) do
	playerAdded(player)
end

succes, yeet and Success saving data are printed.