Every player being given the same data table

Help and Feedback Scripting Support
#21

You’re saving a reference to the table and not creating a new table, so it seems like you’re editing the data of the player but what you’re actually doing is editing what your variable is referring to, and that is the data table at the top of your example script.

4 Likes
#22

Take a look at this thread it is the exact same problem you are having with the solution.

#23

You have to copy the table, it would look something like this:

function CloneTable(t)
  local nt = {}
  for i,v in pairs(t) do
    if type(v) ~= 'table' then
      nt[i]=v
    else
      nt[i] = CloneTable(v)
    end
  end
  return nt
end
2 Likes
#24

You need to return nt

@NinjoOnline this is the explanation and it’s been said several times now. Lua is not deep copying the table for you, it’s just referencing it.

1 Like
#25

How would I intergrate that into my code then?

#26

My bad, typing inside forum can be weird.
Fixed it so it returns nt, thanks for letting me know.

#27

You just copy a table whenever you assign it to new user.

newData = CloneTable(defaultData)
#28 
newData = CloneTable(defaultData)
local loadData = PlayerDataStore:GetAsync(Player.UserId) or newData

PlayersData[Player.UserId] = updateData(loadData, Data)

like so?

#29 
local loadData = PlayerDataStore:GetAsync(Player.UserId) or CloneTable(defaultData)

PlayersData[Player.UserId] = updateData(loadData, loadData)
#30

Should handle scenarios where GetAsync returns error, but yeah, this is about how you do it.

1 Like
#31

An alternative to the above would be to format your “template” module like so:

--Template.lua
return function()
 local template = { ... }
 return template;
end

--DataManager.lua
local template = require(path_to);
::GetAsync() or Template()

You wouldn’t have to deep copy anything in this case.

[EDIT: meant to reply to op]

#32

The reason why your “VariableName” didn’t work was because that is a shallow copy of the table.

Therefore, some or all of the items inside the table are not copies, but references to the original data point.

To solve this, as @Legoracer has done, you would create a function to recursively iterate through the table and copy each branch into a new one, creating what is called a deep copy.

This error has plagued me before.

1 Like
#33

Did something change with relation to this in the past 2-3 months? As Ive never had this issue before

#34

Nope, it’s probably just because it’s your first time having tables within tables and referencing them.

#35

I’ve noticed you seem to never mark anything as a solution even though your problems have been solved.

Please start doing it as it is common courtesy to do so.

If a New Member has a lot of solutions, it shows that they’re active and being helpful which in turn increases their chance of being promoted to Member.

5 Likes
#37

I do mark something as a solution if it 100% works on my end. I just woke up and haven’t been able to test the new answers yet. When I know that my question has been 100% fully answered and works for me then I will mark it as a solution

#38

Did you fix your problem or are you still having trouble?

#39

I ended up changing how my data store system worked in the end