FindFirstChildWhichIsA returns nil?

[weakroblox35]

I’m trying to detect if player is holding a Tool in either backpack or character but FindFirstChildWhichIsA is returning nil if it doesn’t, unlike FindFirstChild which returns false.
using pcall() will always return false which I don’t want, because in this case I don’t want the player to hold a duplicate item that has the same attribute.

if Player.Backpack:FindFirstChildWhichIsA("Tool"):FindFirstChild("StateGive"):GetAttribute("IsStone") == true then 
			return true 
		else
			if Player.Character:FindFirstChildWhichIsA("Tool"):FindFirstChild("StateGive"):GetAttribute("IsStone") == true then
				return true
			end
		end

[Prototrode (Vernumeron)]

@weakroblox35

unlike FindFirstChild which returns false.

Are you confusing it for something? FindFirstChild will return nil if it doesn’t find what it is looking for. They should both return nil if the instance doesn’t exist; that is the expected behavior.

@weakroblox35

Player.Backpack:FindFirstChildWhichIsA("Tool"):FindFirstChild("StateGive"):GetAttribute("IsStone")

I cannot stress enough how bad of a practice this is. You should never be using FindFirst_ methods like this. In the case that one of them return nil, the entire code will error.

Consider reading this thread below, specifically the second bad habit listed which is what you are doing.

FindFirstChild and WaitForChild: Addressing common bad practices and habits of each

Please do keep the following in mind before reading or linking! Some parts of this thread provide slightly inaccurate, unnecessary or outdated information. You are strongly encouraged to read the replies for further discussion about FindFirstChild and WaitForChild and their use in code, as well as some pointers on replication. I have not yet found a time to correct potential misconceptions in this thread. It does not provide authoritative advice and you should always double check information …

[weakroblox35]

Okay I’ve read it (For the fourth time now.), but it dosen’t have any solutions i’m looking for.

[Prototrode (Vernumeron)]

I was just addressing the problem you are having. Try the following:

local tool = Player.Backpack:FindFirstChildWhichIsA('Tool')
if tool then
    local stateGive = tool:FindFirstChild('StateGive')
    if stateGive and stateGive:GetAttribute('IsStone') then return true end
end
local char = Player.Character
if char then
    local tool = char:FindFirstChildWhichIsA('Tool')
    if tool then
        local stateGive = tool:FindFirstChild('StateGive')
        if stateGive and stateGive:GetAttribute('IsStone') then return true end
    end
end

[weakroblox35]

Still gives me duplicate tool that has the same attribute.
Edit: Fixed it on my own.

local __TOOL = Player.Backpack:FindFirstChildWhichIsA("Tool")
	if __TOOL then
		local __ISSTONE = __TOOL:FindFirstChild("StateGive")
		if __ISSTONE and __TOOL:GetAttribute("IsStone") == true then return true end
	end
	local __CHARACTER = Player.Character
	if __CHARACTER then
		local __TOOL = __CHARACTER:FindFirstChildWhichIsA("Tool")
		if __TOOL then
			local __STONE = __TOOL:FindFirstChild("StateGive")
			if __STONE and __TOOL:GetAttribute("IsStone") == true then return true end
		end
	end

Tool was suppose to have attribute not StateGive