GoodSignal::Connect thread gets garbage collected after yielding

Help and Feedback Scripting Support
#21

That’s very strange. I’m not sure of a condition where that would happen.

Per the docs:

the very same Heartbeat step in which enough time has passed, the function is guaranteed to be called/resumed

Based on the code in your function, the coroutine returned shouldn’t possibly be in the suspended state after the delay, since it doesn’t do any yielding.
[Edit: If Dice:NextNumber or .SetGameSetting yields this might be possible?]

This would lead me to believe this is a problem on Roblox’s end perhaps?

Out of curiosity, does using

task.spawn(function()
    task.wait(delayTime)
    -- Your code
end

Do anything different? Or does this seem to happen with all threads given to the engine’s scheduler?

#22

We’ve already checked and .SetGameSetting does not yield. This issue only happens with callbacks given to GoodSignal via :Connect()

1 Like
#23

Is there task.cancel() somewhere?

#24

Nope, the thread gets reused by GoodSignal somewhere and prevents the task.delay from running.

#25

Hmm, can you add

local Task = task.delay(…)

Maybe the script is deleting the task.delay() because of the :Connect() Signal, firing again as you said GoodSignal gets ReUsed
by turning it into local Task, it should fix that problem normally.

Since GoodSignal is already a task, as we look into the Module at line 151, 164

#26

I’ve already tried making a strong reference to the task.delay but it still remains permanently suspended. Perhaps it may not be a GoodSignal issue but more rather a ROBLOX issue? The only reason I have a suspicion that it’s GoodSignal is that all of the incidents have been happening inside of connections made by GoodSignal.

#28

I have one stupid idea that could work

task.spawn(function()
		task.delay(3, function()
			print("Running delayed task")
		end
	)end
	)

image
image1163×207 61.9 KB

#29

This wouldn’t work because the thread will still be garbage collected.

#30

Can I see what it looks like where you calling hte onGameSettingsChanged() function?

#31

It’s at the bottom in the second screenshot.

#32

I doubt it is an issue with the garbage collector.

Here’s an example of a single thread being garbage collected:

image
image

Here’s an example of GoodSignal’s implementation, even with a thousand threads:

image
image367×706 47.2 KB

image

This would not even matter since GoodSignal only ever reuses 1 free runner thread.

Threads are not true parallel. This means that running coroutine.running on a thread outside of said thread will never give you a status of running. Add a print to your task.delay thread to see if it’s even running. If it does, the problem likely lies with the function that has been passed.

#33

This might be related:

I’ve also experienced weird task scheduling behavior, so it is entirely possible this really is a Roblox issue.