Help with Object Oriented Programming

Help and Feedback Scripting Support
#22

Seconding @HugeCoolboy2007 .

Using WaitForChild on the leaderstats and saving the ValueBase instance rather than their values should work.

I am not sure I understand why you parameter the player when you have the self argument (which is your new instance object).

Would suggest this instead: (in addition, I personally prefer stating the type of the parameter, then not needing to convert it, but that is up to you)

function StatFunctions:AddCash(amount : number)
	self.Cash.Value += amount
end

local Players = game:GetService("Players")
local ServerStorage = game:GetService("ServerStorage")
local StatFunctions = require(ServerStorage.StatFunctions)

Players.PlayerAdded:Connect(function(player)
    local playerStat = StatFunctions.new(player)
    playerStat:AddCash(10)
end)
#23

it doesn’t find the leaderstats because it fires before the folder (what I’m assuming) spawns in so you should make a slight delay like around 2 seconds

#24

That’s what :WaitForChild is for. It yields the expression until the folder spawns.

Thanks alot! Ill try out your advice when I can!

1 Like
#25

I just tried your solution, but unfortunately that did not work.

No errors in the output.

I’m assuming its because the leaderstats is yielding infinitely.

#26

Are the leaderstats ever being added to the player?

1 Like
#27

Yes. The leaderstats are loading. The money isn’t adding to the player for some reason.

1 Like
#28

What’s your current code right now that’s not erroring?

1 Like
#29

My OOP Module Script:

local StatFunctions = {}

StatFunctions.__index = StatFunctions

function StatFunctions.new(player)
	local self = {}
	
	setmetatable(self, StatFunctions)
	
	local leaderstats = player:WaitForChild("leaderstats")
	
	self.Player = player
	self.Cash = leaderstats.Cash
	self.Captures = leaderstats.Captures
	self.Kills = leaderstats.Kills
	self.Deaths = leaderstats.Deaths
	
	
	
	
	return self
end

function StatFunctions:AddCash(amount : number)
	
	self.Cash.Value += amount
	
end


return StatFunctions
#30

And how is it being called from the other script?

1 Like
#31 
local Players = game:GetService("Players")
local ServerStorage = game:GetService("ServerStorage")

local StatFunctions = require(ServerStorage.StatFunctions)


Players.PlayerAdded:Connect(function(player)
	local PlayerStats = StatFunctions.new(player)
	StatFunctions:AddCash(10)
end)
#32

Also can you add print(self) to the AddCash function and show me the result?

(If it just says table:0x847373 or whatever turn off log mode in the settings)

1 Like
#33

It now errors:
ServerStorage.StatFunctions:26: attempt to index nil with 'Value'

#34

So that makes me think that it’s failing to initiate the object.

function StatFunctions:AddCash(amount : number)
	print(self)
	self.Cash.Value += amount
	
end

Try this and show me the output.

#35

image
image821×88 10.3 KB

#36

The table is the print(self)

and the error is from

self.Cash.Value += amount

#37

Replace your self variable with

local self = setmetatable({}, StatFunctions)

I think that’s the problem right now?

2 Likes
#38

Pretty sure it’s adding the cash, I just don’t think its displaying it.

Doesnt look like anywhere in the script you are updating leaderstats.Cash, update it in the :AddCash function and see how that works. (set leaderstats.Cash.Value to self.Cash after you increment the self.Cash)

1 Like
#39

You haven’t set Cash yet, you need to use your StatFunctions.new() to make cash a real value else it will return nil and possibly cause this error

1 Like
#40

What if it waits for the leaderstats, but it’s children don’t exist yet? Try adding wait for child on the cash.

1 Like
#41

Maybe try this. It seems like the leaderstats haven’t loaded when you call the constructor.

local StatFunctions = {}

StatFunctions.__index = StatFunctions

function StatFunctions.new(player)
	local self = {}
	
	setmetatable(self, StatFunctions)
	
	local leaderstats = player:WaitForChild("leaderstats")
	
	self.Player = player
	self.Cash = leaderstats:WaitForChild("Cash")
	self.Captures = leaderstats:WaitForChild("Captures")
	self.Kills = leaderstats:WaitForChild("Kills")
	self.Deaths = leaderstats:WaitForChild("Deaths")
	
	return self
end

function StatFunctions:AddCash(amount : number)
	
	self.Cash.Value += amount
	
end


return StatFunctions
1 Like