Hitbox reviewal

[ekuz0diaa]

i’m making a fighter and, i used a hitbox system my friend worked on and i tweaked it heavily. I was unpleased with the performance after doing ~20 attacks, so i was wondering what you guys suggest adding / changing to make this hitbox system more performant.

---

CODE -

-- services --
local players = game:GetService("Players")
local runservice = game:GetService("RunService")

-- objects --
local player = players.LocalPlayer
local character = player.Character or player.CharacterAdded:Wait()
local remotes = game:GetService("ReplicatedStorage").remotes
local hitbox = remotes.Hitbox

-- variables --
local connection

-- modules --
local region_module = require(game.ReplicatedStorage.modules.REGION_MODULE)
local hitbox_module = require(game.ReplicatedStorage.modules.HITBOX_MODULE)

-- events --
connection = hitbox.OnClientEvent:Connect(function(region,duration,cframe,dmg)
	local stopped_attack = false
	repeat runservice.Stepped:Wait()
		local target_hit = false
		local enemy_hum
		if not enemy_hum then
			for i,v in ipairs(region_module:CastRegion(character,1,region)) do
				if v.Parent and v.Parent:FindFirstChildOfClass("Humanoid") and (v.Parent:FindFirstChild("Torso")) then
					enemy_hum = v.Parent:FindFirstChildOfClass("Humanoid")
				end
			end
		end
		if enemy_hum and enemy_hum.Health > 0 and enemy_hum.Parent:FindFirstChildOfClass('ForceField') == nil and not players:GetPlayerFromCharacter(enemy_hum.Parent) then
			local results = hitbox_module:HITBOX(nil,cframe,dmg,enemy_hum,player,duration)
			if results then 
				connection:Disconnect()
				target_hit = true
				--[[local bvelo = Instance.new("BodyVelocity")
				bvelo.MaxForce = Vector3.new(math.huge,math.huge,math.huge)
				bvelo.Velocity = CFrame.new(enemy_hum.Parent.Torso.Position - (enemy_hum.Parent.Torso.Position - character.HumanoidRootPart.Position).unit*3,enemy_hum.Parent.Torso.Position).lookVector*25
				bvelo.Parent = enemy_hum.Parent.Torso
				Debris:AddItem(bvelo,.2)]]--
			end
			return results
		end
	until stopped_attack == true or target_hit == true
	spawn(function()
		wait(duration)
		connection:Disconnect()
		stopped_attack = true
	end)
end)

[SolarThresh (Corpse)]

I really am not quite familiarized with hitboxes, raycasting etc… But i’ve came across some threads that could really help a ton. I wish you the best of luck !

Raycast Hitbox 4.01: For all your melee needs!

Current Version: V.4.01 Stable (09/21/2021) Upgrading from 3.xx to 4.0 Please note that V4 is not backwards compatible with V3. There are a few API changes that were introduced in V4 to better suit modern code etiquette. Here are the changes you need to know if you want to make your code compliant with V4: Raycast Hitbox 4.01: For all your melee needs! - #597 by TeamSwordphin Notable Features Accurate, performant, and easy to use! Use attachments or vectors to make your hitboxes in secon…

How to make a perfect hitbox?

Ranged hitboxes I think are pretty straightforward to do, so I don’t think I need to go over that (besides, I think these other lovely people can give more insight on ranged combat if you need that). For melee hit boxes, I use raycasting. A few years back, I’ve been intrigued by the design of MORDHAU and Chivalry since I wanted accurate hitboxing while making it simple to do across a variety of different weapon shapes and sizes. Here’s a timestamp of how MORDHAU did their hitbox for their sword…

[colbert2677 (ImagineerColbert)]

Have you done your own benchmarking to try and narrow down where your performance hits are coming from? It would help you form a better Code Review because you could ask for optimisation tips specifically on the parts that are causing your slowdowns rather than throwing the entire code onto a thread and asking if anyone can look at the whole thing.

Consider use of the MicroProfiler and the debug library, or simple print statements with os.clock.

[ekuz0diaa]

It seems after benchmarking the events may not be disconnecting after the time of the attack is up.

[ekuz0diaa]

The issue is performance, not hitbox detection. I already have the hitbox system use Region3