How to limit a numbervalue?

Help and Feedback Scripting Support
,
#41

Look at this:
image

There is no script inside your Rebirths IntValue. You are never telling the game to detect a Change event and then clamp the value.

1 Like
#42

I redid the “IntConstrainedValue” test and it again limited the rebirth value to just 10

#43

What should I do for him to detect these events?

#44

Show me the code where you clone the stuff in the Stats folder and move it to the leaderstats folder.

I’m guessing that’s your Leaderstats script.

#45

I looked for a script talking about a clone of the statistics folder, but I didn’t find it (the game is a little disorganized) but for now I will send this script from leaderstats when I am looking for

Leaderstats(script)

local PlayerStatsDS = game:GetService("DataStoreService"):GetDataStore("Player_StatsOL2")

game.Players.PlayerAdded:Connect(function(NP)
	
	local Key = "PDS-".. NP.UserId
	
	local GetSave = PlayerStatsDS:GetAsync(Key)
	
	local PSF = Instance.new("Folder", NP)
	PSF.Name = "leaderstats"
	
	local StatsFolder = script.Stats
	
	for _, S in pairs(StatsFolder:GetChildren()) do
		local NS = Instance.new(S.ClassName, PSF)
		NS.Name = S.Name
		NS.Value = S.Value
	end
	
	local timeplayed = PSF:WaitForChild("Time Played")
	
	spawn(function()
		while true do
			wait(1)
			timeplayed.Value = timeplayed.Value + 1
		end
	end)
	
	if GetSave then
		for n, Stat in pairs(PSF:GetChildren()) do
			Stat.Value = GetSave[n]
		end
	else
		local STS = {}
		for _, Stat in pairs(StatsFolder:GetChildren()) do
			table.insert(STS, Stat.Value)
		end
		PlayerStatsDS:SetAsync(Key, STS)
	end
end)

game.Players.PlayerRemoving:connect(function(OP)
	
	local Key = "PDS-".. OP.UserId
	
	local StatsFolder = OP.leaderstats
	
	local STS = {}
	for _, Stat in pairs(StatsFolder:GetChildren()) do
		table.insert(STS, Stat.Value)
	end
	PlayerStatsDS:SetAsync(Key, STS)
end)
#46

This comes from using code that you don’t really understand. I suggest brushing up more on how scripting works in the Roblox Dev Tutorials to better help you.

This chunk of the Leaderstats script is the part that takes what you have in the Stats folder and then places new values in the leaderstats folder, of which the variable is called PSF.

	local StatsFolder = script.Stats
	
	for _, S in pairs(StatsFolder:GetChildren()) do
		local NS = Instance.new(S.ClassName, PSF)
		NS.Name = S.Name
		NS.Value = S.Value
	end

The problem is, it creates brand new values. The script you made for the Rebirths value only works for that specific Rebirth Value.
This is because the code you’re using takes the data from the Rebirth Value and just makes a whole new rebirth value instead, which doesn’t have that code in it.

A better system should be made, instead of using this one.

However, because you are still learning code, and you should continue to do so, you don’t yet have the ability to fix the code and make it properly duplicate the values with all their data copied over as well.

1 Like
#47

Try this.

Replace:

	for _, S in pairs(StatsFolder:GetChildren()) do
		local NS = Instance.new(S.ClassName, PSF)
		NS.Name = S.Name
		NS.Value = S.Value
	end

with

	for _, S in pairs(StatsFolder:GetChildren()) do
		local NS = S:Clone()
		NS.Parent = PSF
	end

It may or may not break the rest of the code. Likely it won’t.

1 Like
#48

incredible, now the player’s script is appearing and it didn’t break the game

Screenshot_36
Screenshot_36782×659 117 KB

but still didn’t limit the rebirths

#49

I will try to use an IntConstrainedValue

#50

Does it show the before/after message?

1 Like
#51

I saw in the output, but there was nothing

#52

I used an IntConstrainedValue and it worked, thank you so much man for helping me without judging myself for not knowing much

Screenshot_37
Screenshot_371599×680 358 KB

1 Like
#53

it was ’ Deprecated’

place a server script under the int valu and add this code in it

script.Parent.Changed:Connect(function(x)
	script.Parent.Value=math.clamp(x,0,1000000000)
end)
1 Like