I need help with a drowning script

Help and Feedback Scripting Support
,
#42

It’s a problem with your code. You don’t have a timer.


Humanoid.StateChanged:Connect(function (oldState, newState)
	if newState == Enum.HumanoidStateType.Swimming then
		print("Swim")
		Swimming = true
	elseif oldState == Enum.HumanoidStateType.Swimming and newState ~= Enum.HumanoidStateType.Jumping then
		print("No swim")
		Swimming = false
	elseif oldState ~= Enum.HumanoidStateType.Swimming and oldState ~= newState then
		print("No swim")
		Swimming = false
	end

	local firstTick = tick()
	while Swimming do
		wait(1)
		if tick() - firstTick >= 30 then
			Humanoid:TakeDamage(30 / Humanoid.MaxHealth) -- 0skarian said this
		end
	end
end)
#43

So anything else your stuck on that we can help with?

  • If your player isn’t automatically healing then rename any scripts named “Health” in StarterCharacterScripts that way it doesn’t override the core.
#44

I accidentally put it in the wrong script. Two of the answers worked here but I used yours because it damaged the player more equally.

1 Like
#45

If you want this to be multiplayer compatible, it is essential to handle it server side in order to have it replicate on both ends.

I have converted my example into a server script, that will do everything as before, it has the drown damage and cooldown between each hit as a variable as well.

To test it, simply open output so you can view the timer and try to swim around in water.

wait()

local PS = game:GetService("Players")
local Drowning = false

local DrownCount = 0

local DrownDamage = 10
local DrownCooldown = 2


PS.PlayerAdded:Connect(function(Player)
	Player.CharacterAdded:Connect(function(Character)
		local Humanoid = Character:WaitForChild("Humanoid")
		
		Humanoid.StateChanged:Connect(function(Old, State)
			if State == Enum.HumanoidStateType.Swimming then
				if Drowning == false then
					Drowning = true
					local StartTick = tick()
		
					DrownCount = 30
					while DrownCount > 0 do
						DrownCount = DrownCount - 1
						print(DrownCount)
						if Humanoid:GetState() ~= Enum.HumanoidStateType.Swimming then
							Drowning = false
							return
						end
						wait(1)
					end
		
					if DrownCount == 0 then
						while Humanoid:GetState() == Enum.HumanoidStateType.Swimming do
							Humanoid:TakeDamage(DrownDamage)
							wait(DrownCooldown)
						end
					end
					Drowning = false
				end
			end
		end)
	end)
end)

Hope this helped.

1 Like
#46

I will test it. 30 Characters

#47

It does not work. You do not have to fix it because the thing is solved.

#48

Yes, it does. You are probably not using the correct script for it, as I have stated this is for a normal script, not localscript and this one above will replicate to the server unlike the others.

#49

I decided to reply to you with a different method since everyone seems to be using the humanoid state only, maybe I could open the doors for ReadVoxels since nobody uses them for some reason when they’re really nice. (maybe for your use case it doesn’t really matter but still)

#50

I used a server script. eeeeee

#51

How do you merge this script with the drowning script? The one I am currently using has some glitches.

#52

On the server you loop through all the players, check if their humanoids floor material is air, if so do what the script does else they’re not drowning.