Infinite Yield possible on 'Players'ArchieStatxx.PlayerGui.CarSpawner.Selector.ScrollingFrame:WaitForChild("BMW 530")

Help and Feedback Scripting Support
#41

Remotes is not a valid member of RemoteEvent “ReplicatedStorage.CarDealerEvents.Remotes.buyCar”

local events = game.ReplicatedStorage.CarDealerEvents.Remotes:WaitForChild(“buyCar”)

#42

events should be

local events = game.ReplicatedStorage.CarDealerEvents
#43

Oh yeah silly me, I do apologise.

#44

The client isn’t changing anything?

#45

change this line to

game.ReplicatedStorage.CarDealerEvents.Remotes.buyCar:FireServer(new.CarName.Text)
#46

On the server of the player they are still not showing the cars inside of the frame

#47

Yes, that’s why I had you do it on the client.

#48

The button still shows on the cient

#49

image

#50

add a print to the client script.

--client script
local plr = game.Players.LocalPlayer

events.Remotes:WaitForChild("buyCar").OnClientEvent:Connect(function(vehicle, visible)
	local scrf = plr.PlayerGui.CarSpawner.Selector.ScrollingFrame
	local vehiclef = scrf:FindFirstChild(vehicle)
	print(vehicle, visible)
	
	if vehiclef then
		print("vehicle found")
		vehiclef.PurchaseButton.Visible = visible
	end
end)
#51

It doesn’t reach the to the print, could it be the server erroring before getting there?

#52

I guess add a print to the server as well?

local prices = {
	["BMW 530"] = 100
}

events.Remotes:WaitForChild("buyCar").OnServerEvent:Connect(function(plr, vehicle)
	local plrMoney = plr.PlayerStats:WaitForChild("Bank")
	local price = prices[vehicle]

	if price and plrMoney.Value >= price then
		plrMoney.Value -= price
		print("Firing to client")
		events.Remotes:WaitForChild("buyCar"):FireClient(plr, vehicle, false)
	end
end)

--client script
local plr = game.Players.LocalPlayer

events.Remotes:WaitForChild("buyCar").OnClientEvent:Connect(function(vehicle, visible)
	local scrf = plr.PlayerGui.CarSpawner.Selector.ScrollingFrame
	local vehiclef = scrf:FindFirstChild(vehicle)
	print(vehicle, visible)
	
	if vehiclef then
		print("vehicle found")
		vehiclef.PurchaseButton.Visible = visible
	end
end)
#53

Players.ArchieStatixx.PlayerGui.CarSpawner.Selector.LocalScript:27: attempt to index nil with ‘CarSpawner’

local scrf = plr.PlayerGUI.CarSpawner.Selector.ScrollingFrame
#54

I had fixed that after posting the reply, I guess you copied before I fixed that.

#55

events.Remotes:WaitForChild(“buyCar”).OnClientEvent:Connect(function(plr, vehicle, visible)
local scrf = plr.PlayerGUI.CarSpawner.Selector.ScrollingFrame
local vehiclef = scrf:FindFirstChild(vehicle)
print(vehicle, visible)

if vehiclef then
	print("vehicle found")

	vehiclef.PurchaseButton.Visible = visible
end

end)

#56

Again, I had already fixed it, just use this script

#57

Yep, this is all now working, life saver, I appreciate it for staying and helping