Is there a problem with using a for loop to connect events for multiple objects?

Help and Feedback Scripting Support
, ,
2

Nope, there is nothing wrong with the code by itself. In fact this piece of code is commonly seen used with the collection service:

Basic collection services kill brick code from the tutorial 
local CollectionService = game:GetService("CollectionService")

--// First, we will loop trough all the parts with the "killers" tag using a for loop.

for _, part in pairs(CollectionService:GetTagged("killers")) do
	
	--[[
	Now that we've got our killer parts, we're gonna bind them to a function, 
    so when they get touched, they will fire that function.
	--]]
	
	part.Touched:Connect(function(hit)
		--// Classic killing brick script, nothing very interesting
		
		if (hit.Parent:FindFirstChild("Humanoid")) then
			local humanoid = hit.Parent.Humanoid
			
			humanoid.Health = humanoid.Health - humanoid.MaxHealth
		end
	end)
end

You should notice it’s the exact same as your code sample posted but using collection service to get the parts instead of :GetChildren().

The only possible problem the piece of code can cause is when there are a large amount of parts to connect like thousands or millions since events take up memory commonly seen in tycoon games. As long as that doesn’t happen it should be fine… if it does then that’s a different scripting support question to manage large amount of touched instances.

3 Likes