Is there a reason this would lag?

[PiercedMissile]

The average is 60.1 but when it freezes up it goes down to 16

[JDog005 (AverageJoe)]

Could I get a little more context on what the use of the script is? That would help out quite a bit.

[PiercedMissile]

It spawns a zombie but also makes sure that there is not a another zombie in the game.

[SummerEquinox]

This seems like a strange way to approach this concept. You should not need to rename your zombie model in order to check if it exists- in fact it seems counterintuitive if only one is allowed to exist at a time. You should also always try and use :Wait() over wait() for indefinite yields. See if this code works any better. You may need to make some changes.

local ServerStorage = game:GetService("ServerStorage")
local Workspace = game:GetService("Workspace")

local YieldTimer = 6

while true do
	
	if not Workspace:FindFirstChild("Zombie") then
		
		local NewZombie = ServerStorage.Zombie:Clone()
		NewZombie.Parent = Workspace -- You can change this to wherever you need to.
		
		repeat NewZombie.AncestryChanged:Wait() until not NewZombie:IsDescendantOf(Workspace)
		
		wait(YieldTimer) -- I recommend moving to a custom yield function instead of using wait().
		
	end

end

[PiercedMissile]

Still lags.

[SummerEquinox]

There is no reason it would lag with the code I provided- something else is happening inside of your game and outside of this script.

[D0RYU (nici)]

they said it’s the script and the lag stops when it is disabled

you are probably right but idk what they did

[SummerEquinox]

This code works fine because I have tested it. The problem exists elsewhere.

[D0RYU (nici)]

that’s why I said you are probably right

@isgreai750

After I disable the script it doesn’t lag at all.

if this still applies to your script then I’m confused

[JDog005 (AverageJoe)]

I think I found a somewhat different approach that should work better.

local ServerStorage = game:GetService("ServerStorage")

local ZombieFolder = workspace:WaitForChild("ZombieFolder")
local Zombie = ServerStorage:WaitForChild("Zombie")
local SpawnPart = script.Parent

local function createZombie()
	local newZombie = Zombie:Clone()
	newZombie.Parent = ZombieFolder
	newZombie.PrimaryPart.CFrame = SpawnPart.CFrame + Vector3.new(0, 10, 0)
end

local function checkForZombie(instance)
	if instance.Name == "Zombie" then
		createZombie()
	end
end

ZombieFolder.ChildRemoved:Connect(checkForZombie)
createZombie() -- you can remove this if the zombie is already in the Workspace

Your code should be already lag-free, but check if this is any better.

[PiercedMissile]

It could be because the zombie I am cloning has a lot of scripts.

[BlaxorReborn]

hmm if you’re planning on cloning a lot of zombies and then it’s starting to lag a lot then there might be several reasons behind it.

1. Each zombie has a .Touched function and it initiate whenever they touch something
   Solution: Use magnitude detection instead or raycast since they’re a whole lot cheapter in terms of performances.

2. A lot of loops running a lot of thing at the same time.
   Solution: All of the zombies should be ran in a single loop instead of a whole lot of loops in each and every single zombies.

3. Animation lags (Bunch of server side animation script such as idle, jump etc)
   Solution: I’m not sure if this is possible but it’d be the best to run the animations code through local script.

4. Not disconnecting loops properly
   Solution: Make sure you disconnect all of the loops properly!, while this maybe impossible because Roblox literally disconnect them for you whenever the script is removed from the game, it is still possible that you might forget to disconnect it.

5. wait lag
   Solution: Most people said that wait() isn’t the best choice when it comes to utilising it with a lot of stuff at the same time, I suggest you use Heartbeat:Wait() instead for a better performances, more info about it here!

Custom wait - the best solution to yielding!

UPDATE - task.wait or this module? The old wait had restrictions in that it had an internal throttler which caused wait calls to become extremely unrelieable past a certain point, which is no longer the case with task.wait. The performance difference between task.wait and this module has gotten smaller, which means this module should only be used if you either seek extreme precision, or to yields hundreds of threads in parallel. 99% of the time, you won’t need this module anymore …

I hope these helps!

[Kostiskat (kostis)]

Is there any reason of using :FindFirstChild() and not the . specifier like:

if not game.Workspace.ZombieFolder.Zombie2 then
...
end

It’s confirmed that it takes 20% longer using :FindFirstChild() rather than the . specifier.

[SummerEquinox]

@Kostiskat

if not game.Workspace.ZombieFolder.Zombie2 then
...
end

This code will error every time that Zombie2 does not exist (meaning it will never continue because the statement only proceeds if Zombie2 does not exist).

There is nothing inherently laggy about the code that is being used; so, the problem lies outside of this script.

[PiercedMissile]

Do you know any zombie models that do NOT attack other zombies and don’t have a ton of scripts? The problem might be that the zombie has a lot of scripts.

[MightyDantheman (Fate)]

I would recommend coding your own zombies. Perhaps you want pathfinding. That would depend on how many zombies there are at once. It also depends on how you want the zombies to operate. Is it a round based game like Black Ops Zombies? Is it an open world zombie survival game where zombies spawn somewhat randomly?

[PiercedMissile]

It is like an extra minigame

s in a tycoon. I have no idea how to script a zombie

[PiercedMissile]

Also I am using the tall lifelike zombie from roblox.

[PiercedMissile]

Still lags.

[JDog005 (AverageJoe)]

Dang, I think it’s the zombie then, I’m all out of ideas.