Issue with the music system

[ReturnedTrue (Tr_uth)]

@Doqee

songObj.MaxDistance = "inf"

Don’t believe you can do that, trying to assign a property of type number to a string will result in it becoming NaN and therefore 0. Instead of Parenting to Workspace, Parent to SoundService and Play it there without any issues.

Some issues I also spotted:

@Doqee

local songObj = Instance.new("Sound", game.Workspace)

PSA: Don't use Instance.new() with parent argument

I’ve discovered a pretty bad performance issue in one of top games that has to do with Instance.new and wanted to write about this, since this is not obvious unless you know the system inside out. Tthere are several ways to create a ROBLOX object in Lua: local obj = Instance.new(‘type’); fill obj fields local obj = Instance.new(‘type’, parent); fill obj fields local obj = util.Create(‘type’, { field1 = value1, … }) If you care at all about performance, please only use the first option - I wi…

---

You use GetService for ReplicatedService twice, try to use a variable rather than getting it multiple times.

---

@Doqee

repeat wait() until not songObj.Playing

This can be heavily bad on performance, I’d recommend using the :Wait() method on an event such as soundObj.Ended or soundObj.Stopped as that’ll yield the thread until the event fires.