Lights turning on at night and off in morning help

spydercam500 · June 4, 2021, 6:51am

Ok so i have the script wrote (i think) and it still gives me this error
This is the script

Diamondhawky · June 4, 2021, 6:55am

In the for loop, you aren’t doing anything to the object.

spydercam500 · June 4, 2021, 6:57am

So like this it still gives me the error

Diamondhawky · June 4, 2021, 6:58am

It’s giving you the error because in the 6th line, you have wrote down the object but have not wrote anything for the object to do.

spydercam500 · June 4, 2021, 7:02am

I dont really know how to fix that…

Diamondhawky · June 4, 2021, 7:04am

Try this. (There may be some spelling mistakes)

local timetoturnoff = 7 * 60
local timetoturnon = 23*60

for _, v in pairs(script.Parent.parkinglotlightparts:GetChildren()) do
      while wait() do
              if game:GetService("Lighting"):GetMinutesAfterMidnight() > timetoturnoff then
                    v.LightPart.SpotLight.Enabled = false
                  else
                 v.LightPart.SpotLight.Enabled = true
             end 
      end
end

spydercam500 · June 4, 2021, 7:16am

Theres no errors but it still doesnt work.

Jacko_Korbius · June 4, 2021, 7:29am

You will need to place the for loop under an event that will fire when the time is updated. Otherwise it will never turn the lights on/off. So where ever you’re changing your time you could try there or using GetPropertyChangedSignal.

So maybe something like this to get the time to turn the lights on:

game.Lighting:GetPropertyChangedSignal("ClockTime"):Connect(function()
for _, v in pairs(script.Parent.parkinglotlightparts:GetChildren()) do
      while wait() do
              if game:GetService("Lighting"):GetMinutesAfterMidnight() > timetoturnoff then
                    v.LightPart.SpotLight.Enabled = false
                  else
                 v.LightPart.SpotLight.Enabled = true
             end 
      end
end

spydercam500 · June 4, 2021, 7:48am

I dont know what im doing wrong it still wont work i think im gonna take a break and go to bed for the night scripting is hard for me even if its the easiest scripting language. Sorry if i wasted your time.

tin_nim · June 4, 2021, 8:10am

Keep learning,You’ll be great at script in the future here’s the full script

local timetoturnon = 7 * 60 --multiply the hour to minute
local timetoturnon = 23*60 --same

game.Lighting:GetPropertyChangedSignal("ClockTime"):Connect(function()
     if game.Lighting:GetMinutesAfterMidnight() > timetoturnoff and game.Lighting:GetMinutesAfterMidnight() < timetoturnon then
         --so If time is currently after 7 am and before 23 o'clock the light will be off
         for _, v in pairs(script.Parent.Parkinglotlightparts:GetChildren()) do
              v.LightPart.SpotLight.Enabled = false
         end
     else
             for _, v in pairs(script.Parent.Parkinglotlightparts:GetChildren()) do
                    v.LightPart.SpotLight.Enabled = false
             end
     end
end)

Jacko_Korbius · June 4, 2021, 3:13pm

Ah that’s my bad @spydercam500. I forgot to take the while wait loop out after adding the value changed event. Thanks @tin_nim!

Like I said earlier, the channel from the video I linked has some great resources to learn more beginner scripting

spydercam500 · June 4, 2021, 8:38pm

Ok theres no errors in the script that i see but when i go to test it it doesnt work and says this

LightPart is not a valid member of Part
Workspace.Map.TopSide.ParkingLot.ParkingLotLightParts.LightPart
@Jacko_Korbius
@tin_nim

Jacko_Korbius · June 4, 2021, 9:27pm

Can you show the explorer tab of your folder, the parts, and the light object itself?

spydercam500 · June 4, 2021, 9:30pm

Yes1
It goes map then topside then parking lot then parking lot light parts then the parts then the spot lights.

Jacko_Korbius · June 4, 2021, 9:31pm

Where is your script located? And are all the light parts under “ParkinglotLightParts”?

spydercam500 · June 4, 2021, 9:32pm

Script is located in the Parking lot folder not the light part folder.

Jacko_Korbius · June 4, 2021, 9:36pm

Okay so edit your script to this:

local timetoturnon = 7 * 60 --multiply the hour to minute
local timetoturnon = 23*60 --same

game.Lighting:GetPropertyChangedSignal("ClockTime"):Connect(function()
     if game.Lighting:GetMinutesAfterMidnight() > timetoturnoff and game.Lighting:GetMinutesAfterMidnight() < timetoturnon then
         --so If time is currently after 7 am and before 23 o'clock the light will be off
         for _, v in pairs(script.Parent.Parkinglotlightparts:GetChildren()) do
              v.SpotLight.Enabled = false
         end
     else
             for _, v in pairs(script.Parent.Parkinglotlightparts:GetChildren()) do
                    v.SpotLight.Enabled = false
             end
     end
end)

Where you see “v.SpotLight.Enabled” is where the error was, you didn’t need to have “v.LightPart.Spotlight”, so we just took out “LightPart” since v is LightPart.

Edit: Not sure why my formatting isn’t working for the code but copy from the first “local” to the last “end)” Edit2: Never mind, got it to work.

spydercam500 · June 4, 2021, 9:41pm

Yes!! It finally works i just changed the v.lightpart.spotlight to just v.spotlight and it worked! Thank you so much!
Also this is irrelevant but how did u learn to script?

Jacko_Korbius · June 4, 2021, 9:49pm

Hooray!

Don’t want to get too off topic here but I learned using the Roblox API Documentation as well as Youtube videos for beginning scripting. This is a pretty good playlist: Alvin Blox’s beginner scripting tutorials. This is what I used a lot, and there is an advanced tutorial on his channel as well for once you finish the beginner series: TheDevKing’s beginner scripting series.

I wish you the best of luck on learning, have a good one!

pf_z1 · June 2, 2024, 2:40am

How is your scripting journey coming along?