MouseButton1Click disconnecting not working as intended

Help and Feedback Scripting Support
,
#21

Just figured out what I’m saying is actually completely wrong, it’s to do with the remote event being fired, it’s not being fired twice, but whats in it (promptgamepasspurchasefinished) is firing multiple times in the way I described. If I click the button twice it fires the event twice, I don’t understand at all how this can happen because the event is only being fired once. I have a disconnection already on this event, I guess it isn’t working.

local gamePassPurchaseConnection

--other code--
gamePassPurchaseConnection = game:GetService("MarketplaceService").PromptGamePassPurchaseFinished:Connect(function(plr,passId,purchased)
if purchased then
gamePassPurchaseConnection:Disconnect()
--other code--
#22

This is my output

  14:46:01.774  fired  -  Client - buttonClicked:5 (clicked once, didnt press anything on the prompt, just kept it there)
  14:46:05.690  fired  -  Client - buttonClicked:5 (clicked again with the prompt open but this time i bought the gamepass)

  14:46:09.023  Recieved the event  -- As you can see by these lines it receives the event twice
  14:46:09.023  fired  -  Server
  14:46:09.023  Recieved the event  -  Server
  14:46:09.023  fired  -  Server
  14:46:09.072   ▶ recieved (x2)  -  Server
#23

Are you sure that this does not get connected more than once?

1 Like
#24

Sorry, again, after more debugging it seems that the remote event is being fired everytime the player clcicks button but is actually only ever getting recieved when the player purchases the pass

#25

The remote event fires a function inside of a module script, that has the gamepassfinished in it.

#26

So, when the supposed button is clicked, it prompts the player, but also creates a connection of PromptGamePassPurchaseFinished?

Make sure PromptGamePassPurchaseFinished only gets connected once, and not everytime the button was pressed.

1 Like
#27

What should I do to check the connections of PromptGamePassPurchaseFinished?

#28

You could add a print right below for example print("connected")

1 Like
#29

It is printing connected twice after pressing the button twice but only purchasing it once.

#30

Simply move the PromptGamePassPurchaseFinished connection outside of the button clicked event, so that it only connects once. This should solve your issue.

#31

I have thought about that, but I’ll have no way to get the pass id then, the passes are loaded in the game, they aren’t static.

#32

Can you provide extra code? There surely is a way.

#33

Actually, the passid is stored in an intvalue, I could loop through the children of the thing that all the values are in and put the purchasefinished in there?

#34

grafik

This is the second parameter of PromptGamePassPurchaseFinished

#35

What about it? 30cccharrrrrrtrr

#36 
game:GetService("MarketplaceService").PromptGamePassPurchaseFinished:Connect(function(plr, gamePassId, wasPurchased)
	if gamePassId == desiredID then
		-- desiredID was purchased
	end
end)

Thats how you check the gamepass ID. Change desiredID to whatever ID you desire.

And now just move the function outside of the clicked event, so that it only connects once.

1 Like
#37

Alright, I’ll get back to you in a moment.

#38 
for i,v in pairs(workspace.djBooths:GetChildren()) do
	if v:FindFirstChild("itemsPart") then
		for e,f in pairs(v.itemsPart.itemsPartGui.holderFrame.itemsFrame:GetChildren()) do
			if f:IsA("TextButton") then
				local id = f.itemId.Value
				game:GetService("MarketplaceService").PromptGamePassPurchaseFinished:Connect(function(plr, id, wasPurchased)
					print("finished")
				end)
			end
		end
	end
end

Nothing is printing, I’m suspecting it’s because the children change after the script is created?

#39

??? Why would you create a connection for each gamepass. You should only connect it once, and check the ID inside the function from there.

1 Like
#40

Apologies, thought that was what you ment but I didn’t actually know that was possible, I believe it works good now, I have a lot more code to change so it fits with this new code, I will get back to you, thank you.