My GUI script is erroring

Help and Feedback Scripting Support
, , ,
#21

Yes all of them I using to buy

#22

Weā€™d need to acknowledge how many times it prints out when a singular event is called. The codeā€™s not the issue, and thereā€™s no need to utilise a check for only one tool. The script should regularly subtract 200 as intended, but if it exceeds the amount, it signifies the RemoteEventā€™s called more than once.

#23

I will try that :slight_smile: :slight_smile:

#24

new script againā€¦:

--local script
local player = game:GetService("Players").LocalPlayer

local remoteEvent = game.ReplicatedStorage:WaitForChild("Events"):WaitForChild("BuyItemEvent")

local function buyItem()
	local toolName = "Fake Knife"
	remoteEvent:FireServer()
	script.Parent.Bought.BackgroundColor3 = Color3.fromRGB(0,255,0)
end

script.Parent.MouseButton1Click:Connect(buyItem)

--serverscript
local Tools = game.ReplicatedStorage:WaitForChild("Tools")
local Tool = Tools:FindFirstChild("Fake Knife")

local whatToBuy = "Fake Knife"
game.ReplicatedStorage.Events.BuyItemEvent.OnServerEvent:Connect(function(player,toolName)
	if toolName == whatToBuy then
		if player.leaderstats.Cash.Value >= 200 then
			print(player.Name .. " Bought " .. Tool.Name)
			print(player.leaderstats.Cash.Value)
			Tool:Clone().Parent = player:FindFirstChild("Backpack")
			player.leaderstats.Cash.Value = player.leaderstats.Cash.Value - 525
		end
	end
end)
#25

@Doqee my script prints once as I tried before but just is glitchy and subtracts all

#26

@THECOOLGENERATOR You there? :slight_smile: :slight_smile:

#27

Yeah, could you show the other scripts handling the transaction as well?

#28

What do you mean by that sorry?

#29

Oh yeah ok :slight_smile:

--grapple local
local player = game:GetService("Players").LocalPlayer

local remoteEvent = game.ReplicatedStorage:WaitForChild("Events"):WaitForChild("BuyItemEvent")

local function buyItem()
	local toolName = "Grapple Gun"
	remoteEvent:FireServer(toolName)
	script.Parent.Bought.BackgroundColor3 = Color3.fromRGB(0,255,0)
end

script.Parent.MouseButton1Click:Connect(buyItem)
--grapple server
local Tools = game.ReplicatedStorage:WaitForChild("Tools")
local Tool = Tools:FindFirstChild("Grapple Gun")

local whatToBuy = "Grapple Gun"
game.ReplicatedStorage.Events.BuyItemEvent.OnServerEvent:Connect(function(player, toolName)
	if toolName == whatToBuy then
		if player.leaderstats.Cash.Value >= 200 then
			print(player.Name .. " Bought " .. Tool.Name)
			print(player.leaderstats.Cash.Value)
			Tool:Clone().Parent = player:FindFirstChild("Backpack")
			player.leaderstats.Cash.Value = player.leaderstats.Cash.Value - 200
		end
	end
end)
--laser local
local player = game:GetService("Players").LocalPlayer

local remoteEvent = game.ReplicatedStorage:WaitForChild("Events"):WaitForChild("BuyItemEvent")

local function buyItem()
	local toolName = "Laser Gun"
	remoteEvent:FireServer(toolName)
	script.Parent.Bought.BackgroundColor3 = Color3.fromRGB(0,255,0)
end

script.Parent.MouseButton1Click:Connect(buyItem)
--laser server
local Tools = game.ReplicatedStorage:WaitForChild("Tools")
local Tool = Tools:FindFirstChild("Laser Gun")

local whatToBuy = "Laser Gun"
game.ReplicatedStorage.Events.BuyItemEvent.OnServerEvent:Connect(function(player,toolName)
	if toolName == whatToBuy then
		if player.leaderstats.Cash.Value >= 200 then
			print(player.Name .. " Bought " .. Tool.Name)
			print(player.leaderstats.Cash.Value)
			Tool:Clone().Parent = player:FindFirstChild("Backpack")
			player.leaderstats.Cash.Value = player.leaderstats.Cash.Value - 350
		end
	end
end)
--knife local
local player = game:GetService("Players").LocalPlayer

local remoteEvent = game.ReplicatedStorage:WaitForChild("Events"):WaitForChild("BuyItemEvent")

local function buyItem()
	local toolName = "Fake Knife"
	remoteEvent:FireServer(toolName)
	script.Parent.Bought.BackgroundColor3 = Color3.fromRGB(0,255,0)
end

script.Parent.MouseButton1Click:Connect(buyItem)
--knife server
local Tools = game.ReplicatedStorage:WaitForChild("Tools")
local Tool = Tools:FindFirstChild("Fake Knife")

local whatToBuy = "Fake Knife"
game.ReplicatedStorage.Events.BuyItemEvent.OnServerEvent:Connect(function(player,toolName)
	if toolName == whatToBuy then
		if player.leaderstats.Cash.Value >= 200 then
			print(player.Name .. " Bought " .. Tool.Name)
			print(player.leaderstats.Cash.Value)
			Tool:Clone().Parent = player:FindFirstChild("Backpack")
			player.leaderstats.Cash.Value = player.leaderstats.Cash.Value - 525
		end
	end
end)

--My script doesnt work anymore
#30

Dumb question; The buttons are different, right?

#31

ā€¦ No they are all image Buttons lol

#32

Ignore all the >= 200 except for the top one lol mistake

#33

I mean they arenā€™t the same button right? lol

#34

Oh no no no no no lemme show you:
image

#35

Okay, I think I found the problem. Put the normal scripts in ServerScriptService. And you donā€™t need 3 different scripts, thatā€™s where the problemā€™s happening. Just check the types on the server, like so:

local function checkTool(name)
   if ToolFolder:FindFirstChild(name) then
     return ToolFolder[name]
   end
end
#36

Where would I put this in ? for the on server event thing

#37 
local Tools = game.ReplicatedStorage:WaitForChild("Tools")

local function checkTool(name)
   if Tools:FindFirstChild(name) then
      return Tools[name]
   end
     return nil
end

game.ReplicatedStorage.Events.BuyItemEvent.OnServerEvent:Connect(function(player,toolName)
   local Tool = checkTool(toolName)
   if not Tool then return end
	if player.leaderstats.Cash.Value >= 200 then
		print(player.Name .. " Bought " .. Tool.Name)
		print(player.leaderstats.Cash.Value)
    end
end)
#38

I add my backpack tool in it right?

#39

Script part lol my brain is not working rn lol

#40

It will check if the tool exists and if it does, then itā€™ll process the transaction.