Need help with finding user using GetPlayerByUserId

[babkacoco2 (sh1r)]

@FroDev1002

local module = {}
local TweenService = game:GetService("TweenService")
local ReplicatedStorage = game:GetService("ReplicatedStorage")
local Players = game:GetService("Players")

local allreviews = require(ReplicatedStorage.modules.main.allreviews)

module.mainPublish = function(player)
	local function getplayerfriends(player)
		local friendsId = player.UserId
		local PlayersFriends = {}

		local success, page = pcall(function() return Players:GetFriendsAsync(friendsId) end)
		if success then
			repeat
				local info = page:GetCurrentPage()
				for i, friendInfo in pairs(info) do
					table.insert(PlayersFriends, friendInfo)
				end
				if not page.IsFinished then
					local advanceSuccess, advanceError = pcall(function() return page:AdvanceToNextPageAsync() end)
					if not advanceSuccess then
						warn("Error advancing page:", advanceError)
						break
					end
				end
			until page.IsFinished
		else
			warn("Failed to fetch friends for user:", player.Name)
		end

		return PlayersFriends
	end

	local function selectplayerfriends(player, number)
		local PlayersFriends = getplayerfriends(player)
		local selectedFriends = {}

		for i = 1, math.min(number, #PlayersFriends) do
			table.insert(selectedFriends, PlayersFriends[i].Id)
		end

		return selectedFriends
	end

	local function douianimation(player)
		local number = 4
		local selectedFriends = selectplayerfriends(player, number)
		local ui = ReplicatedStorage.templates.Publish:Clone()
		ui.Parent = player.PlayerGui

		for _, userId in pairs(selectedFriends) do
			for _, Review in pairs(ui.Frame.Reviews:GetChildren()) do
				if Review.Contents.Headshot.Image == "rbxassetid://0" then
					TweenService:Create(Review.UIScale, TweenInfo.new(0.1), {Scale = 1}):Play()
					local success, thumbnail = pcall(function()
						return Players:GetUserThumbnailAsync(userId, Enum.ThumbnailType.HeadShot, Enum.ThumbnailSize.Size420x420)
					end)

					if success then
						local review = allreviews[math.random(1, #allreviews)]
						local name = Players:GetNameFromUserIdAsync(userId)
						Review.Contents.Headshot.Image = thumbnail
						Review.Contents.Description.Text = review.Review 
						Review.Contents.User.Text = "@" .. name
					end
					break
				end
			end
		end
	end

	douianimation(player)
end

return module

hey, I just tried the code you did, and it works! thank you for helping me.

[wilgiy (fish)]

Mark their code as the solution for others as well please!

[FroDev1002 (FroDev)]

For those wondering I just changed these lines of code:

-- // Before //
local user = Players:GetPlayerByUserId(userId)
Review.Contents.Headshot.Image = thumbnail
Review.Contents.Description.Text = review.Review 
Review.Contents.User.Text = "@" .. user.Name

-- // After //
local name = Players:GetNameFromUserIdAsync(userId)
Review.Contents.Headshot.Image = thumbnail
Review.Contents.Description.Text = review.Review 
Review.Contents.User.Text = "@" .. name