NPC Health won't update to Text

SketchySong · January 3, 2022, 6:37pm

WilliamAlezandro:

Try adding this one line and debug if the damage is being dealt with in the perspective of the running script:
humanoid  = script.Parent.Parent.Parent.Parent.Parent.Parent.Humanoid

humanoid.Health.Changed:Connect(function()
	print(humanoid.Health)
	script.Parent.Text = humanoid.Health.."/"..humanoid.MaxHealth
end)
If it prints nothing, means health is not being changed.
If it does print, there should be something wrong with other implementations.

Could you test it out if you don’t mind?

keith_220 · January 3, 2022, 6:40pm

They said that the textLabel wasnt changing its text even though the script was a child of the text label and they put

script.Parent.Text = "ABC"

on the first line

imR_otax · January 3, 2022, 6:40pm

Neither did it change the text to ABC, and also didn’t print anything, however in the script with the print function got me an error:

SketchySong · January 3, 2022, 6:42pm

It’d be appreciated if you are to show us the entirety of the script you have run on that.

keith_220 · January 3, 2022, 6:43pm

You didnt change this to Humanoid.Changed

imR_otax · January 3, 2022, 6:43pm

It’s basically just a short script parented to the TextLabel that is used to change the text
dont mind the line 1

imR_otax · January 3, 2022, 6:46pm

Also doesn’t update anything. I don’t even get any errors in the output so I can’t tell you what it really about

keith_220 · January 3, 2022, 6:47pm

If it did work that would have broke it because Health is a property which is nto an instance so there is not an event called “Changed” connected to it. After clicking Play could you then send a screenshot of the class tree. Is the TextLabel still there?

SketchySong · January 3, 2022, 6:48pm

The Changed event should be connected directly to the instance, not the property value; Hence the property name should be sent to the event as the first parameter:

humanoid  = script.Parent.Parent.Parent.Parent.Parent.Parent.Humanoid

humanoid.Changed:Connect(function(Property)
	if Property == "Health" then
		script.Parent.Text = humanoid.Health.."/"..humanoid.MaxHealth
	end
end)

imR_otax · January 3, 2022, 6:49pm

it’s still there

imR_otax · January 3, 2022, 6:50pm

This one works perfectly! That you so much all for the help!

keith_220 · January 3, 2022, 6:51pm

humanoid.Changed:Connect(function()
        print(humanoid.Health)
	script.Parent.Text = humanoid.Health.."/"..humanoid.MaxHealth
end)

do you have the print in the script still??

SketchySong · January 3, 2022, 6:52pm

I’m happy that it has worked out, I hope you’ve understood how the Changed event works as of now!

imR_otax · January 3, 2022, 6:53pm

Thank you all. Hope you have a great rest of your day.

tahabashar1 · January 3, 2022, 7:27pm

Check this maybe it will make your code more cooler.
https://developer.roblox.com/en-us/api-reference/function/Instance/GetPropertyChangedSignal