Problem with tables

Help and Feedback Code Review
#13

Read the script, the table is checked, its being inserted and removed after damaging player

#14

I know but you use part.Parent.Name, right? Could you show the script you are using?

#15

Its the exact same script that is in the post

#16

So you are not using the name of the player, but the instance of his character? Try using the name of the player as I said above.

#17

Yeah I tried using it, STILL same effect

#18

And you tried increasing the debounce? Can you show the slightly modified script please?

#19 
local damagePlayers = {}
local min = workspace.LavaWithCollision.Position - (.5 * workspace.LavaWithCollision.Size) 
local max = workspace.LavaWithCollision.Position + (.5 * workspace.LavaWithCollision.Size) 
local region = Region3.new(min, max)
local runService = game:GetService("RunService")
print(region)
while wait() do
	for index, part in pairs(workspace:FindPartsInRegion3(region, nil, 5000)) do
		if part.Parent:FindFirstChild("Humanoid") ~= nil then
			if part.Parent.Humanoid.Health ~= 0 then
			if not table.find(damagePlayers, part.Parent.Name) then
				table.insert(damagePlayers, part.Parent.Name)
				print(damagePlayers[1])
				part.Parent.Humanoid:TakeDamage(25)
				wait(0.3)
				table.remove(damagePlayers, table.find(damagePlayers, part.Parent.Name))
				end
			end
		end	
	end
end
#20

You can try fixing lava on a baseplate, just copy script, put in ServerScriptService and make lava object

#21

You can insert objects to tables… try it out

#22

Yeah, but do you know what’s the issue of it? The table is created, there is an if statement that checks if player is not in table, but you still take more damage.

#23

Can I ask why you are using a region3 and constantly checking in a while loop for all the parts inside it? You could just use the .Touched event of a part.

#24

.Touched not always detecting if the part was touched, that results in player can stand on lava

#25

Try making your hitbox a bit higher than the lava. (Invisible and cancollide to false).

#26

Its NOT a hitbox problem, its tables or loops problem

#27

When using the touched event you can cut down on loops used. But if you don’t want to use it, try printing whenever you add/remove something from a table and it’s contents so that you know what’s going on inside it at all times.

This would help with touches not detecting sometimes as more bodyparts make contact with the hitbox and not only the feet of the character.

#28

I tried that, and it still not detects sometimes, touched event is just broken sometimes

#29

I know what’s the issue!!! Checking table is in the for loop, so it will never find player in table, How can I send data from for loop to while loop?

#30

Is there any particular reason you’re using tables as a list instead of just a dictionary? This is simplified a lot by just indexing the table with the humanoid instead of iterating over the list.

local damagePlayers = {}

local min = workspace.LavaWithCollision.Position - (.5 * workspace.LavaWithCollision.Size) 
local max = workspace.LavaWithCollision.Position + (.5 * workspace.LavaWithCollision.Size) 
local region = Region3.new(min, max)

while wait() do
	for index, part in pairs(workspace:FindPartsInRegion3(region, nil, 5000)) do
		local humanoid = part.Parent:FindFirstChild("Humanoid")

		if humanoid and humanoid.Health > 0 then
			if not damagePlayers[humanoid] then
				damagePlayers[humanoid] = true

				coroutine.wrap(function()
					humanoid:TakeDamage(25)
					
					wait()

					humanoid.JumpPower = 100
					humanoid.Jump = true

					wait(0.1)

					humanoid.JumpPower = 50

					wait(0.3)

					damagePlayers[humanoid] = nil
				end)()
			end
		end	
	end
end

you’ll find too that the waits for the jump effect will cause the checks to get delayed if multiple players are involved. Wrapping the yielding sections in a coroutine helps avoid that.

2 Likes
#31

Thanks for help! I’ll try this script, Can you send me link to where can I learn coroutines?

#32

There are probably a few resources that aren’t Roblox specific if you check google, but there are some community tutorials too:

https://www.lua.org/pil/9.1.html

They can be super useful when used properly!

2 Likes