Problem with take leaderstats scripts, help is appreciated!

Help and Feedback Scripting Support
#21

If sword contains also other scripts than just “Take Time” script or only that?

#22

@vakerbrony, yes the sword contains other scripts but they are unrelated.

#23

We need the script that makes the sword deal damage, we want it to make the damaged player to change his Creator tag accordingly.

#25

@Bou_Baker, I am able to provide with a much shorter but accurate script, give me one second.

#26 
Tool = script.Parent
Handle = Tool:WaitForChild("Handle")
Mesh = Handle:WaitForChild("Mesh")

Players = game:GetService("Players")
Debris = game:GetService("Debris")
RunService = game:GetService("RunService")

BaseUrl = "http://www.roblox.com/asset/?id="

Grips = {
	Up = CFrame.new(0, 0, -1.5, 0, 0, 1, 1, 0, 0, 0, 1, 0),
	Out = CFrame.new(0, 0, -1.5, 0, -1, -0, -1, 0, -0, 0, 0, -1),
}

DamageValues = {
	BaseDamage = 5,
	SlashDamage = 10,
	LungeDamage = 30,
}

Damage = DamageValues.BaseDamage

Sounds = {
	Slash = Handle:WaitForChild("Slash"),
	Lunge = Handle:WaitForChild("Lunge"),
	Unsheath = Handle:WaitForChild("Unsheath"),
}

LastAttack = 0

ToolEquipped = false

Tool.Enabled = true

function SwordUp()
	Tool.Grip = Grips.Up
end

function SwordOut()
	Tool.Grip = Grips.Out
end

function IsTeamMate(Player1, Player2)
	return (Player1 and Player2 and not Player1.Neutral and not Player2.Neutral and Player1.TeamColor == Player2.TeamColor)
end

function TagHumanoid(humanoid, player)
	local Creator_Tag = Instance.new("ObjectValue")
	Creator_Tag.Name = "creator"
	Creator_Tag.Value = player
	Debris:AddItem(Creator_Tag, 2)
	Creator_Tag.Parent = humanoid
end

function UntagHumanoid(humanoid)
	for i, v in pairs(humanoid:GetChildren()) do
		if v:IsA("ObjectValue") and v.Name == "creator" then
			v:Destroy()
		end
	end
end

function Attack()
	Damage = DamageValues.SlashDamage
	Sounds.Slash:Play()
	local Anim = Instance.new("StringValue")
	Anim.Name = "toolanim"
	Anim.Value = "Slash"
	Anim.Parent = Tool
end

function Lunge()
	Damage = DamageValues.LungeDamage
	Sounds.Lunge:Play()
	local Anim = Instance.new("StringValue")
	Anim.Name = "toolanim"
	Anim.Value = "Lunge"
	Anim.Parent = Tool	
	local Force = Instance.new("BodyVelocity")
	Force.velocity = Vector3.new(0, 10, 0) 
	Force.maxForce = Vector3.new(0, 4000, 0)
	Debris:AddItem(Force, 0.5)
	Force.Parent = RootPart
	wait(0.25)
	SwordOut()
	wait(0.25)
	if Force and Force.Parent then
		Force:Destroy()
	end
	wait(0.5)
	SwordUp()
end

function Blow(Hit)
	if not Hit or not Hit.Parent or not CheckIfAlive() then
		return
	end
	local RightArm = (Character:FindFirstChild("Right Arm") or Character:FindFirstChild("RightHand"))
	if not RightArm then
		return
	end
	local RightGrip = RightArm:FindFirstChild("RightGrip")
	if not RightGrip or (RightGrip.Part0 ~= RightArm and RightGrip.Part1 ~= RightArm) or (RightGrip.Part0 ~= Handle and RightGrip.Part1 ~= Handle) then
		return
	end
	local character = Hit.Parent
	local humanoid = character:FindFirstChild("Humanoid")
	if not humanoid then
		return
	end
	local player = Players:GetPlayerFromCharacter(character)
	if player and (player == Player or IsTeamMate(Player, player)) then
		return
	end
	UntagHumanoid(humanoid)
	TagHumanoid(humanoid, Player)
	humanoid:TakeDamage(Damage)
end

function Activated()
	if not Tool.Enabled or not ToolEquipped or not CheckIfAlive() then
		return
	end
	Tool.Enabled = false
	local Tick = RunService.Stepped:wait()
	if (Tick - LastAttack) < 0.2 then
		Lunge()
	else
		Attack()
	end
	Damage = DamageValues.BaseDamage
	LastAttack = Tick
	Tool.Enabled = true
end

function CheckIfAlive()
	return (((Character and Character.Parent and Humanoid and Humanoid.Parent and Humanoid.Health > 0 and RootPart and RootPart.Parent and Player and Player.Parent) and true) or false)
end
function Equipped()
	Character = Tool.Parent
	Player = Players:GetPlayerFromCharacter(Character)
	Humanoid = Character:FindFirstChild("Humanoid")
	RootPart = Character:FindFirstChild("HumanoidRootPart")
	if not CheckIfAlive() then
		return
	end
	ToolEquipped = true
	Sounds.Unsheath:Play()
end

function Unequipped()
	ToolEquipped = false
end

SwordUp()

Handle.Touched:connect(Blow)

Tool.Activated:connect(Activated)
Tool.Equipped:connect(Equipped)
Tool.Unequipped:connect(Unequipped)
#27 
game.Players.PlayerAdded:Connect(function(player)
	player.CharacterAdded:Connect(function(Chr)
	wait(0.5)
	local leaderstats = player.leaderstats
	local timeAliveData = leaderstats["Time"]
	local bestTimeData = leaderstats["TopTime"]
	print("Character added")
	local Humanoid = Chr:WaitForChild("Humanoid")

	Humanoid.Died:Connect(function()
		print(player.Name.." has died!")
		local CreatorTag = Humanoid:FindFirstChild("creator")
		print(CreatorTag)

		if CreatorTag then
			print("Found a tag")
			local CreatorLeaderstats = CreatorTag.Value:WaitForChild("leaderstats", 5)
if timeAliveData.Value >= bestTimeData.Value then
       bestTimeData.Value = timeAliveData.Value
end
			CreatorLeaderstats["Time"].Value += timeAliveData.Value

timeAliveData.Value = 0

			print("Stole time!")
		else
			warn("Unable to find CreatorTag") 
		end
	end)
	end)
	end)
2 Likes
#28

Oh, so the sword creates the “creator” tag when it damages a player. Just keep your original script and change this line

to this:

local CreatorTag = Humanoid:FindFirstChild("creator")

Because the ObjectValue “creator” has a lowercase c.

1 Like
#29

Hey, @Bou_Baker, the script isn’t working, I may have done something wrong.

The only print am getting in the output is “Player added”. The rest won’t appear, meaning the script stopped working after the player was added I am guessing.

1 Like
#30

Did you try replacing your script with @flkfv 's script? His script might work.

1 Like
#31

Yes, I replaced mine with his, I still got nothing. Am not sure what’s the problem.

#32

How are you testing the script exactly? Are you killing other players or something?

#33

I have been testing this in a 2 player local server.

#34

I’ve noticed when a player kills another player, the player that died gets the creator tag with the player that killed him last but, the time does not transfer from player to player.

#35

Can you show me what’s in the output box when a player is killed?

#36

Hey @Bou_Baker, when a player dies, nothing prints in the output. The only print is “Character Added”.

#37

This is really weird,

why isn’t this event firing when a player is killed? :thinking:

1 Like
#38

Hey @Bou_Baker, I tried the script again and the script worked perfectly the first time but then it would break the second time…

#39

I literally just joined again and, the script doesn’t work at all.

Could it be that it only works in a public server and not studio?

#40

Hmm, try moving the “Take Time” script from ClassicSword to ServerScriptService.

1 Like
#41

Oh my…

It finally worked! :partying_face:

Thank you so much! :partying_face:

I really appreciate it!

(I feel silly not knowing I had to move it to ServerScriptService :man_facepalming:)

Thanks again, took me days to get the answer. (Marked your post as a solution)

1 Like