[SOLVED] Badge giver script not working

Help and Feedback Scripting Support
, ,
#5

Yes, I am doing that, If the ball falls down to the void.

#6

Code doesn’t work, It doesn’t award the badge to the player.

#7

You should then do something along the lines of

local ball = game:GetService("Workspace").ball

game:GetService("Workspace").DescendantRemoving:Connect(function(descendant) --RBXScriptSignal that gets fired when something is removed from workspace
    if descendant == ball then -- The object that is being removed is the ball
        -- Do what you want
    end
end)
#8

do you want to give the badge to all the players?

game.Workspace.DescendantRemoving:Connect(function(Descendant) -- Checks whenever a Descendant is removed from workspace.
if Descendant.Name == "YourBallName" then
for i,v in pairs(game.Players:GetPlayers()) -- Looping through all of the players.
if game:GetService("BadgeService"):UserHasBadge(v.UserId,BadgeID) then return end -- Checking if the user already has the badge.
game:GetService("BadgeService"):AwardBadge(v.UserId,BadgeID) -- Awarding the Badge to all of the players.
end
end
end)
#9

doesn’t work the ball just gets stuck at the void

#10

The RBXScriptSignal only executes when it is destroyed so if you have something blocking the ball from falling in the void I would recommend removing it.

#11

the ball lags out and doesnt even give a badge, i disabled any castshadow, massless and deleted those 4 parts in the game

#12

Can you show the new code? So I can see what’s happening?

#13

THDN
THDN500×540 92.5 KB

#14

I’m sorry but this doesn’t really help me to know what’s going on since I need to see the code but not the Script location

#15

wait let me test it out first hold on

#16

https://gyazo.com/5dc426b0c57e2b622f534124b8cd9d1a

#17

So you want the last player that touched the ball that threw it into the void to get a badge is that right?

#18

here is the code

local ball = game:GetService("Workspace").ball
local BadgeID = 2127919489

game:GetService("Workspace").DescendantRemoving:Connect(function(descendant) --RBXScriptSignal that gets fired when something is removed from workspace
	if descendant == ball then -- The object that is being removed is the ball
		game.Players.PlayerAdded:Connect(function(p)
			game:GetService("BadgeService"):AwardBadge(p.UserId, BadgeID)
		end)
	end
end)
#19

yes it is, and i want it the badge to be rewarded to everyone

#20

This should do the job

local ball = game:GetService("Workspace").ball

game:GetService("Workspace").DescendantRemoving:Connect(function(descendant) --RBXScriptSignal that gets fired when something is removed from workspace
    if descendant == ball then -- The object that is being removed is the ball
        for _,v in pairs(game:GetService("Players"):GetPlayers()) do
            game:GetService("BadgeService"):AwardBadge(v.UserId, BadgeID)
        end
    end
end)

If the thing above didn’t work, you should try this:

local ball = game:GetService("Workspace").ball

game:GetService("Workspace").DescendantRemoving:Connect(function(descendant) --RBXScriptSignal that gets fired when something is removed from workspace
    if descendant.Name == ball.Name then -- The object that is being removed is the ball
        for _,v in pairs(game:GetService("Players"):GetPlayers()) do
            game:GetService("BadgeService"):AwardBadge(v.UserId, BadgeID)
        end
    end
end)
#21

Adding to what mentioned above,
you should always wrap such calls in pcalls. Example:

local success,result = pcall(function()
    return game:GetService("BadgeService"):UserHasBadgeAsync(Player.UserId,BadgeID)
end)

if success then
   if not result then
    --award him here.
   end
end
#22

it didn’t work i putted the print thing it worked, but the badge still didnt award i do not know why
agdshfnm

#23

As @Valkyrop said you should check if the player first has a badge so to do this I would do it like this:

local ball = game:GetService("Workspace").ball
local BadgeID = 2127919489

game:GetService("Workspace").DescendantRemoving:Connect(function(descendant) --RBXScriptSignal that gets fired when something is removed from workspace
    if descendant == ball then -- The object that is being removed is the ball
        for _,v in pairs(game:GetService("Players"):GetPlayers()) do
            local success,hasBadge = pcall(function() -- pcall so it returns the value and if there was an error
                return game:GetService("BadgeService"):UserHasBadgeAsync(v.UserId,BadgeID) -- Check if the player has the badge using RobloxAPI
            end)
            
            if success and not hasBadge then
                game:GetService("BadgeService"):AwardBadge(v.UserId, BadgeID) -- No error happened and the player does not own the badge so you can award it
            end
        end
    end
end)
#24

I just realised that the badge was in the incorrect place. Thank you for the help.