Stats don't save when reducing your stats

[zaydoudou (Codoudou)]

1. What do you want to achieve? Keep it simple and clear!
   I want to make a chat tags shop where you spend your coins for chat tags
2. What is the issue? Include screenshots / videos if possible!
   The issue is that when i buy any item in the shop and then rejoin, the stats don’t save which makes me able to buy it again
   Here is the script:

local Cost = 100
local ChatTagColor = "123,255,0"
local ChatTag = "Cool"
local plr = game.Players.LocalPlayer
script.Parent.MouseButton1Click:Connect(function()
	if plr:WaitForChild("leaderstats").Coins.Value >= Cost and plr:WaitForChild("SecretFolder").ChatTag.Value ~= ChatTag then
		plr.leaderstats.Coins.Value -= Cost
		plr.SecretFolder.ChatTag.Value = ChatTag
		plr.SecretFolder.ChatTagColor.Value = ChatTagColor
		script.Parent.Text = "Equipped"
	elseif plr:WaitForChild("leaderstats").Coins.Value < Cost then
		script.Parent.Text = "Not enough coins!"
	elseif plr:WaitForChild("SecretFolder").ChatTag.Value == ChatTag then
		script.Parent.Text = "You already have it equipped!"
	end
end)

3. What solutions have you tried so far? Did you look for solutions on the Developer Hub?
   I can’t find any solution.

[zaydoudou (Codoudou)]

Bump because this topic is being ignored (sort of)

[heII_ish (hellish)]

Use DataStores, there are many tutorials and threads on how to use them. Here are just a few examples I found by typing “save” in the searchbar Lol…

Datastore Tutorial for Beginners

Hey amazing developers! I’ve created a tutorial for new people regarding the datastore and how to save multiple/singular data. This tutorial will cover alot of things so if you’re new make sure you have your water ready! In this tutorial im gonna try my best to explain every single line as possible assuming that you’re really new to coding, but if you already know some basic stuff, This tutorial is gonna go faster for you! For any improvements for this topic/thread please comment down…

Save your player data with ProfileService! (DataStore Module)

Just a quick performance nitpick. I dont see the need to run this every frame? RunService.Heartbeat:Connect(function(dt) -- 1) Auto saving: -- local auto_save_list_length = #AutoSaveList if auto_save_list_length > 0 then local auto_save_index_speed = SETTINGS.AutoSaveProfiles / auto_save_list_length local current_tick = tick() while current_tick - LastAutoSave > auto_save_index_speed do LastAutoSave = LastAutoSave + auto_save_index_speed local profile = AutoSaveList[AutoS…

[zaydoudou (Codoudou)]

I am literally using it
The problem is that only the incremented stats save
But thanks for your recommendation

[heII_ish (hellish)]

Can you provide the script that you’re using to save the data?

[zaydoudou (Codoudou)]

Here is the script

local DataStoreService = game:GetService("DataStoreService")
local DataStore = DataStoreService:GetDataStore("DataStore")
game.Players.PlayerAdded:Connect(function(plr)

	local leaderstats = Instance.new("Folder",plr)
	leaderstats.Name = "leaderstats"

	local Wins = Instance.new("NumberValue")
	Wins.Name = "Wins"
	Wins.Parent = leaderstats

	local Coins = Instance.new("NumberValue")
	Coins.Name = "Coins"
	Coins.Parent = leaderstats	
	
	local SecretFolder = Instance.new("Folder",plr)
	SecretFolder.Name = "SecretFolder"
	
	local ChatTag = Instance.new("StringValue")
	ChatTag.Name = "ChatTag"
	ChatTag.Parent = SecretFolder
	
	local ChatTagColor = Instance.new("StringValue")
	ChatTagColor.Name = "ChatTagColor"
	ChatTagColor.Parent = SecretFolder
	
	local PlayerUserId = "Player_"..plr.UserId
	local success, errormessage = pcall(function()
		data = DataStore:GetAsync(PlayerUserId, data)
	end)
	if success then
		Wins.Value = data.Wins
		Coins.Value = data.Coins
		ChatTag.Value = data.ChatTag
		ChatTagColor.Value = data.ChatTagColor
	end
end)
game.Players.PlayerRemoving:Connect(function(plr)
	local PlayerUserId = "Player_"..plr.UserId

	local data = {
		Wins = plr.leaderstats.Wins.Value;
		Coins = plr.leaderstats.Coins.Value;
		ChatTag = plr.SecretFolder.ChatTag.Value;
		ChatTagColor = plr.SecretFolder.ChatTagColor.Value;
	}

	local success, errormessage = pcall(function()
		DataStore:SetAsync(PlayerUserId, data)
	end)

	if success then
		print('Data Successfully Saved!')
	end
	if errormessage then
		print('Data UnSuccessfully Saved!')
		warn(errormessage)
	end
end)

I copied this script from a tutorial almost a year ago the time when i didn’t have any database knowledge (now i do) but i don’t see to find the issue here

[heII_ish (hellish)]

So it saves when you earn coins and leave the game, but not when you spend coins and leave?

[zaydoudou (Codoudou)]

Yep, it doesn’t save when you spend coins and leave no matter how long you wait

[heII_ish (hellish)]

When you test it in studio, does it say “Data Successfully Saved!” in the output when you leave?

[zaydoudou (Codoudou)]

Yep, it does print “Data Successfully Saved!” in the output. But when you rejoin the game you will still have the old/incremented stats

[heII_ish (hellish)]

@zaydoudou

local success, errormessage = pcall(function()
		data = DataStore:GetAsync(PlayerUserId, data)
	end)

Try replacing that with

local data
local success, errormessage = pcall(function()
	data = DataStore:GetAsync(PlayerUserId)
end)

[zaydoudou (Codoudou)]

That won’t work because the player stats database is stored like this (Pretend that this thing works

Database = {
             "Player_123456789"={
                                            Wins=5;
                                            Coins=10;
                                            ChatTag = "";
                                            ChatTagColor = "";
            };
}

[lluckvy (aaron)]

Is this a local script? Because of FE any changes made on the client will not replicate (unless you use an event)

[heII_ish (hellish)]

What do you mean? GetAsync should only have 1 parameter

[zaydoudou (Codoudou)]

The button buy script is a local script
And the database script is a script

[heII_ish (hellish)]

Oh then in that case you should be firing a remote to let the server know that the player is buying something and then do the coin subtraction on the server

[lluckvy (aaron)]

So you would need to use an event to handle the currency change because if you save your data on the server then you would also need to save this on the server

You should be saving your data on the server anyways

[zaydoudou (Codoudou)]

I tried your suggestion and i got an error saying attempt to perform arithmetic (sub) on number and Instance
And here is the script

game.ReplicatedStorage.BuyEvent.OnServerEvent:Connect(function(plr,Cost,ChatTag,ChatTagColor)
	plr.leaderstats.Coins.Value -= Cost --This line causes the error
	plr.SecretFolder.ChatTag.Value = ChatTag
	plr.SecretFolder.ChatTagColor.Value = ChatTagColor
end)

And this is where it fires the event

local Cost = 1125
local ChatTagColor = "255, 0, 243"
local ChatTag = "ChatTag"
local plr = game.Players.LocalPlayer
game.ReplicatedStorage.BuyEvent:FireServer(plr,Cost,ChatTag,ChatTagColor)

[heII_ish (hellish)]

You shouldn’t be passing the player argument when using FireServer, it’s automatically included.

game.ReplicatedStorage.BuyEvent:FireServer(Cost,ChatTag,ChatTagColor)

[lluckvy (aaron)]

@zaydoudou

:FireServer(plr,Cost,ChatTag,ChatTagColor)

This is unnecessary as the player is automatically the first parameter when firing to the server

local event = game.ReplicatedStorage:WaitForChild('BuyEvent')

script.Parent.MouseButton1Click:Connect(function()
    event:FireServer(Cost,ChatTag,ChatTagColor)
end)

local event = game.ReplicatedStorage:WaitForChild('BuyEvent')

event.OnServerEvent:Connect(function(player,Cost,ChatTag,ChatTagColor)
    local stats = player:WaitForChild('leaderstats')
	if stats.Coins.Value >= Cost then
        player.stats.Coins.Value -= Cost
        player.SecretFolder.ChatTag.Value = ChatTag
	    player.SecretFolder.ChatTagColor.Value = ChatTagColor
    end
end)