Struggling with a particular Animation problem

RobertJr_YT · March 26, 2020, 2:38pm

Nope. Same effect, it outputted 1 and 2 again.

Bytify · March 26, 2020, 2:39pm

Try this.

Code (on the client):

local Player = game.Players.LocalPlayer
local Character = Player.Character or Player.CharacterAdded:Wait()
local Humanoid = Character.Humanoid or Character:WaitForChild("Humanoid")
local KeyframeSequence = game:GetService("KeyframeSequenceProvider")

local function playAnimation() -- Call this function when you want to play the animation
    local Animation = Instance.new("Animation")
    Animation.AnimationId = "http://www.roblox.com/asset/?id=4820283660"

    local success = pcall(function()
        keyframeSequence = KeyframeSequence:GetKeyframeSequenceAsync(Animation) 
    end)

    if success then
        keyframes = keyframeSequence:GetKeyframes()
        local lastFrame = keyframes[#keyframes]

        local marker = Instance.new("KeyframeMarker"); marker.Name = "ReachedLastFrame"
        lastFrame:AddMarker(marker)

        local animTrack = Humanoid:LoadAnimation(Animation)

        animTrack:GetMarkerReachedSignal("ReachedLastFrame"):Connect(function()
            animTrack:AdjustSpeed(0)
        end)

       animTrack:Play()
    end
end

playAnimation()

RobertJr_YT · March 26, 2020, 2:45pm

I saved the code I was using with @Spraden just in-case your code doesn’t work. I had to do some modifications to the code since the final end was underlined. Another thing is

keyframes = keyframeSequence:GetKeyframes()

“keyframes” in the code above was underlined too in red.

Modified version of code:

local Character = game.Workspace.RobertJr_YT
local Humanoid = Character.Humanoid or Character:WaitForChild("Humanoid")
local KeyframeSequence = game:GetService("KeyframeSequenceProvider")

local function playAnimation() -- Call this function when you want to play the animation
    local Animation = Instance.new("Animation")
    Animation.AnimationId = "http://www.roblox.com/asset/?id=4820283660"

    local success = pcall(function()
        keyframeSequence = KeyframeSequence:GetKeyframeSequenceAsync(Animation) 
    end)

    if success then
        local keyframes = keyframeSequence:GetKeyframes()
        local lastFrame = keyframes[#keyframes]

        local marker = Instance.new("KeyframeMarker"); marker.Name = "ReachedLastFrame"
        lastFrame:AddMarker(marker)

        local animTrack = Humanoid:LoadAnimation(Animation)

        animTrack:GetMarkerReachedSignal("ReachedLastFrame"):Connect(function()
            animTrack:AdjustSpeed(0)
        end)

        animTrack:Play()

		playAnimation()
    end
end

EDIT: There is no output.
EDIT2: Even when moving “playAnimation()” to the very bottom to where it was before, there still is no output.

Bytify · March 26, 2020, 2:49pm

Ohhh! You want to play an animation on an NPC! Lemme write some code for that.

RobertJr_YT · March 26, 2020, 2:50pm

Good thing I saved @Spraden 's code just in-case.

Spraden · March 26, 2020, 2:56pm

His code is basically what I have done—though it animates the player, and it’s cleaned up (His looks much nicer admittedly). This is very odd to work on as there is no documentation on inserting Markers and then connecting them to a function. It is possible to create Markers in the animation editor, then rename one on the last frame to “ReachedLastFrame”. That would drastically reduce the code and simplify just about everything.

You wouldn’t have to search through the KeyframeSequence to find the last frame, you wouldn’t have to add the marker to the frame, etc… You’d simply play the animation as you normally would then use the GetMarkerReachedSignal() method.

animTrack:GetMarkerReachedSignal("ReachedLastFrame"):Connect(function()
    animTrack:AdjustSpeed(0)
end)

But damn do I wanna figure this out. I’ve been stumped on this for hours… and it’s getting to me!

I have been through so many pages trying to find proper documentation for being able to reference the KeyframeSequence. Maybe we have to clone the original from the animation, then add the marker to the last keyframe, then turn the new KeyframeSequence into an animation track.

Whatever the answer is, it better be out there. I hope I find it

Edit: Here’s how to do it in the animation editor

RobertJr_YT · March 26, 2020, 2:59pm

You probably are one of the most helpful person I’ve interacted with on the forum. Going all this way just to a person you don’t know I find very respectful and kind of you. Especially constantly trying to find a solution for me. I almost feel bad for myself to be honest, too bad I don’t have much coding experience myself.

like I said before, take your time if you still have the desire. I’ll be working on some other things for the game in the meantime.

RobertJr_YT · March 26, 2020, 3:05pm

Alright. Make sure to take into account what @Spraden said in the post above.

Bytify · March 26, 2020, 3:05pm

I think I figured it out!

Try this code:

local Character = game.Workspace.RobertJr_YT
local Humanoid = Character.Humanoid or Character:WaitForChild("Humanoid")
local KeyframeSequence = game:GetService("KeyframeSequenceProvider")

local function playAnimation() -- Call this function when you want to play the animation
    local Animation = Instance.new("Animation")
    Animation.AnimationId = "rbxassetid://4820283660"

    local success, err = pcall(function()
        keyframeSequence = KeyframeSequence:GetKeyframeSequenceAsync(Animation.AnimationId) 
    end)

    if success then
        local keyframes = keyframeSequence:GetKeyframes()
        local lastFrame = keyframes[#keyframes - 1]

        local marker = Instance.new("KeyframeMarker"); marker.Name = "ReachedLastFrame"
        lastFrame:AddMarker(marker)

        local animTrack = Humanoid:LoadAnimation(Animation)

        animTrack:GetMarkerReachedSignal("ReachedLastFrame"):Connect(function()
            animTrack:AdjustSpeed(0)
        end)

        animTrack:Play()
    end
end

playAnimation()

It worked for one of my animations, so let me know if you have any issues.

RobertJr_YT · March 26, 2020, 3:12pm

2 things with this script. 1, It stops the animation a little too soon. 2, It doesn’t work to be connected with the event from before. I tried changing it to work with the RemoteEvent, but I ended up screwing the script up anyway.

Spraden · March 26, 2020, 3:12pm

Can you explain exactly what you’ve changed por favor? It looks like you added , err to the pcall function and set the last frame to be one minus #keyframes.

Did the , err end up actually getting you through that block of code? @RobertJr_YT

Edit: It seems it did work! Nice job @xBearByte.

Robert you should be able to use #keyframes instead of #keyframes - 1, that is most likely why your animation is stopping short.

Change

local lastFrame = keyframes[#keyframes - 1]
to
local lastFrame = keyframes[#keyframes]

Bytify · March 26, 2020, 3:13pm

It was the KeyframeSequence:GetKeyframeSequenceAsync() function call. The parameter is the animation’s id not the animation itself.

Spraden · March 26, 2020, 3:13pm

We did that before, just calling the ID. I wonder why it didn’t work then

Bytify · March 26, 2020, 3:14pm

Change keyframes[#keyframes - 1] to keyframes[#keyframes]
You don’t need the remote event. You should run this code on the server and every client will see it!

Bytify · March 26, 2020, 3:15pm

I think it’s because you were using this: "http://www.roblox.com/asset/?id=4820283660". I used this: "rbxassetid://4820283660".

RobertJr_YT · March 26, 2020, 3:15pm

I changed that and it still only prints 1 and 2 to the Console.

The code:

local NPCevent = game:GetService("ReplicatedStorage"):WaitForChild("NPCevent")
local Humanoid = game.Workspace.RobertJr_YT:FindFirstChild("Humanoid")
local keyframeTable
local KeyframeSequence = game:GetService("KeyframeSequenceProvider")

local function onRemoteFiredFromServer() -- Function for when remote is fired at client
	local Animation = Instance.new("Animation")
	Animation.AnimationId = "http://www.roblox.com/asset/?id=4820283660"
		print("1")
		local success = pcall(function()
		print("2")
		keyframes = KeyframeSequence:GetKeyframeSequenceAsync(4820283660) -- proper method to retrieve the KeyframeSequence
		end)
	
		if success then
		keyframeTable = keyframes:GetKeyframes() -- creates a table containing the keyframes
		print("3")
		local count = 0
		for _ in pairs(keyframeTable) do count = count + 1 end -- Iterates through every item and adds 1 to the counter.
		
		print("4")
		local lastFrame = keyframes[#keyframes] -- identifies the last frame
		print("5")
		local marker = Instance.new("KeyframeMarker") -- creates the marker
		marker.Name = "ReachedLastFrame"
		lastFrame:AddMarker(marker) -- parents the marker to the last keyframe
		print("6")
			
		local AnimationTrack = Humanoid:LoadAnimation(Animation) -- Now we load the AnimationTrack after the Marker has been added
		
		print("7")
		local function reachedLastFrame()
		print("8")
		AnimationTrack:AdjustSpeed(0)
		print("9")
		end
		
		print("10")
		local onLastFrame = AnimationTrack:GetMarkerReachedSignal("ReachedLastFrame")
		onLastFrame:Connect(reachedLastFrame)
		Animation:Play()
	end
end


NPCevent.OnClientEvent:Connect(onRemoteFiredFromServer) -- Will call onRemoteFired() when the remote is fired from the server

Bytify · March 26, 2020, 3:16pm

You should try running my code on the server!

RobertJr_YT · March 26, 2020, 3:17pm

Sorry I’m working with two codes here. It gets very confusing working back and fourth between two people.

Currently this is the main code I’ve been using:

local NPCevent = game:GetService("ReplicatedStorage"):WaitForChild("NPCevent")
local Humanoid = game.Workspace.RobertJr_YT:FindFirstChild("Humanoid")
local keyframeTable
local KeyframeSequence = game:GetService("KeyframeSequenceProvider")

local function onRemoteFiredFromServer() -- Function for when remote is fired at client
	local Animation = Instance.new("Animation")
	Animation.AnimationId = "rbxassetid://4820283660"
		print("1")
		local success = pcall(function()
		print("2")
		keyframes = KeyframeSequence:GetKeyframeSequenceAsync(4820283660) -- proper method to retrieve the KeyframeSequence
		end)
	
		if success then
		keyframeTable = keyframes:GetKeyframes() -- creates a table containing the keyframes
		print("3")
		local count = 0
		for _ in pairs(keyframeTable) do count = count + 1 end -- Iterates through every item and adds 1 to the counter.
		
		print("4")
		local lastFrame = keyframes[#keyframes] -- identifies the last frame
		print("5")
		local marker = Instance.new("KeyframeMarker") -- creates the marker
		marker.Name = "ReachedLastFrame"
		lastFrame:AddMarker(marker) -- parents the marker to the last keyframe
		print("6")
			
		local AnimationTrack = Humanoid:LoadAnimation(Animation) -- Now we load the AnimationTrack after the Marker has been added
		
		print("7")
		local function reachedLastFrame()
		print("8")
		AnimationTrack:AdjustSpeed(0)
		print("9")
		end
		
		print("10")
		local onLastFrame = AnimationTrack:GetMarkerReachedSignal("ReachedLastFrame")
		onLastFrame:Connect(reachedLastFrame)
		
		Animation:Play()
	end
end


NPCevent.OnClientEvent:Connect(onRemoteFiredFromServer) -- Will call onRemoteFired() when the remote is fired from the server

EDIT: I did multiple changes with statements you guys made above with the code. Still only prints in the Console 1 and 2.

Bytify · March 26, 2020, 3:23pm

Did my code work?

[30 characters]

RobertJr_YT · March 26, 2020, 3:23pm

I’ll give it a shot again after @Spraden replies.