TextBounds signal does not fire upon parenting

[Tomarty]

I just got back from my 2 week honeymoon in Italy and a handful of the Gui’s in my game seem to behave strangely.

My chat input UI normally resizes depending on the label’s TextBounds:

Expected behavior:

The tooltips across my game were also broken:

Expected behavior:

Here’s a repro:

local label = Instance.new("TextLabel")
label.Text = "First test!"
label:GetPropertyChangedSignal("TextBounds"):Connect(function()
    print("TextBounds changed:", label.TextBounds)
end)

print("TextBounds before:", label.TextBounds)
label.Parent = script.Parent
print("TextBounds after parenting:", label.TextBounds)

wait(1)

print("Changing text...")
label.Text = "Second test!"

Here’s the output with the bug:

TextBounds before: 0, 0
TextBounds after parenting: 48, 12
Changing text...
TextBounds changed: 67, 12

The previous behavior would output this:

TextBounds before: 0, 0
TextBounds changed: 48, 12
TextBounds after parenting: 48, 12
Changing text...
TextBounds changed: 67, 12

I fixed most of these issues in my game, but this should still be fixed.

[inHeadspace (Jeni)]

Try :GetTextSize(), I believe it’s a function of TextService but I’m not sure.

[DarkContinuum]

Yeah, this happened with the recent UI update

New UI backend going live soon

This is similar to a snippet we found in the in-game chat code. If you’ve forked the in-game chat, you should update your fork to get the fix we did for this.

This exact snippet is an easy fix: Just use TextService:GetTextSize() instead of TextBounds .

What happened with this code is that, because AbsoluteSize doesn’t fire immediately during setting the Size property, HeldLock would be set to false , and the Changed event would fire at the end of the frame because it wasn’t observed in any other way. This means that at the end of the frame, the changed handler will run and then cause the update function to run all over again - causing the Update() function to run every frame when it wouldn’t have before.

I hope you enjoyed your honeymoon

[Tiffblocks]

I’ll work on fixing this soon. If you want, I can add your game to a blacklist for the new system until then.

[Tomarty]

Thanks! but my problems weren’t too hard to fix by refreshing textbounds after parenting.