Tool saving script won't work

Help and Feedback Scripting Support
#8

Make sure no values are nil, so I recommend printing ToolFolder, Backpack, and StarterPack before the loop through ToolData, and make sure ToolData is not nil either

1 Like
#9

When I printed tool folder I got nil does that help you?

#10

You need to reference ToolFolder properly. Check it’s directory to see if it’s there

1 Like
#11

Im kind of a noob could you elaborate on that please?

#12

So I see that when you set the value ToolFolder you do

game:GetService(“ServerStorage”):WaitForChild(“SavedTools”)

Check ServerStorage and see if the folder SavedTools is there, if it isn’t add one

1 Like
#13

I finished it @zhenjie2003Alt. There wasn’t one so I added it.

#14

Well it should work now. Try it and if it works please mark me as solution.

1 Like
#15

It doesn’t work @zhenjie2003Alt but it got rid of the error.

#16

Then it’s something else with your code. I can’t help any further right now so either you’re gonna have to figure it out yourself or have someone else help sorry.

1 Like
#17

Are you still having problems or is it fixed?

1 Like
#18

Could you mention or check what exactly is inside ToolData?

1 Like
#19

He puts the name of every tool on the player inside the ToolData

1 Like
#20

Still the same error sadly, I might give up

#21

Which error? thought the ToolFolder one was fixed

1 Like
#22

Why did you separate this 2 functions?

1 Like
#23

It was a typo. @Sarturex857 whoops my bad.

#24

No errors by error I meant it doesn’t work.

#25

When you load the data from the datastore to the player backpack also clone it and put it into toolFolder

1 Like
#26

So, I made kind of the same system but with bools, I’ve made some changes in my script, and now it can save tools.

local Savings = game:GetService('DataStoreService'):GetDataStore('Tools')
local RS = game:GetService('ReplicatedStorage')

local tools = RS.Tools -- you can change this, type the ubication of the folder that contains your tools

local data

local tabb = {}

game.Players.PlayerAdded:Connect(function(plr)
	--give data
	local s, e = pcall(function()
		data = Savings:GetAsync(plr.UserId)

		for i, v in pairs(tools:GetChildren()) do
			if data ~= nil then
				local cloned_tool = tools:FindFirstChild(data[v.Name]):Clone()
				cloned_tool.Parent = plr.Backpack
			end	
		end
	end)

	if not s then
		print(e)
	end
end)

game.Players.PlayerRemoving:Connect(function(plr)
	--save data
	local tools = plr.Backpack
	plr.Character.Humanoid:UnequipTools()

	local s, e = pcall(function()
		for i, v in pairs(tools:GetChildren()) do
			tabb[v.Name] = v.Name
		end
		Savings:SetAsync(plr.UserId, tabb)
	end)
	if not s then
		warn(e)
	end
end)
2 Likes
#27

Replace this line with

ToolData = SaveData:GetAsync(Player.UserId) or {}

I also don’t see that the data is being saved. If you are planning to save this tool table, make sure to JSONEncode it before saving and JSONDecode it before passing it into the for loop

1 Like