Trying to make damage indicator expire after 6 seconds

[Yo_w0 (Yowo)]

You can write your topic however you want, but you need to answer these questions:

1. What do you want to achieve?

• I am trying to make it so that this damage indicator expires after 6 seconds if no damage has been taken. Don’t worry about the fact that that there is no compatibility for multiple characters taking damage, I’ll get that sorted myself.

2. What is the issue?

• Instead of the indicator expiring after 6 seconds of no damage being dealt, it does not disconnect and expires 6 seconds after it is first added.

3. What solutions have you tried so far?

• Looked all around DevForum with tags like “damage indicator”, “disconnect”, “indicator”, etc.

• Asked ChatGPT

• Tried delay(6, function)

• Tried wait(6)

• Tried a for loop

Here is the code:

local player = game.Players.LocalPlayer
repeat wait() until player.Character ~= nil
local char = player.Character or player.CharacterAdded:Wait()

local tweenservice = game:GetService("TweenService")
local replicatedstorage = game:GetService("ReplicatedStorage")
local remote = replicatedstorage.Remotes.NumericText

currentgui = nil
lnum = 0
timerHandle = nil

function changeguinumber(person, gui, num, amount, oper)
	if oper == "Damage" then

		if timerHandle ~= nil then
			print("cd")
			timerHandle:Disconnect()
			timerHandle = nil
		end

		local att = gui.Adornee
		att.WorldCFrame = person.HumanoidRootPart.CFrame

		gui.Template.TextColor3 = Color3.fromRGB(200,0,0)

		local txt = tostring("-" .. math.round((num + amount)*10)/10)
		print(txt)
		local subbedtxt = string.sub(txt, 2, #txt)

		gui.Template.Text = txt
		gui.Template.Shadow.Text = txt
		lnum = tonumber(subbedtxt)
		print(lnum)

		print("dmg")
		gui.StudsOffsetWorldSpace -= Vector3.new(0,1,0)
		tweenservice:Create(gui, TweenInfo.new(1, Enum.EasingStyle.Quad, Enum.EasingDirection.Out, 0, false, 0),
			{StudsOffsetWorldSpace = gui.StudsOffsetWorldSpace + Vector3.new(0,1,0)}):Play()

		timerHandle = coroutine.wrap(function()
			wait(6)
			print("destroy")
			currentgui:Destroy()
			currentgui = nil
			lnum = 0
			timerHandle = nil
		end)()

	elseif oper == "Heal" then

		if timerHandle then
			timerHandle:Disconnect()
			timerHandle = nil
		end

		local att = gui.Adornee
		att.WorldCFrame = person.HumanoidRootPart.CFrame

		gui.Template.TextColor3 = Color3.fromRGB(53, 204, 63)

		local txt = tostring("+" .. math.round((amount)*10)/10)
		local subbedtxt = string.sub(txt, 2, #txt)

		gui.Template.Text = txt
		gui.Template.Shadow.Text = txt

		lnum = tonumber(subbedtxt)
		print("destroy")
		gui.StudsOffsetWorldSpace -= Vector3.new(0,1,0)
		tweenservice:Create(gui, TweenInfo.new(1, Enum.EasingStyle.Quad, Enum.EasingDirection.Out, 0, false, 0),
			{StudsOffsetWorldSpace = gui.StudsOffsetWorldSpace + Vector3.new(0,1,0)}):Play()

		timerHandle = coroutine.wrap(function()
			wait(6)
			print("uhh")
			currentgui:Destroy()
			currentgui = nil
			lnum = 0
			timerHandle = nil
		end)()
	end
end

function makegui(damage, person, oper)
	local att = Instance.new("Attachment")
	att.Parent = workspace.BaseAttPart
	att.WorldCFrame = person.HumanoidRootPart.CFrame

	local indicator = script.Indicator:Clone()
	indicator.Enabled = true
	indicator.Parent = person
	indicator.Adornee = att
	indicator.Template.Text = damage
	indicator.Template.Shadow.Text = damage

	return indicator
end

function showdamage(damage, person, oper)

	local gui

	if oper == "Damage" then

		if not currentgui then
			local newGui = makegui(damage, person, oper)
			currentgui = newGui
			changeguinumber(person, newGui, lnum, damage, oper)
			
		elseif currentgui then
			gui = currentgui
			changeguinumber(person, gui, lnum, damage, oper)
		end

	elseif oper == "Heal" then

		if not currentgui then
			local newGui = makegui(damage, person, oper)
			currentgui = newGui
			changeguinumber(person, newGui, lnum, damage, oper)
			
		elseif currentgui then
			gui = currentgui
			changeguinumber(person, gui, lnum, damage, oper)
		end
	end
end

remote.OnClientEvent:Connect(function(person, damage, oper)
	if person ~= char then
		showdamage(damage, person, oper)
	end
end)

Thanks for any help you can provide.

[Yo_w0 (Yowo)]

@Yo_w0

Looked all around DevForum

Guess I didn’t look all around DevForum, and found this:

@TheeDeathCaster

That should be fairly simple – you could have a variable assigned to a number, and subtract from the number. Once the number is less than or equal to 0, hide the GUI.

local TotalDisplayTime = 0 -- Indicator of how long to show the gui for
local DamageIndicator = path_to_int_value -- Self-explanatory

DamageIndicator.Changed:Connect(function(DamageNum) -- Listen for when the damage indicator's value changes, and see what number was passed
    if DamageNum > 0 then -- Was more than 0 damage dealt?
        TotalDisplayTime = 10 -- Set the variable to 10, the amount of seconds to display for. When the damage indicator is changed, the variable will be set to 10 again.
    end
end)

RunService.Stepped:Connect(function(_, Step) -- Get the step passed by Stepped
    if TotalDisplayTime > 0 then -- Is the time greater than 0?
        TotalDisplayTime -= Step -- Subtract from the time
    else -- Otherwise
        -- Hide the gui now
    end
end)

It isn’t as complicated as it looks. This simply changes TotalDisplayTime to 10 if the DamageNum – passed by DamageIndicator – was greater than 0. Then, in the function that Stepped calls every, well, step, it subtracts from the total time by how long it took for the step. Then, when the total time is 0 or less, it hides the GUI.