Unban event won't unban individual

Help and Feedback Scripting Support
,
#21

Does your LocalScript still not work?

#22

Local script hasn’t been working for the unban, but it works for the ban

#23

Use this as the unban server script:

game.ReplicatedStorage.UnBan.OnServerEvent:Connect(function(player, PlayerNameTextBox, ReasonTextBox)
	local DataStoreService = game:GetService("DataStoreService")
	local TempBanPlayerDataStore = DataStoreService:GetDataStore("TemporaryBanPlayerData")
	local PermBanPlayerDataStore = DataStoreService:GetDataStore("PermanentBanPlayerData")
	
	for i,v in pairs(TempBanPlayerDataStore:GetAsync()) do
		if PlayerNameTextBox ~= v then
			continue
		end
		
		TempBanPlayerDataStore:RemoveAsync(v)
	end
end)
#24

But, It’s not gonna work if the FireServer script won’t work.

#25

What’s the LocalScript parented to?

#26

The local script is parented to the frame.

#27

Weird, it should work then, I’m guessing UNBAN is a button but I don’t know why it wouldn’t fire, any errors?

#28

No errors at all when I press it, nor any when I connect.

#29

Can I see how it is structured in the explorer?

#30

image
image383×509 28.2 KB

1 Like
#32

This is also completely wrong, because GetAsync:
“This function returns the latest value of the provided key and a [DataStoreKeyInfo] […] instance. If the key does not exist or if the latest version has been marked as deleted, both return values will be nil.”
That means running :GetAsync() without a key will instantly result in nil.
You will need to run :ListKeysAsync() but this is a bit more complicated. Heres an article to that if you want to stick on that method: How To Get All the data saved inside a datastore

But coming back to your problem, try it like that with using the Player Names as key:

CLIENT:
script.Parent.UNBAN.MouseButton1Click:Connect(function()
    print("Clicked") --To detect if the Button is working
    task.wait(1) --To make sure Client is loaded when the Event fires, sth thats a problem
	game.ReplicatedStorage.UnBan:FireServer(script.Parent.NameTextBox.Text)
end)

--SERVER:
game.ReplicatedStorage.UnBan.OnServerEvent:Connect(function(player, PlayerNameTextBox, ReasonTextBox)
	local DataStoreService = game:GetService("DataStoreService")
	local TempBanPlayerDataStore = DataStoreService:GetDataStore("TemporaryBanPlayerData")
	local PermBanPlayerDataStore = DataStoreService:GetDataStore("PermanentBanPlayerData")

	TempBanPlayerDataStore:RemoveAsync(PlayerNameTextBox)	
end)

Maybe that will do it.

#33

So, it’s showing the “Clicked” for the print.

The server script isnt doing anything though. I’ve tried adding prints, yet nothing.

#34

So you did make a print also above local DataStoreService = game:GetService(“DataStoreService”) and nothing came out? Super weird, I will go search a bit about this and write later more.

#35

Ok so I have 2 more ideas.

  1. Please add a task.wait(1) above the :Connect() Event in the Server to make sure that the RemoteEvent has loaded when this line is getting read or make the RemoteEvent a variable and use :WaitForChild()
--SERVER:
print("Script is working")
local event = game:GetService("ReplicatedStorage"):WaitForChild("UnBan")
print("Got RemoteEvent")

event.OnServerEvent:Connect(function(player, PlayerNameTextBox, ReasonTextBox)
    print("Fired!!!")
	local DataStoreService = game:GetService("DataStoreService")
	local TempBanPlayerDataStore = DataStoreService:GetDataStore("TemporaryBanPlayerData")
	local PermBanPlayerDataStore = DataStoreService:GetDataStore("PermanentBanPlayerData")

	TempBanPlayerDataStore:RemoveAsync(PlayerNameTextBox)
    print("Removed Async")
end)
1 Like
#36

Thank you so very much! It worked!

#37

Your welcome! For more explanation, your problem was that the Event got fired before the Server loaded the RemoteEvent so he also couldnt fetch it.
Have a good day!

#38

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.