[v2.1.0] MatchmakingService - ON HOLD

Resources Community Resources
#180

Testing out the update and it wouldn’t matchmake. I then un-queued and got this error.
image
(I download each new version when I want to so that it won’t auto-update)

Update: I found another error with it.

ServerStorage.Modules.MMService:408: attempt to perform arithmetic (add) on nil and number
ServerStorage.Modules.MMService, line 408
#181

I’ll look into it asap. The update shouldn’t have caused this though, odd. Maybe an oversight. Thanks for the report

#182

Line 408 is an end (however prob just an extra few lines), are you sure you’re up to date? As for the other error does it happen all the time?

#183

This was on version 1.2.1

408: if mainJobId == nil or mainJobId[2] + 30000 <= now then

I’m not sure if this was fixed in the newest version or not.

#184

Ah, I see I made an oversight with the most recent update. I’ll push a fix for it immediately.

#185

Also, I found another bug in the latest version (1.3.0).

ServerStorage.Modules.MMService:239: attempt to index nil with 'DisableGlobalEvents'
ServerStorage.Modules.MMService, line 239

I did not pass in anything for GetSingleton(), so I think it expected a table.

#186

That’s what I’m fixing right now. I was unable to reproduce the other bug at line 544 can you give me more details about it?

#187

Version 1.3.1

Changes (breaking):

  • None

Changes (non-breaking):

  • None

Fixes:

  • [Fix] Fixed a bug that would prevent global events from working if you passed nothing into GetSingleton.

  • [Fix] Fixed a bug that would happen if the main job was set to an empty table.

  • [Fix] Fixed a bug that would happen if the last players in queue were removed from queue while MMS is finding a game.

  • [Fix] Fixed GetRunningGames with max > 200.

#188

I’m actually unable to reproduce it again. I just now tested passing in a table and no errors occurred.
It seemed to happen right after I removed players from the queue, but I have no other info.

#189

It may be possible that they were removed from queue in the time the service was about to put them in a game. I’ll add a preventative check so it doesn’t happen in the future. I’ll just rebase it into 1.3.1. Thanks for the reports.

EDIT: Oh I see what happened, the queue was obtained but there was no one in it so it tried to index nil.

The fix has been rebased into 1.3.1

1 Like
#190

Seems to be completely functional now. Thank you for your quick responses!
I will be pushing this new update to my live build now.

1 Like
#191

I dont know if i missed anything while reading the documentation, but is there a way to make a server list of queue-able servers? Kind of like this

image

#192

You can use GetRunningGames()

https://steven4547466.github.io/MatchmakingService/maindocs/#getting-running-games

This accepts a filter function, if you want to get every joinable running game:

local games = MatchmakingService:GetRunningGames(math.huge, function(data) return data.joinable end)

This will return an array that looks like this:

{
    {
        key=gameCode;
        value=gameData;
    },
    {
        key=gameCode;
        value=gameData;
    },
    ...
}

Passing math.huge for max should return every game that passes the filter. For more info please see the linked docs.

EDIT: I’m going to edit this 3 hours later to avoid future questions from other people.

You can add players to running games using:
MatchmakingService:AddPlayerToGame(player, gameId, updateJoinable) (https://steven4547466.github.io/MatchmakingService/maindocs/#adding-a-player-to-an-existing-game)

gameId is the key part in the dictionary.

2 Likes
#193

Here to report another error lol (Version 1.3.1).

ServerStorage.Modules.MMService:1151: invalid argument #1 to 'pairs' (table expected, got nil)
ServerStorage.Modules.MMService, line 1151 - function RemovePlayerFromQueueId
ServerStorage.Modules.MMService, line 225

Update: This error is getting annoying because it seems to happen any time someone leaves. I don’t even run the function RemovePlayerFromQueueId, so I don’t even know why this is happening.

Update 2: Now there is another error that occurs when i’m trying to RemovePlayersFromQueue.

Argument 3 missing or nil
ServerStorage.Modules.MMService, line 1319 - function RemovePlayersFromQueueId
ServerStorage.Modules.MMService, line 1445 - function RemovePlayersFromQueue
ServerStorage.KnitServices.LoadService, line 820 - function Cancel
#194

Will look into this, I have a quick fix but it won’t solve the full problem.

#195

Version 1.3.2

Changes (breaking):

  • None

Changes (non-breaking):

  • None

Fixes:

  • [Fix] Delimiter for memory is now two underscores. This allows maps to have names with a single underscore.

  • [Fix] Added a quick fix for an issue where queue would not be removed if no one was in it, which caused an error.

#196

Sorry to bother you so much, but while this did fix my previous issues now there’s a new error.

Argument 3 missing or nil
ServerStorage.Modules.MMService, line 546
1 Like
#197

You’re fine, and yeah I did miss something. I’ve merged a fix into 1.3.2. Let me know if you encounter anything else.

2 Likes
#198

Do you need to call update ratingS?

#199

No, you do not need to call update ratings. If you never call updating ratings, it basically keeps everyone at 0 rating which is the same as having no ratings at all.

1 Like