Vault code review

Help and Feedback Code Review
#21

If I run it on the client, how will the whole server see the change? Using REs is technically loading it on the server anyway.

#22

You can create the tween on the server, but I typically play the tween on the client, because in my experience, visual effects are kinda choppy on the server (which makes sense, latency is a thing).

You can do a thing where you like…

:FireAllClients(Tween)

if you’d like.

The choppiness on the tween is in most cases negligible though, so its really not that important.

1 Like
#23

I feel like lerping is unnecessarily hard to learn and read. Tweenservice its easy on the eyes and can be tweened in different ways. Don’t get me wrong, lerping is amazing. But in this scenario, I think tweenservice is the right way to go.

2 Likes
#24

I think your probably right, ive always used lerp instead of tween so im too used to lerping being the norm

2 Likes
#25

Aaaahhh!!!
Please stop doing things like this. Just call it TweenService.

@minimic2002 @GamingExpert0312 This is a horrible idea. Please use TweenService, it exists for a reason. TweenService adapts to framerate and adjusts accordingly, whereas your script does not.

#26

See TweenService:GetValue.

#27

you can try using animations instead of tween service, I think they are about more or less the same as performance wise, also I think it’s much easier than tween service
just stick in an animator controller into the model, also an animator inside of the animator controller and rig the whole thing up using the rig editor plugin

—example code
local model = script.Parent
local controller = model.AnimatorController
local animator = controller.Animator

local animations = model.animations —folder to store animations

local open_animation = animations.OpenAnimation
local openAnim = animator:LoadAnimation(open_animation)

local function open()
openAnim:Play()
end
1 Like
#28

Oh woah I didn’t think that was possible.

#29

It’s completely up to his preference, maybe it’s easier for him because it shorter.

It’s not bad practice

1 Like