Ways to Simplify or Improve code

[DasKairo (Cairo)]

Already has been said.

And I already know what it is, I dont need to know.

[Judgy_Oreo (phoenixwhitefire2000)]

Yes, but it is still in the main post? You could edit the post with the code example and explanation I gave, because most people will not scroll through 40 replies to gather information that should be on the OP.

[DasKairo (Cairo)]

I gave a Topic I made back in November that has both Graphemes ans sub, I only showed one of them as an example, not both, but sure. I’ll have to do it later.

(Cannot spell)

[iGottic]

@DasKairo

error() if false

I should let ya know that this is actually pretty bad advice. Errors should be reserved only for irreversible states. Instead, you can return a boolean success state before or after the rest of your return tuple.

For example, let’s say that you have an inventory system that requires some sort of table. If it doesn’t exist, should you error? No, you replace the parameter with a placeholder value. Or, you can return an unsuccessful boolean state

@DasKairo

Setting Minimum and Maximum Values

You’re also wrong on this, since you’re actually making it too complex. Just do math.clamp(value, min, max)

@DasKairo

-- finally, an actual use for an if statement
if Sec == 0 and Min == 0 then return end

if Sec > 59 then -- if Seconds is greater
    Min += 1
elseif Sec < 0  then -- if Seconds is less than 0
    Min -= 1
end

Sec %= 60 -- resets number to 0 or 59
-- you can add this for Minutes as well, Up to you tho :)

Timerformat = string.format("%d:%02i", Min, Sec) -- formats numbers

Or alternatively:

local Hours = Seconds % ((60 ^ 2) * 24) -- If needed
local Minutes = Seconds % (60 ^ 2) -- 60 seconds per minute, 60 minutes per hour
local Seconds = Seconds % 60 -- 60 seconds per minutes

@DasKairo

Typewriting Effects

Or, you can change the text label’s property, MaxVisibleGraphemes, which simplifies it, and can be tweened.

[DasKairo (Cairo)]

Basically.
Already.
Said.
By.
People.

I keep getting Replies over the same exact things that were said prior.

@iGottic

I should let ya know that this is actually pretty bad advice. Errors should be reserved only for irreversible states.

Sort of, Depends on the Context tho you said one of them so.

[iGottic]

@DasKairo

Basically.
Already.
Said.
By.
People.

I keep getting Replies over the same exact things that were said prior.

Well, shouldn’t you fix the post then?

@DasKairo

Sort of, Depends on the Context tho you said one of them so.

No.

[DasKairo (Cairo)]

@iGottic

Well, shouldn’t you fix the post then?

I rather have people see the Original to them than just replace it, so People can actually see what’s wrong with it, and fix it, according to replies, also, it would make the replies seem out of context.

@iGottic

No.

Ok.

[iGottic]

@DasKairo

I rather have people see the Original to them than just replace it, so People can actually see what’s wrong with it, and fix it, according to replies, also, it would make the replies seem out of context.

You’ll keep getting these replies then, so don’t complain to me about it.

@DasKairo

Ok.

You should read what I posted in a programming guidelines post I made a while back:

@iGottic

Exceptions should be handled properly

Return a state or success value in return tuples. This creates room for failure cases, which, creates soft-fail solutions, rather than hard errors. Errors should be reserved for when your code has reached a point of no return, such as with unexpected situations, unrecoverable state, etc.

Your code should handle exceptions and errors as standard control flow, but not rely on it.

Do not assume a truthy value is always returned in some methods.

[DasKairo (Cairo)]

@iGottic

You’ll keep getting these replies then, so don’t complain to me about it.

Ok.

@iGottic

You should read what I posted in a programming guidelines post I made a while back:

Ok!