Why does this script run 1 time? (Sometimes 2)

Help and Feedback Scripting Support
#1

This script doesn’t always run when it’s supposed to (When it doesn’t it gives the error “Scirpt timeout: exhausted execution time”)

if RandomPlayer1.Name == RandomPlayer2.Name then
					print("Oops")
					print(PickablePlayers)
					table.remove(PickablePlayers,2,RandomPlayer2)
					local Check = true
					while Check == true do
						wait(0.2)
						RandomPlayer2 = Players[math.random(#PickablePlayers)]
						if RandomPlayer1.Name ~= RandomPlayer2.Name then
							Check = false
						end
					end
				end
3 Likes
#2

I think the error occurs because you must put the “if” before the command, therefore sometimes it works and sometimes it doesnt, but I recommend this:

local Check = true
	repeat
		wait(0.5)
		RandomPlayer2 = Players[math.random(#PickablePlayers)]
	until
	RandomPlayer1.Name ~= RandomPlayer2.Name

	Check = false
1 Like
#3

It doesn’t run at all if I use this.

#4

In the if statement (of your original code) you need to add a break under Check = false else it will keep running, also use task.wait(), instead of wait().

1 Like
#5

What’s the difference between wait() and task.wait()?

#6
#7
2 Likes
#8

This is caused by the loop running infinitely in cases where the loop does not meet the requirements that you set for it to end. In your code you have only give math.random 1 argument when it requires 2 (min,max) which is most likely the cause of it never picking a valid player. Try this (hopefully improved) snippet and tell me if it works.

if RandomPlayer1 == RandomPlayer2 then
	print("Oops")
	print(PickablePlayers)
	table.remove(PickablePlayers,2,RandomPlayer2)
    repeat
        RandomPlayer2 = Players[math.random(1,#PickablePlayers)]
        task.wait(.2)
	until RandomPlayer1 ~= RandomPlayer2
end
#9

you might want to try adding a wait to the 2nd line of code, for example. wait(0.1).

#10

That is incorrect usage of table.remove(). To remove element from an array, first you need to find it. table.remove accepts only 2 arguments, and the third one will be ignored.
To remove RandomPlayer2 from the array use:

table.remove(PickablePlayers,table.find(PickablePlayers,RandomPlayer2))

Now I am not 100% sure what you are trying to achieve with the while loop, but it seems redundant. It looks like theres an error at this line:

RandomPlayer2 = Players[math.random(#PickablePlayers)]

Whatever Player array is, I am pretty sure indexes will not match with the PickablePlayers array, especially after table.remove()
I think it should rather be written this way:

RandomPlayer2 = PickablePlayers[math.random(#PickablePlayers)]

If so, while loop should no longer be necessary.

#11

It does what it’s supposed to do, but for some reason it keeps running for an infinite amount of times.

#12 
RandomPlayer2 = PickablePlayers[math.random(#PickablePlayers)]

This returns nil for some reason.

#13

It appears my code snippet didn’t work as I didn’t spot the error with table.remove, however I told you that the reason that line is incorrect is because math.random requires a minimum and a maximum argument where you have only given it 1. Replacing it with RandomPlayer2=PickablePlayers[math.random(1,#PickablePlayers)]
Should work

#14

Code I currently use;

if RandomPlayer1 == RandomPlayer2 then
					print("Oops")
					print(PickablePlayers)
					RandomPlayer2 = PickablePlayers[math.random(1,#PickablePlayers)]
					repeat
						RandomPlayer2 = Players[math.random(1,#PickablePlayers)]
						task.wait(.2)
						print(RandomPlayer1,RandomPlayer2)
					until RandomPlayer1 ~= RandomPlayer2
				end

For some reason RandomPlayer1 and RandomPlayer2 become the same player.

#15

Not sure about the problem with it, can you post possibly a larger snippet of your code? also try testing this with 3-4 players rather then 2 if you haven’t already.

#16 
		elseif ChosenEvent == "Event9" then
			local Players = game.Players:GetPlayers()
			local CountValue = Instance.new("IntValue",game.Workspace)
			local Number = 0
			for i, Count in pairs(Players) do
				local Number = Number + 1
				CountValue.Value = Number
			end
			wait(0.2)
			if CountValue.Value >= 1 or CountValue.Value == 2 then
				print("2playersingame")
				local PickablePlayers = {game.Players:GetPlayers()}
				local Players = game.Players:GetChildren()
				local RandomPlayer1 = Players[math.random(#Players)]
				local RandomPlayer2 = Players[math.random(#Players)]
				if RandomPlayer1 == RandomPlayer2 then
					print("Oops")
					print(PickablePlayers)
					RandomPlayer2 = PickablePlayers[math.random(1,#PickablePlayers)]
					repeat
						RandomPlayer2 = PickablePlayers[math.random(1,#PickablePlayers)]
						task.wait(.2)
						print(RandomPlayer1,RandomPlayer2)
					until RandomPlayer1 ~= RandomPlayer2
				end
				local P1Char = RandomPlayer1.Character:GetChildren()
				local P2Char = RandomPlayer2.Character:GetChildren()
				print(RandomPlayer1.Name)
				print(RandomPlayer2.Name)
				if P1Char and P2Char then
					for i, Part in pairs(P1Char) do
						if Part:IsA("BasePart") then
							Part.Transparency = 1
						end
						if Part:IsA("Accessory") then
							Part:Destroy()
						end
					end
					for i, Part in pairs(P2Char) do
						if Part:IsA("BasePart") then
							Part.Transparency = 1
						end
						if Part:IsA("Accessory") then
							Part:Destroy()
						end
					end
					wait(3)
					for _, Part in pairs(P1Char) do
						if Part:IsA("BasePart") then
							Part.Transparency = 0
						end
						if Part.Name == "HumanoidRootPart" then
							Part.Transparency = 1
						end
					end
					for _, Part in pairs(P2Char) do
						if Part:IsA("BasePart") then
							Part.Transparency = 0
						end
						if Part.Name == "HumanoidRootPart" then
							Part.Transparency = 1
						end
					end
				end
			else
				print("Only 1 player in game")
				local RandomPlayer1 = Players[math.random(#Players)]
				local Char = RandomPlayer1.Character
				if Char then
					for i, Part in pairs(Char:GetChildren()) do
						if Part:IsA("BasePart") then
							Part.Transparency = 1
						end
						if Part:IsA("Accessory") then
							Part:Destroy()
						end
					end
					wait(5)
					for i, Part in pairs(Char:GetChildren()) do
						if Part:IsA("BasePart") then
							Part.Transparency = 0	
						end
						if Part.Name == "HumanoidRootPart" then
							Part.Transparency = 1
						end
					end
					CountValue:Destroy()

(Testing with more players doesn’t make a difference)

#17

I’ll read it line by line and spot errors.
if CountValue.Value >= 1 or CountValue.Value == 2 then, this line can return true if there is 1 OR more players. Replace it with If CountValue.Value > 1 then

local RandomPlayer1 = Players[math.random(#Players)] math.random requires 2 arguments, a minimum and maximum value. Replace with local RandomPlayer1 = Players[math.random(1,#Players)]

local RandomPlayer2 = Players[math.random(#Players)] same issue

print("Only 1 player in game")
local RandomPlayer1 = Players[math.random(#Players)]

same issue

Also consider replacing all of your instances of wait() with the new improved task.wait()

#18

Nothing changed, but I noticed that both players get put under the same value in the table is that supposed to happen?

#19

Referring to which table exactly?

#20

The PickablePlayers table (Character limit)