Admin command issue

[FractalVortex]

I’m creating an admin command that logs every chat message sent. The issue is that every time a player types something in chat, the TextChatService.OnIncomingMessage = function(message: TextChatMessage) runs two times, instead of once. So I end up with two slots displaying the same message, instead of just one. Why is this running twice per chat message?

LocalScript:

local replicatedStorage = game:GetService("ReplicatedStorage")
local slot = replicatedStorage:WaitForChild("ChatSlot")
local players = game:GetService("Players")


local TextChatService = game:GetService("TextChatService")




local function onPlayerAdded(player)
	TextChatService.OnIncomingMessage = function(message: TextChatMessage)
		local properties = Instance.new("TextChatMessageProperties")
		if message.TextSource then
			local newSlot = slot:Clone()
			newSlot.Parent = script.Parent
			newSlot.Name = "Slot"
			newSlot.Log.Text = tostring(message.Text)
		end
	end
end

players.PlayerAdded:Connect(onPlayerAdded)

playerList = players:GetChildren()

for i=1, #playerList do
	onPlayerAdded(playerList[i])
end

[remcodesremcodes (Yix)]

why dont you use player.Chatted in a server script over this?

anyway i found the problem: the for loop
in conjunction with players.PlayerAdded, the onPlayerAdded function will run twice

[FractalVortex]

I believe player.Chatted is deprecated. It is replaced with TextChatService

[remcodesremcodes (Yix)]

try this then

local replicatedStorage = game:GetService("ReplicatedStorage")
local slot = replicatedStorage:WaitForChild("ChatSlot")
local players = game:GetService("Players")

local firstPlayers = players:GetPlayers()

local TextChatService = game:GetService("TextChatService")

function onPlayerAdded(player)
	TextChatService.OnIncomingMessage = function(message: TextChatMessage)
		if message.TextSource and message.TextSource == player then
			local newSlot = slot:Clone()
			newSlot.Parent = script.Parent
			newSlot.Name = "Slot"
			newSlot.Log.Text = tostring(message.Text)
		end
	end
end

players.PlayerAdded:Connect(function(player)
   if not table.find(firstPlayers, player) then onPlayerAdded(player)
end)

for _, v in firstPlayers do
   onPlayerAdded(v)
end

firstPlayers = nil

[FractalVortex]

It still runs twice.

(filler text for character limit)

[TheeDeathCaster]

Where was it stated to be deprecated? I went onto the DevHub and it does not state that it’s deprecated. Player (Chatted) | Documentation - Roblox Creator Hub

@Player.Chatted not firing on client when the chat version is set to TextChatService

Reproduction Steps Create a LocalScript in StarterCharacterScripts and make it print anything using the Player.Chatted event. Change the TextChatService ChatVersion from LegacyChatService to TextChatService. Test either in game or in studio, the message the player sent will never print. Expected Behaviour Like it already happens with the LegacyChatService, the messages sent by the player should trigger the Player.Chatted event. Actual Behaviour Player.Chatted will never print when using th…

@FractalVortex

Ig it’s not deprecated but is no longer supported by Roblox. Scripts using .Chatted do not work (I’m pretty sure)

If that’s true, they need to update the documentation to reflect this change. I doubt it though considering I created something using Player.Chatted years ago and it still worked about a week or two ago.

[FractalVortex]

Player.Chatted not firing on client when the chat version is set to TextChatService

Reproduction Steps Create a LocalScript in StarterCharacterScripts and make it print anything using the Player.Chatted event. Change the TextChatService ChatVersion from LegacyChatService to TextChatService. Test either in game or in studio, the message the player sent will never print. Expected Behaviour Like it already happens with the LegacyChatService, the messages sent by the player should trigger the Player.Chatted event. Actual Behaviour Player.Chatted will never print when using th…

[FractalVortex]

Ig it’s not deprecated but is no longer supported by Roblox. Scripts using .Chatted do not work (I’m pretty sure)

[TheeDeathCaster]

Anyways, to the issue at hand- you could create a temporary cooldown until it accepts a new message. For example-

local cooldowns = {}

local function onPlayerAdded(player)
	TextChatService.OnIncomingMessage = function(message: TextChatMessage)
		if cooldowns[player.Name] == true then
			return
		end
		cooldowns[player.Name] = true
		delay(1/30, function()
			cooldowns[player.Name] = nil
		end)
		local properties = Instance.new("TextChatMessageProperties")
		if message.TextSource then
			local newSlot = slot:Clone()
			...

[FractalVortex]

Nevermind guys, I found the solution. I changed the function to this: TextChatService.MessageReceived:Connect(function(TextChatMessage) and it works fine now. Thanks for the help