Aiming system for FPS/TPS weapons

[PixelRankYT (Noxius)]

I have made a weapon system that is made with the roblox tool, but instead of using the default roblox tool way of handling gripping I used Headstackks solution so I could animate it as well:

How to animate Tool Parts (Guns, Knifes etc.)

Hello everybody! I’m Headstackk, I’ve been creating and making firearm weapons on Roblox for a while. I’ve also created the game Weaponry. In this post, I will briefly explain how to get started to animate a weapon on Roblox. I have already briefly explain how on this DevForum post, but I’d like to make a new post to clarify everything and explain it step by step. In most of the Roblox Shooter games (Excluding advanced shooter games such as Phantom Forces), I observed that they usually make a …

But now that I am finished with the basic functionality such as shooting and reloading I now need to make an aiming feature but I came to a problem on how I should do it, I can easily make it so I zoom in the camera and stuff, but I come to a problem with how should I make the gun readjust itself based on if you’re zoomed in or not, I came up with 2 solutions either readjust the C0 so it would look through the scope/iron sights accurate in the center of the screen (but I came to a road block cause once in first person the gun seemed to go up infinitely which might of been cause of the way I made my viewmodel) then I decided to instead use custom animations but that seemed like a lot of work.

Now I am unsure of what I should do for aiming, thanks in advance for any help you may give.

Viewmodel code:

--|| SERVICES ||--
local RunService = game:GetService("RunService")
local RepStorage = game:GetService("ReplicatedStorage")
local Players = game:GetService("Players")
--|| VARIBLES ||--
local Player = Players.LocalPlayer
local Character = Player.Character or Player.CharacterAdded:Wait()
local Camera = workspace.CurrentCamera
local ViewModel = RepStorage.ViewModel:Clone()
local ViewModelRoot = ViewModel.PrimaryPart

local BobbleValue = Vector3.new(0,0,0)
local RotationValue = Vector3.new(0,0,0)
--|| FUNCTIONS ||--
function UpdateViewModel()
	local HeadCFrame = Character.HumanoidRootPart.CFrame * CFrame.new(0,1.5,0)
	if (Camera.CFrame.Position - HeadCFrame.Position).Magnitude < 1 and Character:FindFirstChildOfClass("Tool") ~= nil then
		ViewModel.Parent = Camera
		ViewModel.Torso["Left Shoulder"].Transform = Character.Torso["Left Shoulder"].Transform
		ViewModel.Torso["Right Shoulder"].Transform = Character.Torso["Right Shoulder"].Transform
		ViewModelRoot.CFrame = Camera.CFrame * CFrame.new(0, -1.5, -0.5) * CFrame.new(BobbleValue.X,BobbleValue.Y,BobbleValue.Z) * CFrame.Angles(math.rad(RotationValue.X),math.rad(RotationValue.Y),math.rad(RotationValue.Z))
		Character.Torso.ToolGrip.Part0 = ViewModel.Torso
	else
		ViewModel.Parent = nil
		Character.Torso.ToolGrip.Part0 = Character.Torso
	end
end
function UpdateVisualEffect(dt)
	local Bobble = Vector3.new(0, 0, 0)
	local Rotation = Vector3.new(0, 0, 0)
	if Character.Humanoid.MoveDirection.Magnitude > 0 then
		local BobbleX = math.cos(tick() * math.pi * 2) * .2
		local BobbleY = math.abs(math.sin(tick() * math.pi * 2)) * .2
		
		local RootSpaceDirection = Character.HumanoidRootPart.Position + Character.Humanoid.MoveDirection
		RootSpaceDirection = Character.HumanoidRootPart.CFrame:ToObjectSpace(CFrame.new(RootSpaceDirection.X,RootSpaceDirection.Y,RootSpaceDirection.Z))
		
		local RotateZ = -RootSpaceDirection.Position.X*15
		
		Bobble = Vector3.new(BobbleX-RootSpaceDirection.Position.X/2, -BobbleY, -RootSpaceDirection.Position.Z/2)
		Rotation = Vector3.new(0,0,RotateZ)
	end
	BobbleValue = BobbleValue:Lerp(Bobble,dt*10)
	RotationValue = RotationValue:Lerp(Rotation,dt*10)
end
function RenderStepped(dt)
	UpdateVisualEffect(dt)
	UpdateViewModel()
end
--|| CONNECTIONS ||--
RunService.RenderStepped:Connect(RenderStepped)

Aiming Code:

function OnAiming(dt)
	local HeadCFrame = Character:WaitForChild("HumanoidRootPart").CFrame * CFrame.new(0,1.5,0)
	local AimingCFrame = Tool:WaitForChild("AimPart").CFrame:ToObjectSpace(HeadCFrame)
	
	AimingCFrame = Character.Torso:WaitForChild("ToolGrip").C0 * CFrame.new(AimingCFrame.Position.X,AimingCFrame.Position.Y,0)
	
	if not ActuallyEquipped or Reloading then
		Aiming = false
	end
	if Aiming then
		AimLerp = math.clamp(AimLerp + (dt*(1/Settings.ZoomSpeed)),0,1)
	else
		AimLerp = math.clamp(AimLerp - (dt*(1/Settings.ZoomSpeed)),0,1)
	end
	Camera.FieldOfView = DefaultFOV/(1+((Settings.ZoomInAmount-1)*AimLerp))
	Character.Torso:WaitForChild("ToolGrip").C0 = CFrame.new(0,0.5,0):Lerp(AimingCFrame,AimLerp)
end