Any Improvement Suggestions for my Custom Character & Object replicator?

Help and Feedback Code Review
,
#1
  • The Code replicates given client characters chosen limbs in a table, and replicates owned ball objects
  • The issue ive faced is high spikes in recv, small spikes in memory, but other then that no FPS drops
  • My other issue is just small stutters from time to time, and the ball appearing to go through a character as if it has no collisions [only seen on other player screens, not the person with the ball]

Other then that, its pretty neat and really good in my opinion. it also makes it as if a person with high ping has no whatsoever unrealistic touches, only if you make statements that check distances / ping

– This is my Send local script in starter player, it sends the client information

--// Services
local Players = game:GetService('Players')
local RunService = game:GetService('RunService')
local ReplicatedStorage = game:GetService('ReplicatedStorage')

--// Client
local LocalPlayer = Players.LocalPlayer

local PlayerGui = LocalPlayer:FindFirstChildOfClass('PlayerGui')
local PlayerScripts = LocalPlayer:FindFirstChildOfClass('PlayerScripts')

--// Variables
local CharactersFolder = workspace:WaitForChild('Characters', math.huge)
local BallsFolder = workspace:WaitForChild('Ball Folder', math.huge)
local NeededLimbs = {
	'HumanoidRootPart';
	'Shield';
	'Head';
	'Torso';
}

local Remote = ReplicatedStorage:FindFirstChild('Replicator')

--// Start
local UpdatedLimbsCFrames = {}
local UpdatedBallCFrames = {}

RunService.Heartbeat:Connect(function(DeltaTime)
	if (LocalPlayer.Character ~= nil) then
		local Character = LocalPlayer.Character
		local LatestRenderedLimbNames = {}
		
		for i, LimbName in NeededLimbs do
			if (Character:FindFirstChild(LimbName)) == nil then
				UpdatedLimbsCFrames[LimbName] = nil
				continue
			end
			
			local Limb = Character:FindFirstChild(LimbName)
			table.insert(LatestRenderedLimbNames, LimbName)
			UpdatedLimbsCFrames[LimbName] = Limb.CFrame
		end
		
		for OldLimbNames, v in UpdatedLimbsCFrames do
			if not (table.find(LatestRenderedLimbNames, OldLimbNames)) then
				UpdatedLimbsCFrames[OldLimbNames] = nil
				continue
			end
		end
	end
	
	if (#BallsFolder:GetChildren()) > 0 then
		for i, Ball in BallsFolder:GetChildren() do
			if (Ball:IsA('Part') and Ball.Name == 'MACH') then
				local Anchored = Ball:GetAttribute('Anchored')
				local ObjectID = Ball:GetAttribute('ID')
				if (ObjectID == nil) then
					if (Anchored == nil or Anchored == false) then
						Ball.Anchored = false
					end
					UpdatedBallCFrames[tostring(ObjectID)] = nil
					continue
				end

				if (Anchored == nil or Anchored == true) then
					UpdatedBallCFrames[tostring(ObjectID)] = nil
					continue
				end
				
				if (Ball:FindFirstChild('Values') == nil or Ball.Values:FindFirstChild('Owner') == nil or Ball.Values:FindFirstChild('Owner').Value == nil) then
					UpdatedBallCFrames[tostring(ObjectID)] = nil
					Ball.Anchored = false
					continue
				end

				local Values = Ball:FindFirstChild('Values')
				local Owner = Values:FindFirstChild('Owner')
				
				if (Owner.Value ~= LocalPlayer) then
					UpdatedBallCFrames[tostring(ObjectID)] = nil
					Ball.Anchored = true
					continue
				end
				
				if (Players:FindFirstChild(Owner.Value.Name)) == nil then
					UpdatedBallCFrames[tostring(ObjectID)] = nil
					Ball.Anchored = true
					continue
				end
				
				Ball.Anchored = false
				UpdatedBallCFrames[tostring(ObjectID)] = Ball.CFrame
				continue
			end
		end
	else
		table.clear(UpdatedBallCFrames)
	end
	
	Remote:FireServer(UpdatedLimbsCFrames, UpdatedBallCFrames, DeltaTime * 15)
	return
end)

– This is my recieve local script, in starterplayer scripts

--// Services
local Players = game:GetService('Players')
local RunService = game:GetService('RunService')
local ReplicatedStorage = game:GetService('ReplicatedStorage')

--// Client
local LocalPlayer = Players.LocalPlayer

local PlayerGui = LocalPlayer:FindFirstChildOfClass('PlayerGui')
local PlayerScripts = LocalPlayer:FindFirstChildOfClass('PlayerScripts')

--// Variables
local CharactersFolder = workspace:WaitForChild('Characters', math.huge)
local BallsFolder = workspace:WaitForChild('Ball Folder', math.huge)
local NeededLimbs = {
	'HumanoidRootPart';
	'Shield';
	'Head';
	'Torso';
}

local Remote = ReplicatedStorage:FindFirstChild('Replicator')

--// Start
local UpdatedLimbsCFrames = {}
local UpdatedBallCFrames = {}

RunService.Heartbeat:Connect(function()
	for Name, Table in UpdatedLimbsCFrames do
		if (CharactersFolder:FindFirstChild(Name) == nil) then
			UpdatedLimbsCFrames[Name] = nil
			continue
		end
		
		if (Table) == nil then
			UpdatedLimbsCFrames[Name] = nil
			continue
		end

		local Character = CharactersFolder:FindFirstChild(Name)
		local HRP = Character:FindFirstChild('HumanoidRootPart')
		local CFrames, Delta = table.unpack(Table)
		
		if (CFrame and Delta) == nil or (HRP == nil) then
			UpdatedLimbsCFrames[Name] = nil
			continue
		end
		
		HRP.Anchored = true
		
		for LimbName, LimbCFrame in CFrames do
			if (Character:FindFirstChild(LimbName)) == nil then
				continue
			end
			
			if (LimbCFrame) == nil then
				continue
			end
			
			local Limb :Part= Character:FindFirstChild(LimbName)
			Limb.CFrame = Limb.CFrame:Lerp(LimbCFrame, Delta or 0)
		end
	end
	
	for Name, Table in UpdatedBallCFrames do
		if (Table) == nil then
			UpdatedBallCFrames[Name] = nil
			continue
		end
		
		local CFrames, Delta = table.unpack(Table)
		if (CFrames and Delta) == nil then
			UpdatedBallCFrames[Name] = nil
			continue
		end
		
		for i, Ball in BallsFolder:GetChildren() do
			if (Ball:IsA('Part') and Ball.Name == 'MACH') then
				local ObjectID = Ball:GetAttribute('ID')
				if (ObjectID == nil) then
					UpdatedBallCFrames[Name] = nil
					continue
				end
			
				if (CFrames[tostring(ObjectID)]) ~= nil then
					local BallCFrame = CFrames[tostring(ObjectID)]
					Ball.CFrame = Ball.CFrame:Lerp(BallCFrame, Delta or 0)
				end
				continue
			end
		end
	end
end)

Remote.OnClientEvent:Connect(function(Player, UpdatedLimbs, UpdatedBalls, Delta)
	if (Player == LocalPlayer) then
		return false
	end
	
	if (UpdatedLimbsCFrames and UpdatedBalls) == nil then
		if (UpdatedLimbsCFrames[Player.Name] ~= nil) then
			UpdatedLimbsCFrames[Player.Name] = nil
		end
		
		if (UpdatedBallCFrames[Player.Name] ~= nil) then
			UpdatedBallCFrames[Player.Name] = nil
		end
		return false
	end
	
	if (Delta == nil or Delta < 0) then
		Delta = 0
	elseif (Delta > 1) then
		Delta = 1
	end
	
	UpdatedLimbsCFrames[Player.Name] = {
		UpdatedLimbs;
		Delta;
	}

	UpdatedBallCFrames[Player.Name] = {
		UpdatedBalls;
		Delta;
	}
	return
end)

– This is the server script

--// Services
local Players = game:GetService('Players')
local ReplicatedStorage = game:GetService('ReplicatedStorage');

--// Output
ReplicatedStorage:FindFirstChild('Replicator').OnServerEvent:Connect(function(...) 
	return ReplicatedStorage:FindFirstChild('Replicator'):FireAllClients(...)
end)
1 Like