I want to weld the armor to the character correctly, and it is not offsetting to how the model was offset.
https://gyazo.com/02781249160b647148131c9e5d703df2
I’ve tried reversing the order of the C0 and adding a C1 but it never seemed to work correctly.
Hello, roke
so that is a problem with welds you may have to change Position and Rotation of the armor weld
this may not help alot but its still helpful
what? I’m not positioning anything I’m looping to weld each part to its respective body part
The problem is that your code welds the “armor” to the character based on where they are in relation to eachother at the time of welding. You might be better off welding each armor piece to the correlated body part with C0 and C1 set to CFrame.new(0,0,0).
What would I for the C0? The body part CFrame?
C0 and C1 are properties of a weld.
Both C0 and C1 combine to determine the spacial relation between the Part0 and Part1. If you set both C0 and C1 to be blank CFrames, then Part0 and Part1 will be welded directly to the center of eachother.
So should C0 be the armor piece’s CFrame?
No. If you weld each part to the correct part of the body, all you need to do is set C0 and C1 to blank CFrames. CFrame.new(0,0,0)
I don’t think that did anything at all.
The parts are already welded to the center of eachother, which isn’t what I want. In the model, the Part1 has an offset from the center of the part that I would like to preserve in the weld.
Unless I have to set in to the inverse of something?
Hello, roke!
Did you try to place it into the person itself or readd it. There maybe a bug or it was placed in the wrong part/model so try to check that let me know if that works or not.
What? I’m scripting the weld, not doing it manually.
If you have a model that the armor is aligned to, you can generate the offset by setting the C0 or the C1 to the relative CFrame of the armor template to the model that it is aligned to.
Your original CFrame code seems to do this, but I am not sure if it uses a properly aligned template.
I might be able to write you up some working code if you can share more of your original code. Please format code by using ``` before and after the code.
local currentArmor = char:FindFirstChild("Armor"):GetChildren()
if #currentArmor > 0 then
-- // need to unequip
for i = 1, #currentArmor do
local selectedPart = currentArmor[i]
selectedPart:Destroy()
equippedArmors[player] = nil
end
end
local newArmor = Armors:FindFirstChild(armor):Clone()
local children = newArmor:GetChildren()
for i = 1, #children do
local selectedArmorPiece = children[i]
local weld = Instance.new("Weld")
local playerBodyPart = char:FindFirstChild(selectedArmorPiece.Name)
weld.C0 = CFrame.new(0, 0, 0)
weld.C1 = selectedArmorPiece.CFrame
weld.Part0 = playerBodyPart
weld.Part1 = selectedArmorPiece
weld.Parent = selectedArmorPiece
selectedArmorPiece.Parent = char.Armor
end
You will need to make a new folder of characters that the armors are aligned to. If you instead want to, you could align all of the armors to a single character model. If that is the case, just set armorAlignmentModel to that model.
local replicatedStorage = game:GetService('ReplicatedStorage')
local equippedArmors = {}
local Armors = replicatedStorage:WaitForChild('Armors')
local armorAlignmentModels = replicatedStorage:WaitForChild('ArmorsAlignment')
function equipArmor(player, char, armorName)
local currentArmor = char:FindFirstChild("Armor"):GetChildren()
if #currentArmor > 0 then
-- // need to unequip
for i = 1, #currentArmor do
local selectedPart = currentArmor[i]
selectedPart:Destroy()
equippedArmors[player] = nil
end
end
local newArmor = Armors:FindFirstChild(armorName):Clone()
local alignmentModel = armorAlignmentModels:FindFirstChild(armorName)
local children = newArmor:GetChildren()
for i = 1, #children do
local selectedArmorPiece = children[i]
local weld = Instance.new("Weld")
local playerBodyPart = char:FindFirstChild(selectedArmorPiece.Name)
local alignmentBodyPart = alignmentModel:FindFirstChild(selectedArmorPiece.Name)
weld.C0 = alignmentBodyPart.CFrame:ToObjectSpace(selectedArmorPiece.CFrame)
weld.Part0 = playerBodyPart
weld.Part1 = selectedArmorPiece
weld.Parent = selectedArmorPiece
selectedArmorPiece.Parent = char.Armor
end
end
All the armors should be aligned to just the basic R6 character, so I should just be able to use the playerbodypart as the alignment model no?
You need a model that the armor is currently aligned to so that you know the offsets to weld it to the player. I assume that the armor pieces are not already aligned perfectly on the actual player, so instead you have a dummy model that the armors are already aligned to, and weld them to the player with the same alignment they have to the dummy.
@VitalWinter It actually was perfectly aligned to the model: Here’s the file i used.
R6ArmorTest (1).rbxm (18.0 KB)