Auto gun not stopping

Help and Feedback Scripting Support
#1

hello i made an if loop for an auto gun, but when i test it out and clicked, it kept firing the event even though my mouse is not down, heres the script:

local Debris = game:GetService("Debris")

local LaserGun = script.Parent
local Tip = LaserGun:WaitForChild("Tip")
local ray = game.ReplicatedStorage.Toolevents:WaitForChild("Ray")
local Player = game.Players.LocalPlayer
local Character = Player.Character

local GunDamage = 30
equipped = false
shooting = false
local connection

LaserGun.Parent.Equipped:Connect(function(Mouse)
	equipped = true
	connection = Mouse.Button1Down:Connect(function()
		
		shooting = true
		while shooting and equipped do
			local Laser = Ray.new(Tip.CFrame.p, (Mouse.Hit.p - Tip.CFrame.p).unit * 300)
			local HitPart, HitPosition = game.Workspace:FindPartOnRay(Laser, Character, false, true)
			LaserGun.Position += LaserGun.CFrame.RightVector * 0.1;
			wait(0.1)
			LaserGun.Position += LaserGun.CFrame.RightVector * -0.1;
			ray:FireServer(HitPart,HitPosition,Tip)
			wait(0.1)
		end
	end)
	Player.Mouse.Button1Up:Connect(function()
		shooting = false
		connection:Disconnect() 
	end)
end)
LaserGun.Parent.Unequipped:Connect(function(Mouse)
	equipped = false
end)

the gun is not moving meaning the event itside is stuck in a loop of some sort

1 Like
#2 
local LaserGun = script.Parent
 
LaserGun.Equipped:Connect(function(Mouse)
	connection = Mouse.Button1Down:Connect(function()
		    local Laser = Ray.new(Tip.CFrame.p, (Mouse.Hit.p - Tip.CFrame.p).unit * 300)
			local HitPart, HitPosition = game.Workspace:FindPartOnRay(Laser, Character, false, true)
			LaserGun.Position += LaserGun.CFrame.RightVector * 0.1;
			wait(0.1)
			LaserGun.Position += LaserGun.CFrame.RightVector * -0.1;
			ray:FireServer(HitPart,HitPosition,Tip)
			wait(0.1)
	end)
    Mouse.Button1Up:Connect(function()
            connection:Disconnect()
end)

I think you can try this.

#3

i think you missed an end), where are suppose to put it? in the equipped function or outside it?

#4

oh its outside, its firing the function only once and never again

#5

From the code that I wrote it shoots only once?

#6

well i added one end)

local Debris = game:GetService("Debris")

local LaserGun = script.Parent
local Tip = LaserGun:WaitForChild("Tip")
local ray = game.ReplicatedStorage.Toolevents:WaitForChild("Ray")
local Player = game.Players.LocalPlayer
local Character = Player.Character

local GunDamage = 30
equipped = false
shooting = false
local connection

local LaserGun = script.Parent

LaserGun.Parent.Equipped:Connect(function(Mouse)
	connection = Mouse.Button1Down:Connect(function()
		local Laser = Ray.new(Tip.CFrame.p, (Mouse.Hit.p - Tip.CFrame.p).unit * 300)
		local HitPart, HitPosition = game.Workspace:FindPartOnRay(Laser, Character, false, true)
		LaserGun.Position += LaserGun.CFrame.RightVector * 0.1;
		wait(0.1)
		LaserGun.Position += LaserGun.CFrame.RightVector * -0.1;
		ray:FireServer(HitPart,HitPosition,Tip)
		wait(0.1)
		end)
	
	Mouse.Button1Up:Connect(function()
		connection:Disconnect()
	end)
end)
#7

And it shoots only once per click?

#8

no it shot when i click for ONCE and it does nothing after

im pretty sure you need loop for an autorifile but i might be wrong

#9

Maybe try this? This might work without using ‘connection’ and used new task api.


local Debris = game:GetService("Debris")

local LaserGun = script.Parent
local Tip = LaserGun:WaitForChild("Tip")
local ray = game.ReplicatedStorage.Toolevents:WaitForChild("Ray")
local Player = game.Players.LocalPlayer
local Character = Player.Character

local GunDamage = 30
local equipped = false
local shooting = false
local mouseheld = false
local Mouse = nil

Mouse.Button1Down:Connect(function()
	mouseheld = true
	while mouseheld and equipped do
		if not mouseheld or not equipped then shooting = false break end
		shooting = true
		local Laser = Ray.new(Tip.CFrame.p, (Mouse.Hit.p - Tip.CFrame.p).unit * 300)
		local HitPart, HitPosition = game.Workspace:FindPartOnRay(Laser, Character, false, true)
		LaserGun.Position += LaserGun.CFrame.RightVector * 0.1;
		task.wait(0.1)
		LaserGun.Position += LaserGun.CFrame.RightVector * -0.1;
		ray:FireServer(HitPart,HitPosition,Tip)
		task.wait(0.1)
	end
end)

Player.Mouse.Button1Up:Connect(function()
	mouseheld = false
end)


LaserGun.Parent.Equipped:Connect(function(NewMouse)
	Mouse = NewMouse
	equipped = true
end)

LaserGun.Parent.Unequipped:Connect(function()
	Mouse = nil
	equipped = false
end)
#10

If you’re using a while, I think you need to use a break.

#11

@foxnoobkite But, since your gun system is very obsolete and you should try the new fast cast system instead.

#12

hmm nope, dosn’t do anything, i don’t think the things run behind loops

#13

i don’t think you can do a mousebuttonup function inside a loop can you? because i was thinking of like looping and break until it detects the mousebutton1 is up manully every loop

#14

I’m not fully sure, but this may fix your issue

local Debris = game:GetService("Debris")

local LaserGun = script.Parent
local Tip = LaserGun:WaitForChild("Tip")
local ray = game.ReplicatedStorage.Toolevents:WaitForChild("Ray")
local Player = game.Players.LocalPlayer
local Character = Player.Character

local GunDamage = 30

local LaserGun = script.Parent
local Active = false

local Mouse = Player:GetMouse()

LaserGun.Parent.Activated:Connect(function()
	Active = true
	while Active == true do
		local Laser = Ray.new(Tip.CFrame.p, (Mouse.Hit.p - Tip.CFrame.p).unit * 300)
		local HitPart, HitPosition = game.Workspace:FindPartOnRay(Laser, Character, false, true)
		LaserGun.Position += LaserGun.CFrame.RightVector * 0.1;
		wait(0.1)
		LaserGun.Position += LaserGun.CFrame.RightVector * -0.1;
		ray:FireServer(HitPart,HitPosition,Tip)
		wait(0.1)
	end
end)

LaserGun.Parent.Deactivated:Connect(function()
	Active = false
end)
#15

You should take a look in the output maybe it would display some errors.

#16

surprising…no errors at all and nothing is happening

#17

it works but when i spam click the tool and hold it goes super fast without cooldown for some reason

#18

Try this I added a short cooldown what you can change

local LaserGun = script.Parent
local Active = false
local CanShoot = true
local CooldownTime = .1 -- How much time to "recharge" after deactivating

local Mouse = Player:GetMouse()

LaserGun.Parent.Activated:Connect(function()
	if CanShoot == true then
		Active = true
		while Active == true do
			local Laser = Ray.new(Tip.CFrame.p, (Mouse.Hit.p - Tip.CFrame.p).unit * 300)
			local HitPart, HitPosition = game.Workspace:FindPartOnRay(Laser, Character, false, true)
			LaserGun.Position += LaserGun.CFrame.RightVector * 0.1;
			wait(0.1)
			LaserGun.Position += LaserGun.CFrame.RightVector * -0.1;
			ray:FireServer(HitPart,HitPosition,Tip)
			wait(0.1)
		end
	end
end)

LaserGun.Parent.Deactivated:Connect(function()
	Active = false
	CanShoot = false
	wait(CooldownTime)
	CanShoot = true
end)
#19

i think cooldown does nothing with this, i assume its because mutiple loops are running when i spam click

#20

It may be because of how short I made the cooldown, try making it longer and trying again