Can you enable a Touched event only during a tool's activation?

Help and Feedback Scripting Support
, ,
#1

You read the title, I want to make a sword in a way that the sword will only damage another player if it’s swung by the holder, but I’m not sure of how could I enabled a Touched event only during the tool’s activation.
I made a prototype script of how would it work:

local tool = script.Parent
local handle = tool:WaitForChild("Handle")

local canDamage = true

tool.Activated:Connect(function()
	if not canDamage then
		canDamage = false
		handle.Touched:Connect(function(hit)
			local player = game.Players:GetPlayerFromCharacter(hit.Parent)
			if player then
				player.Character.Humanoid:TakeDamage(10)
			end
		end)
		task.wait(1)
		canDamage = true
	end
end)

Would it?

#2

I’m not sure I completely understand, but I can tell you about the :Disconnect() method.

If you make a global value that will serve as the value of the connection, you can connect and disconnect it whenever called.

For example:

local tool = script.Parent
local handle = tool:WaitForChild("Handle")

local canDamage = true

local connection --//This will be the global value for the connection

tool.Activated:Connect(function()
	if not canDamage then
		canDamage = false
		connection = handle.Touched:Connect(function(hit) --//Establish the connection
			local player = game.Players:GetPlayerFromCharacter(hit.Parent)
			if player then
				player.Character.Humanoid:TakeDamage(10)
			end
		end)
		task.wait(1)
		canDamage = true
	end
end)

tool.Deactivated:Connect(function()
	connection:Disconnect() --//When tool unequipped, abolish the connection
end)

Now what is happening, is when the player equips the tool, it will use the connection variable to make the tool’s Handle have a .Touched event. When the player unequips the tool, it will use the :Disconnect() function to cancel any connections made to the connection variable, thus no .Touched events being executed anymore.

#3

This gives the error attempt to index nil with 'Disconnect' on the connection:Disconnect() line when activating the sword, why would that happen?

#4

There’s a chance that the ‘canDamage’ is not allowing the connection to be made before it tries to disconnect.

Maybe first setting the connection will help fix the issue?

local tool = script.Parent
local handle = tool:WaitForChild("Handle")

local canDamage = true

local connection --//This will be the global value for the connection

tool.Activated:Connect(function()
	connection = handle.Touched:Connect(function(hit) --//Establish the connection
		local player = game.Players:GetPlayerFromCharacter(hit.Parent)
		if player and canDamage then
			player.Character.Humanoid:TakeDamage(10)
			canDamage = false
		end
	task.wait(1)
	canDamage = true
	end)
end)

tool.Deactivated:Connect(function()
	connection:Disconnect() --//When tool unequipped, abolish the connection
end)
#5

I tried adding a check to the connection to check if it exists:

tool.Deactivated:Connect(function()
	if touchedConn ~= nil then
		touchedConn:Disconnect()
	end
end)

But the other player does not take any damage

#6

That is because tool.Deactivated fires after the mouse button goes up.

tool.Activated:Connect(function()
	if not canDamage then
		canDamage = false
		local connection = handle.Touched:Connect(function(hit)
			local player = game.Players:GetPlayerFromCharacter(hit.Parent)
			if player then
				player.Character.Humanoid:TakeDamage(10)
			end
		end)
		task.wait(1)
		connection:Disconnect()
		canDamage = true
	end
end)

Try this.

#7

Sorry for the late reply
Doing this makes the damage value really inconsistent, ranging from small damage to a lot between the cooldowns.

#8

Solved this by using Raycast, thanks for the help

#9

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.