Char Clothing Problem

anxlr · October 28, 2021, 9:43pm

Hello Developers, I’m having a problem with my script. When I run the code its only detecting the shirt and not the pants and it’s weird. It’s not telling me why its not doing it for the pants. Please Help.

Code:

local NFolder = Instance.new('Folder', game.ReplicatedStorage)
NFolder.Name = 'CharDataBase'

game.Players.PlayerAdded:Connect(function(Player)
	local PFolder = Instance.new('Folder', NFolder)
	local SD = Instance.new('Shirt', PFolder)
	local PD = Instance.new('Pants', PFolder)
	PFolder.Name = Player.UserId
	SD.Name = 'Shirt'
	PD.Name = 'Pants'
	local FoundCharacter, CharacterModel = pcall(function()
		return game.Players:GetCharacterAppearanceAsync(Player.UserId)
	end)
	if CharacterModel:FindFirstChildOfClass('Shirt') ~= nil then
		if Player.UserId and PFolder.Name then
			SD.ShirtTemplate = CharacterModel.Shirt.ShirtTemplate
			Player.Character.Shirt.ShirtTemplate = SD.ShirtTemplate
		elseif CharacterModel:FindFirstChildOfClass('Pants') ~= nil then
		if Player.UserId == PFolder.Name then
			PD.PantsTemplate = CharacterModel.Pants.PantsTemplate
			Player.Character.Pants.PantsTemplate = PD.PantsTemplate
			end
		end
	end
end)

Syclya · October 28, 2021, 9:49pm

Most likely because it found the shirt then it stops, because elseif will only run if the statement above isn’t true.
Also, you forgot to put an end after Player.Character.Shirt.ShirtTemplate = SD.ShirtTemplate, because now elseif will only run if Player.UserId and PFolder.Name isn’t true.

maycoleee2231 · October 28, 2021, 9:53pm

Maybe

local NFolder = Instance.new("Folder", game.ReplicatedStorage)
NFolder.Name = "CharDataBase"

game.Players.PlayerAdded:Connect(function(Player)
	local PFolder = Instance.new('Folder', NFolder)
	local SD = Instance.new("Shirt", PFolder)
	local PD = Instance.new("Pants", PFolder)
	PFolder.Name = Player.UserId
	SD.Name = "Shirt"
	PD.Name = "Pants"
	local FoundCharacter, CharacterModel = pcall(function()
		return game.Players:GetCharacterAppearanceAsync(Player.UserId)
	end)
	if FoundCharacter then
		if CharacterModel:FindFirstChildOfClass("Shirt") and CharacterModel:FindFirstChildOfClass("Pants") then
			if Player.Character:FindFirstChildOfClass("Shirt") and Player.Character:FindFirstChildOfClass("Pants") then
				if Player.UserId and PFolder.Name then
					SD.ShirtTemplate = CharacterModel.Shirt.ShirtTemplate
					Player.Character.Shirt.ShirtTemplate = SD.ShirtTemplate
				end
				if CharacterModel:FindFirstChildOfClass("Pants") then
					if Player.UserId == PFolder.Name then
						PD.PantsTemplate = CharacterModel.Pants.PantsTemplate
						Player.Character.Pants.PantsTemplate = PD.PantsTemplate
					end
				end
			end
		end
	end
end)

anxlr · October 28, 2021, 9:55pm

Thanks for the suggestion. Sadly it didn’t work

maycoleee2231 · October 28, 2021, 9:55pm

What exactly is the error it’s throwing at you?

anxlr · October 28, 2021, 9:59pm

Its not throwing any errors the problem is its not filling the pants ID with the normal character’s pants so thats why It’s not loading I think

Pelo_208 · October 28, 2021, 11:35pm

maycoleee2231:

			if Player.Character:FindFirstChildOfClass("Shirt") and Player.Character:FindFirstChildOfClass("Pants") then
				if Player.UserId and PFolder.Name then
					SD.ShirtTemplate = CharacterModel.Shirt.ShirtTemplate
					Player.Character.Shirt.ShirtTemplate = SD.ShirtTemplate
				end
				if CharacterModel:FindFirstChildOfClass("Pants") then
					if Player.UserId == PFolder.Name then
						PD.PantsTemplate = CharacterModel.Pants.PantsTemplate
						Player.Character.Pants.PantsTemplate = PD.PantsTemplate
					end
				end
			end

It only looks for the pants if it finds the shirt, add a 2nd end to the shirt if statement:

if Player.Character:FindFirstChildOfClass("Shirt") and Player.Character:FindFirstChildOfClass("Pants") then
	if Player.UserId and PFolder.Name then
	SD.ShirtTemplate = CharacterModel.Shirt.ShirtTemplate
	Player.Character.Shirt.ShirtTemplate = SD.ShirtTemplate
	end
end
if CharacterModel:FindFirstChildOfClass("Pants") then
	if Player.UserId == PFolder.Name then
	PD.PantsTemplate = CharacterModel.Pants.PantsTemplate
		Player.Character.Pants.PantsTemplate = PD.PantsTemplate
	end
end

anxlr · October 28, 2021, 11:41pm

I found out how to fix it. I just had to change one of the statements because I kept it as == and forgot to change it to and

Limited_Unique · October 28, 2021, 11:46pm

local NFolder = Instance.new('Folder', game.ReplicatedStorage)
NFolder.Name = 'CharDataBase'

game.Players.PlayerAdded:Connect(function(Player)
	local PFolder = Instance.new('Folder', NFolder)
	local SD = Instance.new('Shirt', PFolder)
	local PD = Instance.new('Pants', PFolder)
	PFolder.Name = Player.UserId
	SD.Name = 'Shirt'
	PD.Name = 'Pants'
	local FoundCharacter, CharacterModel = pcall(function()
		return game.Players:GetCharacterAppearanceAsync(Player.UserId)
	end)
	if CharacterModel:FindFirstChildOfClass('Shirt') ~= nil and CharacterModel:FindFirstChildOfClass('Pants') ~= nil then
		if Player.UserId and PFolder.Name then
			SD.ShirtTemplate = CharacterModel.Shirt.ShirtTemplate
			Player.Character.Shirt.ShirtTemplate = SD.ShirtTemplate
			PD.PantsTemplate = CharacterModel.Pants.PantsTemplate
			Player.Character.Pants.PantsTemplate = PD.PantsTemplate
		end
	end
end)

Pelo_208 · October 28, 2021, 11:48pm

If player wears no pants that ain’t going to work (No clue why I deleted this one)

Limited_Unique · October 28, 2021, 11:48pm

Then they will be ignored for being half nude.

Pelo_208 · October 28, 2021, 11:49pm

Roblox automatically applies clothing to your avatar if you are missing clothes

Limited_Unique · October 28, 2021, 11:51pm

Only if you’re using the same skin tone.

anxlr · October 28, 2021, 11:52pm

For some reason now my char can’t move

Pelo_208 · October 28, 2021, 11:53pm

Right, but things like noob avatars could simply not want to wear pants, so ignoring the thing if they don’t have both things is straight up unjustified and possibly annoying to players.

Pelo_208 · October 28, 2021, 11:54pm

I don’t think changing a shirt ID can cause a character to not move, it’s either other script or a roblox player bug

Limited_Unique · October 28, 2021, 11:55pm

I know but you could just kick nude players for being naughty.

Limited_Unique · October 28, 2021, 11:56pm

local NFolder = Instance.new('Folder', game.ReplicatedStorage)
NFolder.Name = 'CharDataBase'

game.Players.PlayerAdded:Connect(function(Player)
	local PFolder = Instance.new('Folder', NFolder)
	local SD = Instance.new('Shirt', PFolder)
	local PD = Instance.new('Pants', PFolder)
	PFolder.Name = Player.UserId
	SD.Name = 'Shirt'
	PD.Name = 'Pants'
	local FoundCharacter, CharacterModel = pcall(function()
		return game.Players:GetCharacterAppearanceAsync(Player.UserId)
	end)
	if CharacterModel:FindFirstChildOfClass('Shirt') ~= nil then
		if Player.UserId and PFolder.Name then
			SD.ShirtTemplate = CharacterModel.Shirt.ShirtTemplate
			Player.Character.Shirt.ShirtTemplate = SD.ShirtTemplate
		end
	end
	if CharacterModel:FindFirstChildOfClass('Pants') ~= nil then
		if Player.UserId == PFolder.Name then
			PD.PantsTemplate = CharacterModel.Pants.PantsTemplate
			Player.Character.Pants.PantsTemplate = PD.PantsTemplate
		end
	end
end)

Limited_Unique · October 28, 2021, 11:59pm

local NFolder = Instance.new('Folder', game.ReplicatedStorage)
NFolder.Name = 'CharDataBase'

game.Players.PlayerAdded:Connect(function(Player)
	local PFolder = Instance.new('Folder', NFolder)
	local SD = Instance.new('Shirt', PFolder)
	local PD = Instance.new('Pants', PFolder)
	PFolder.Name = Player.UserId
	SD.Name = 'Shirt'
	PD.Name = 'Pants'
	local FoundCharacter, CharacterModel = pcall(function()
		return game.Players:GetCharacterAppearanceAsync(Player.UserId)
	end)
	if CharacterModel:FindFirstChildOfClass('Shirt') ~= nil then
		if Player.UserId and PFolder.Name then
			SD.ShirtTemplate = CharacterModel.Shirt.ShirtTemplate
			Player.Character.Shirt.ShirtTemplate = SD.ShirtTemplate
		end
	end
	if CharacterModel:FindFirstChildOfClass('Pants') ~= nil then
		if Player.UserId == PFolder.Name then
			PD.PantsTemplate = CharacterModel.Pants.PantsTemplate
			Player.Character.Pants.PantsTemplate = PD.PantsTemplate
		end
	end
	if CharacterModel:FindFirstChildOfClass('ShirtGraphic') ~= nil then
		if Player.UserId == PFolder.Name then
			PD.TShirtGraphic = CharacterModel.ShirtGraphic.Graphic
			Player.Character.ShirtGraphic.Graphic = PD.TShirtGraphic
		end
	end
end)

Here’s added support for t-shirts.

anxlr · October 29, 2021, 12:00am

My character can’t walk though