Character look at code problem:Not Solved help needed/ REPOST

Help and Feedback Scripting Support
, , , ,
#1

Hello im working on a aiming system with the character.
but there is one problem the upper the torso and arms look up a little bit when i look a certain direction can anyone help me fix this issue
Edit: i think it has something to do with
the waist

function GunModule:Aim(Aiming)
	if Aiming then
		AimRemote:FireServer("AimIn")
		MobileCameraFramework.ToggleShiftLock(self.Player, true)

		if self.AimingAnimation then
			self.AimingAnimation:Play()

			self.AimingAnimation.KeyframeReached:Connect(function(keyframe)
				if keyframe == "CanShoot" then
					self.CanShoot = true
				end
			end)
		end

		-- Start/replace RenderStepped loop
		if self.AimConnection then
			self.AimConnection:Disconnect()
		end

		self.AimConnection = RunService.RenderStepped:Connect(function()
			-- If gun is no longer equipped or valid, just exit — but DO NOT reset C0s here
			if not self.Equipped then
				if self.AimConnection then
					self.AimConnection:Disconnect()
					self.AimConnection = nil
				end
				return
			end

			-- Still update aim even if animation stopped
			local camLook = workspace.CurrentCamera.CFrame.LookVector
			local pitch = math.asin(camLook.Y) / 2
			local pitchOffset = 0.1
			local adjustedPitch = pitch + pitchOffset

			local hrp = self.HMR or self.Character:FindFirstChild("HumanoidRootPart")
			local hrpCF = hrp and hrp.CFrame or CFrame.new()
			local _, camYaw, _ = hrpCF.Rotation:ToEulerAnglesYXZ()

			local D = (hrpCF * CFrame.Angles(0, math.pi / 2, 0)).LookVector:Dot(camLook)

			local waistAnimTransform = self.Character.LowerTorso.CFrame * self.Waist.C1
			local animPitch, animYaw, animRoll = waistAnimTransform:ToEulerAnglesYXZ()
			local cancelAnimRotation = CFrame.Angles(-animPitch, -animYaw, -animRoll)

			local finalRotation = cancelAnimRotation * CFrame.Angles(0, camYaw, 0) * CFrame.Angles(adjustedPitch, 0, 0)
			local desiredWaistWorld = self.Character.LowerTorso.CFrame * finalRotation * self.WCFRAME
			local adjustedWaistC0 = self.Character.LowerTorso.CFrame:ToObjectSpace(desiredWaistWorld)
			local adjustedRootC0 = self.Root.C0

			local neckC0 = CFrame.new(self.Neck.C0.Position) * CFrame.Angles(adjustedPitch, -D / 4, -D / 4)
			local rightArmC0 = CFrame.new(self.RightArm.C0.Position) * CFrame.Angles(adjustedPitch, 0, 0)
			local leftArmC0 = CFrame.new(self.LeftArm.C0.Position) * CFrame.Angles(adjustedPitch, 0, 0)

			self.Neck.C0 = neckC0
			self.LeftArm.C0 = leftArmC0
			self.RightArm.C0 = rightArmC0
			self.Waist.C0 = adjustedWaistC0
			self.Root.C0 = adjustedRootC0

			UpdateMotorC0:FireServer({
				Neck = neckC0,
				LeftArm = leftArmC0,
				RightArm = rightArmC0,
				Waist = adjustedWaistC0,
				Root = adjustedRootC0
			})
		end)
	else
		-- Disable shooting, shift lock, and disconnect loop
		self.CanShoot = false
		AimRemote:FireServer("AimOut")
		MobileCameraFramework.ToggleShiftLock(self.Player, false)

		if self.AimConnection then
			self.AimConnection:Disconnect()
			self.AimConnection = nil
		end

		-- âś… Always reset C0s here, not in the loop
		if self.Waist then self.Waist.C0 = self.WCFRAME end
		if self.Neck then self.Neck.C0 = self.NCFRAME end
		if self.LeftArm then self.LeftArm.C0 = self.LACFRAME end
		if self.RightArm then self.RightArm.C0 = self.RACFRAME end
		if self.Root then self.Root.C0 = self.RCFRAME end

		UpdateMotorC0:FireServer({
			Neck = self.Neck.C0,
			LeftArm = self.LeftArm.C0,
			RightArm = self.RightArm.C0,
			Waist = self.Waist.C0,
			Root = self.Root.C0
		})
	end
end
2 Likes
#2

try seeing what it looks like if you don’t divide it by 2.

#3

it makes arms faster if i dont divide and slower when i divide by 3

#4

maybe clamping them will make them look more normal? perhaps from -45 to 45

#5

it might be adjustedWaistC0

30 min eieieei

1 Like
#6

because the torso is the one moving when i look closer

#7


do you see how in one point its higher than the other

1 Like
#8

i see, i think this has to do with how funky rotation is in places like roblox

is using CFrame.lookAt with the mouse hit position feasible for what you want to do?
euler angles require rotation order iirc which becomes advanced annoying and hard to deal with

#9

It looks like your waist is tilting at certain angles probably due to camYaw.

Seems like this is the culprit, try changing the order.

local finalRotation =  CFrame.Angles(0, camYaw, 0) *cancelAnimRotation * CFrame.Angles(adjustedPitch, 0, 0)

Otherwise no idea, could be due to animations as well but it seems like you got it covered.

Oh wait you are using CFrame.Angles, this messes up the order try using CFrame.from orientation instead. You know the YXZ and XYZ order thing.

			local animPitch, animYaw, animRoll = waistAnimTransform:ToEulerAnglesYXZ()
			local cancelAnimRotation = CFrame.fromOrientation(-animPitch, -animYaw, -animRoll)
#10

so this is the problem?
local animPitch, animYaw, animRoll = waistAnimTransform:ToEulerAnglesYXZ()
local cancelAnimRotation = CFrame.fromOrientation(-animPitch, -animYaw, -animRoll)
“You know the YXZ and XYZ order thing.” and what about that?

#11

Wait was that the solution?

Oh for this I never use CFrame.Angles ever again for this reason, angles is XYZ order CFrame.fromOrientation is YXZ order they will generate different end results given the same 3 angles.

#12

so like this?

			local cancelAnimRotation = CFrame.fromOrientation(-animPitch, -animYaw, -animRoll)

			local finalRotation = cancelAnimRotation * CFrame.fromOrientation(0, camYaw, 0) * CFrame.fromOrientation(adjustedPitch, 0, 0)

or you mean something else
i allways used cframe.angles this is new to me

#13

did i do it right?

30 minnn
#14

Your aim is using pitch math.asin, which is not going to be normalized based off where your root part’s euler angles will update to. So that means your pitch will be based off the relative direction of euler angles world space, not the relative direction of your root part.

You have to normalize the pitch to the root part:

local function GetNormalizedPitch(cameraCFrame, characterCFrame)
	local relativeLookVector = characterCFrame:ToObjectSpace(cameraCFrame).LookVector
	return math.asin(math.clamp(relativeLookVector.Y, -1, 1))
end

then you apply the normalized pitch to your use-case, and it should no longer bob up and down like a sin wave.

#15

bro cooked let me try rq frfrfr

#16

and of course, it will not work unless you adapt normalization to all of your adjacent angle updates. So that includes everything else inside the aim connection, you have to normalize all of your angles to root part’s euler angles object space.

#17

bro i knew it wouldnt be that simple
i thought it was just this

local pitch = GetNormalizedPitch(workspace.CurrentCamera.CFrame,self.HMR.CFrame)

ill do the rest anyway

#18

so i found out the problem and it was not that it was this

	local waistAnimTransform = self.Character.LowerTorso.CFrame * self.Waist.C1
	local animPitch, animYaw, animRoll = waistAnimTransform:ToEulerAnglesYXZ()
	local cancelAnimRotation = CFrame.Angles(-animPitch, -animYaw, -animRoll)