ChatInstallVerifier LocalScript provided with the default chat system yields forever while trying to fetch the StarterPlayerScripts object

Maximum_ADHD · February 16, 2021, 7:59pm

Issue Type: Other
Impact: Moderate
Frequency: Constantly
Date First Experienced: 2021-02-10 00:02:00 (-06:00)
Date Last Experienced: 2021-02-16 00:02:00 (-06:00)

Reproduction Steps:
A recent change made last week to enforce the installation of Roblox’s default BubbleChat/ChatScript LocalScripts into the PlayerScripts has a silent problem that is preventing the chat system from loading, when encountering the race condition that it is attempting to prevent.

This problem can be observed at Line 19 of ChatInstallVerifier.lua, located at content/scripts/CoreScripts/Modules/Server/ClientChat:

github.com

MaximumADHD/Roblox-Client-Tracker/blob/82fc92a0bada0101ca7538b82833905ad5cc3ac1/scripts/CoreScripts/Modules/Server/ClientChat/ChatInstallVerifier.lua#L19

      
        
            local function waitForChildOfClass(parent, className)

            	local child = parent:FindFirstChildOfClass(className)

            	while not child or child.ClassName ~= className do

            		child = parent.ChildAdded:Wait()

            	end

            	return child

            end

            

            local LocalPlayer = Players.LocalPlayer

            local PlayerScripts = waitForChildOfClass(LocalPlayer, "PlayerScripts")

            local StarterPlayerScripts = waitForChildOfClass(LocalPlayer, "StarterPlayerScripts")

            

            function VerifyScriptExistence()

            	local scriptToVerifyValue = script:WaitForChild("ScriptToVerify")

            	local scriptToVerifyName = scriptToVerifyValue.Value

            	if not PlayerScripts:FindFirstChild(scriptToVerifyName) then

            		local scriptToClone = StarterPlayerScripts:FindFirstChild(scriptToVerifyName)

            		if scriptToClone then

            			local lastArchivable = scriptToClone.Archivable

            			scriptToClone.Archivable = true

            			scriptToClone:Clone().Parent = PlayerScripts

To reproduce this issue:

Start a Play Solo session in Roblox Studio
Navigate to Players/{Username}/PlayerGui
Observe the ChatInstallVerifier scripts that are stuck in limbo.

Expected Behavior:
The BubbleChat and ChatScript should be loaded into the PlayerScripts by copying it from the StarterPlayerScripts object located under the StarterPlayer service, in the event that it loaded into the game late and was missed by clients that have already loaded into the game.

Actual Behavior:
The waitForChildOfClass function erroneously searches for a StarterPlayerScripts object inside of the LocalPlayer rather than the StarterPlayer, and silently goes into an infinite yield as a result.

As a result, I am unable to use Roblox’s chat without manually inserting the scripts myself.

Workaround:
I can add my own fork of the verifier that correctly searches against the StarterPlayer instead of the LocalPlayer for the StarterPlayerScripts. This issue only seems to happen in Roblox Studio, so it should not be affecting live games.

subcritical · February 16, 2021, 8:25pm

Thanks, we’ve submitted a fix. This will be fixed early next week.

iondrive · February 24, 2021, 3:24pm

I’m still experiencing this. When I start a new project, chat works fine, so I’m assuming the fix is in.
But, in the game i’m working on the problem persists. I have a custom parser in ClientChatModules.CommandModules. If I remove the parser, chat does work, but if I install the custom state, then this issue comes back. If I copy the files manually, then chat works.

Hippie_ofDoom · March 9, 2021, 10:15pm

This issue should now be resolved! If this issue is still occurring, please create a new topic for us to look into.

Hippie_ofDoom · March 16, 2021, 10:15pm

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.