ClearAllChildren is dangerous

Bug Reports Studio Bugs
#1

If something parents things on ChildRemoved and ClearAllChildren is called on it, the server will crash.

x=Instance.new("Part",workspace)
Instance.new("IntValue",x)
x.ChildRemoved:connect(function()Instance.new("IntValue",x)end)
x:ClearAllChildren()

I think x:ClearAllChildren() should behave like for _,v in pairs(x:GetChildren())do v:Destroy()end instead of repeat x:GetChildren()[1]:Destroy()until #x:GetChildren()==0 so it just destroys its current children instead of destroying one at a time until there aren’t any left.

found this issue in a script builder where I tried running ClearAllChildren on my character while it automatically regenerates.

2 Likes
#2

It probably is something similar to this in Lua:

local tab = {"a","b","c"}
for k,v in pairs(tab) do
tab[k] = nil
-- ChildRemoved: table.insert(tab,"hi")
end

Since something gets added to the array(list-thing) holding the children ClearAllChildren is going over.

Nice to know to watch out for that, though.

#3

how can I avoid crashing the server when someone calls ClearAllChildren on my character/torso but limbs and joints are automatically being created and added back on ChildRemoved?

#4

Eh, wait() and completely respawn?

#5

completely respawn is the thing I am trying to avoid ever needing to do.

#6

They might as well do Character:Destroy()

#7

and that’s the only case.