Click Script buggy

pyxfluff · November 9, 2021, 10:10pm

Hi!
Just a quick thing as I’m rushing right now, My click script isn’t working as expected. It only plays the hover one every now and then.
What’s wrong?
Thanks!
Click script:

local SoundClick = Instance.new("Sound",script.Parent)
SoundClick.SoundId = "rbxassetid://178104975"
local SoundEnter = Instance.new("Sound",script.Parent)
SoundEnter.SoundId = "rbxassetid://5991592592"
SoundEnter.Volume = 2
SoundClick.Volume = .1

if script.Parent.Visible == true then
	script.Parent.MouseButton1Click:Connect(function()
		SoundClick:Play()
	end)

	script.Parent.MouseEnter:Connect(function()
		SoundEnter:Play()
	end)
	script.Parent.MouseLeave:Connect(function()
		SoundEnter:Play()
	end)
end

Distribute script:

local a = 0
local b = 0
local ended = false
local SOUND = script.Sound
function RemoveTableDupes(tab)
	local hash = {}
	local res = {}
	for _,v in ipairs(tab) do
		if (not hash[v]) then
			res[#res+1] = v
			hash[v] = true
		end
	end
	return res
end

task.wait(15)

local OBJECTS = {}

for i, obj in pairs(game.Players.LocalPlayer:WaitForChild("PlayerGui"):GetDescendants()) do
	if obj:IsA("GuiObject") and obj.Parent ~= script.Parent and obj.Parent.Parent ~= script.Parent then
		--Found a GuiObject
		if obj:IsA("ImageButton") then
			a += 1
			table.insert(OBJECTS, obj)
		end

	elseif obj:IsA("TextButton") then
		a+=1
		table.insert(OBJECTS, obj)

	end
end

OBJECTS = RemoveTableDupes(OBJECTS)

function OpenLoading()
	local frame = game.Players.LocalPlayer.PlayerGui.ChangeSetting.Frame
	frame.Visible = true
	frame.lab.Text = "Initalizing..."
	task.wait(2)
end
function CloseLoading()
	local frame = game.Players.LocalPlayer.PlayerGui.ChangeSetting.Frame
	frame.Visible = false
end
local function SetAllColors(color)
	for i, obj in pairs(OBJECTS) do
		if obj:IsA("GuiObject") and obj.Parent ~= script.Parent and obj.Parent.Parent ~= script.Parent then
			--Found a GuiObject
			task.wait()
			if obj:IsA("ImageButton") then
				b += 1
				local e = Instance.new("Sound")
				e.SoundId = "rbxassetid://178104975"
				e.Volume = 2
				e.Parent = script
				e:Play()
				local scr = script.LocalScript:Clone()
				scr.Parent = obj.Parent
				scr.Disabled = false
				e:Destroy()
			end
		elseif obj:IsA("TextButton") then
			b += 1
			local e = Instance.new("Sound")
			e.SoundId = "rbxassetid://178104975"
			e.Volume = 2
			e.Parent = obj
			e:Play()
			local scr = script.LocalScript:Clone()
			scr.Parent = obj.Parent
			scr.Disabled = false
			e:Destroy()
		end
	end
end

game.Players.LocalPlayer.PlayerGui.ChangeSetting.Frame.lab.Text = "Loading.. ["..b.."/"..a.."]"
ended = true

SetAllColors(game.Players.LocalPlayer:WaitForChild("Theme").Value)

Thanks!

Limited_Unique · November 9, 2021, 10:13pm

local SoundClick = Instance.new("Sound",script.Parent)
SoundClick.SoundId = "rbxassetid://178104975"
local SoundEnter = Instance.new("Sound",script.Parent)
SoundEnter.SoundId = "rbxassetid://5991592592"
SoundEnter.Volume = 2
SoundClick.Volume = .1

script.Parent.MouseButton1Click:Connect(function()
	SoundClick:Play()
end)

script.Parent.MouseEnter:Connect(function()
	SoundEnter:Play()
end)

script.Parent.MouseLeave:Connect(function()
	SoundEnter:Play()
end)

Those events will only ever fire if the Gui instance in question is visible, no need to check for it.

pyxfluff · November 9, 2021, 10:26pm

I changed it but I still dont hear it.

local SoundClick = Instance.new("Sound",script.Parent)
SoundClick.SoundId = "rbxassetid://178104975"
local SoundEnter = Instance.new("Sound",script.Parent)
SoundEnter.SoundId = "rbxassetid://5991592592"
SoundEnter.Volume = 2
SoundClick.Volume = .1


	script.Parent.MouseButton1Click:Connect(function()
		if script.Parent.Visible == true then
			SoundClick:Play()
		end
	end)

	script.Parent.MouseEnter:Connect(function()
		if script.Parent.Visible == true then
			SoundEnter:Play()
		end
	end)
	script.Parent.MouseLeave:Connect(function()
		if script.Parent.Visible == true then
			SoundEnter:Play()
		end
	end)

pyxfluff · November 9, 2021, 10:27pm

Also, this is happening, even thought the deploy script should only fire on Text/ImageButtons but I get this image.

Ioveczour · November 9, 2021, 10:52pm

local SoundClick = Instance.new("Sound",script.Parent)
SoundClick.SoundId = "rbxassetid://178104975"
local SoundEnter = Instance.new("Sound",script.Parent)
SoundEnter.SoundId = "rbxassetid://5991592592"
SoundEnter.Volume = 2
SoundClick.Volume = .1
local Player = game.Players.LocalPlayer
local Mouse = Player:GetMouse()
local Hovering = false

Mouse.Button1Down:Connect(function()
	if script.Parent.Visible == true and Hovering == true then
		SoundClick:Play()
	end
end)

script.Parent.MouseEnter:Connect(function()
	Hovering = true
	if script.Parent.Visible == true then
		SoundEnter:Play()
	end
end)
script.Parent.MouseLeave:Connect(function()
	Hovering = false
	if script.Parent.Visible == true then
		SoundEnter:Play()
	end
end)

Not the most efficient way, but I think it works.

pyxfluff · November 9, 2021, 10:57pm

I think it’s something wrong with the deploy script.

Ioveczour · November 9, 2021, 11:00pm

…
I thought a second ago, script.Parent was a Frame. Did you move the script by accident?

pyxfluff · November 9, 2021, 11:02pm

No, it’s still under the deploy script, if you look at the console it’s giving a ton of errors with putting it into frames and folders, with Commander and Build for some reason

Ioveczour · November 9, 2021, 11:03pm

It says that it is a Frame right here.

pyxfluff · November 9, 2021, 11:03pm

local a = 0
local b = 0
local ended = false
local SOUND = script.Sound
function RemoveTableDupes(tab)
	local hash = {}
	local res = {}
	for _,v in ipairs(tab) do
		if (not hash[v]) then
			res[#res+1] = v
			hash[v] = true
		end
	end
	return res
end

task.wait(15)

local OBJECTS = {}

for i, obj in pairs(game.Players.LocalPlayer:WaitForChild("PlayerGui"):GetDescendants()) do
	if obj:IsA("GuiObject") and obj.Parent ~= script.Parent and obj.Parent.Parent ~= script.Parent then
		--Found a GuiObject
		if obj:IsA("ImageButton") then
			a += 1
			table.insert(OBJECTS, obj)
		end

	elseif obj:IsA("TextButton") then
		a+=1
		table.insert(OBJECTS, obj)

	end
end

OBJECTS = RemoveTableDupes(OBJECTS)

function OpenLoading()
	local frame = game.Players.LocalPlayer.PlayerGui.ChangeSetting.Frame
	frame.Visible = true
	frame.lab.Text = "Initalizing..."
	task.wait(2)
end
function CloseLoading()
	local frame = game.Players.LocalPlayer.PlayerGui.ChangeSetting.Frame
	frame.Visible = false
end
local function SetAllColors()
	for i, obj in pairs(OBJECTS) do
		if obj:IsA("GuiObject") and obj.Parent ~= script.Parent and obj.Parent.Parent ~= script.Parent then
			--Found a GuiObject
			task.wait()
			if obj:IsA("ImageButton") then
				b += 1
				local e = Instance.new("Sound")
				e.SoundId = "rbxassetid://178104975"
				e.Volume = 2
				e.Parent = script
				e:Play()
				local scr = script.LocalScript:Clone()
				scr.Parent = obj.Parent
				scr.Disabled = false
				e:Destroy()
			end
		elseif obj:IsA("TextButton") then
			b += 1
			local e = Instance.new("Sound")
			e.SoundId = "rbxassetid://178104975"
			e.Volume = 2
			e.Parent = obj
			e:Play()
			local scr = script.LocalScript:Clone()
			scr.Parent = obj.Parent
			scr.Disabled = false
			e:Destroy()
		end
	end
end

game.Players.LocalPlayer.PlayerGui.ChangeSetting.Frame.lab.Text = "Loading.. ["..b.."/"..a.."]"
ended = true

SetAllColors()

Ioveczour · November 9, 2021, 11:05pm

Can you show the location image, like what you’re trying to click/hover over? Along with the script.

pyxfluff · November 9, 2021, 11:06pm

just the play button

Ioveczour · November 9, 2021, 11:10pm

Where is this script located??

local SoundClick = Instance.new("Sound",script.Parent)
SoundClick.SoundId = "rbxassetid://178104975"
local SoundEnter = Instance.new("Sound",script.Parent)
SoundEnter.SoundId = "rbxassetid://5991592592"
SoundEnter.Volume = 2
SoundClick.Volume = .1
local Player = game.Players.LocalPlayer
local Mouse = Player:GetMouse()
local Hovering = false

Mouse.Button1Down:Connect(function()
	if script.Parent.Visible == true and Hovering == true then
		SoundClick:Play()
	end
end)

script.Parent.MouseEnter:Connect(function()
	Hovering = true
	if script.Parent.Visible == true then
		SoundEnter:Play()
	end
end)
script.Parent.MouseLeave:Connect(function()
	Hovering = false
	if script.Parent.Visible == true then
		SoundEnter:Play()
	end
end)

pyxfluff · November 9, 2021, 11:12pm

It will be put in any text/imagebutton the script finds.

Ioveczour · November 9, 2021, 11:20pm

I changed the scripts around, and it should work now. I don’t think you will need to detect if something is visible, because it is on client, but you can decide to remove it or not. (Remove the visible checking, if it doesn’t work, but there are no errors.) You should know where the scripts go, by the looks of it.

local SoundClick = Instance.new("Sound",script.Parent)
SoundClick.SoundId = "rbxassetid://178104975"
local SoundEnter = Instance.new("Sound",script.Parent)
SoundEnter.SoundId = "rbxassetid://5991592592"
SoundEnter.Volume = 2
SoundClick.Volume = .1


script.Parent.MouseButton1Down:Connect(function()
	if script.Parent.Parent.Visible == true then
		SoundClick:Play()
	end
end)

script.Parent.MouseEnter:Connect(function()
	if script.Parent.Parent.Visible == true then
		SoundEnter:Play()
	end
end)
script.Parent.MouseLeave:Connect(function()
	if script.Parent.Parent.Visible == true then
		SoundEnter:Play()
	end
end)

local a = 0
local b = 0
local ended = false
local SOUND = script.Sound
function RemoveTableDupes(tab)
	local hash = {}
	local res = {}
	for _,v in ipairs(tab) do
		if (not hash[v]) then
			res[#res+1] = v
			hash[v] = true
		end
	end
	return res
end

task.wait(15)

local OBJECTS = {}

for i, obj in pairs(game.Players.LocalPlayer:WaitForChild("PlayerGui"):GetDescendants()) do
	if obj:IsA("GuiObject") and obj ~= script.Parent and obj.Parent ~= script.Parent then
		--Found a GuiObject
		if obj:IsA("ImageButton") then
			a += 1
			table.insert(OBJECTS, obj)
		end

	elseif obj:IsA("TextButton") then
		a+=1
		table.insert(OBJECTS, obj)

	end
end

OBJECTS = RemoveTableDupes(OBJECTS)

function OpenLoading()
	local frame = game.Players.LocalPlayer.PlayerGui.ChangeSetting.Frame
	frame.Visible = true
	frame.lab.Text = "Initalizing..."
	task.wait(2)
end
function CloseLoading()
	local frame = game.Players.LocalPlayer.PlayerGui.ChangeSetting.Frame
	frame.Visible = false
end
local function SetAllColors()
	for i, obj in pairs(OBJECTS) do
		if obj:IsA("GuiObject") and obj ~= script.Parent and obj.Parent ~= script.Parent then
			--Found a GuiObject
			task.wait()
			if obj:IsA("ImageButton") then
				b += 1
				local e = Instance.new("Sound")
				e.SoundId = "rbxassetid://178104975"
				e.Volume = 2
				e.Parent = script
				e:Play()
				local scr = script.LocalScript:Clone()
				scr.Parent = obj
				scr.Disabled = false
				e:Destroy()
			end
		elseif obj:IsA("TextButton") then
			b += 1
			local e = Instance.new("Sound")
			e.SoundId = "rbxassetid://178104975"
			e.Volume = 2
			e.Parent = obj
			e:Play()
			local scr = script.LocalScript:Clone()
			scr.Parent = obj
			scr.Disabled = false
			e:Destroy()
		end
	end
end

game.Players.LocalPlayer.PlayerGui.ChangeSetting.Frame.lab.Text = "Loading.. ["..b.."/"..a.."]"
ended = true

SetAllColors()

pyxfluff · November 9, 2021, 11:24pm

Still didn’t seem like it was working on some buttons, it did work for most tho.

Ioveczour · November 9, 2021, 11:35pm

It seems you put an elseif statement in the wrong spot. Try this:

local a = 0
local b = 0
local ended = false
local SOUND = script.Sound
function RemoveTableDupes(tab)
	local hash = {}
	local res = {}
	for _,v in ipairs(tab) do
		if (not hash[v]) then
			res[#res+1] = v
			hash[v] = true
		end
	end
	return res
end

task.wait(15)

local OBJECTS = {}

for i, obj in pairs(game.Players.LocalPlayer:WaitForChild("PlayerGui"):GetDescendants()) do
	if obj:IsA("GuiObject") and obj ~= script.Parent and obj.Parent ~= script.Parent then
		--Found a GuiObject
		if obj:IsA("ImageButton") then
			a += 1
			table.insert(OBJECTS, obj)
		elseif obj:IsA("TextButton") then
			a+=1
			table.insert(OBJECTS, obj)
		end
	end
end

OBJECTS = RemoveTableDupes(OBJECTS)

function OpenLoading()
	local frame = game.Players.LocalPlayer.PlayerGui.ChangeSetting.Frame
	frame.Visible = true
	frame.lab.Text = "Initalizing..."
	task.wait(2)
end
function CloseLoading()
	local frame = game.Players.LocalPlayer.PlayerGui.ChangeSetting.Frame
	frame.Visible = false
end
local function SetAllColors()
	for i, obj in pairs(OBJECTS) do
		if obj:IsA("GuiObject") and obj ~= script.Parent and obj.Parent ~= script.Parent then
			--Found a GuiObject
			task.wait()
			if obj:IsA("ImageButton") then
				b += 1
				local e = Instance.new("Sound")
				e.SoundId = "rbxassetid://178104975"
				e.Volume = 2
				e.Parent = script
				e:Play()
				local scr = script.LocalScript:Clone()
				scr.Parent = obj
				scr.Disabled = false
				e:Destroy()
			elseif obj:IsA("TextButton") then
				b += 1
				local e = Instance.new("Sound")
				e.SoundId = "rbxassetid://178104975"
				e.Volume = 2
				e.Parent = obj
				e:Play()
				local scr = script.LocalScript:Clone()
				scr.Parent = obj
				scr.Disabled = false
				e:Destroy()
			end
		end
	end
end

game.Players.LocalPlayer.PlayerGui.ChangeSetting.Frame.lab.Text = "Loading.. ["..b.."/"..a.."]"
ended = true

SetAllColors()

[I EDITED THIS AFTER SENDING IT, ONE TIME, SO IF IT DOESN’T WORK, RE-COPY THIS]