ClickDetector Cash Script not working

[Dev_BB1]

Hi, i’m currently working on a robbery type game and the main script is broken. Here is an image:

I saw the error and I got really confused. If you have a fix to this situation, thank you.

[Avallachi]

Try player.leaderstats. ‘leaderstats’ is the only valid name for a stats folder Roblox takes to display its values automatically in the playerlist.

[Dev_BB1]

I replaced stats with leaderstats. There is still an error.

[Avallachi]

I said specifically ‘leaderstats’, with lower-case L and S. Though, changing the values locally won’t work anyways as this must be done by the server.

[Dev_BB1]

I changed both letters to lowercase. Still an error.

[Avallachi]

Could you provide a screenshot of the explorer? Considering you tried to index player.Stats, I assume you have something corresponding to it parented to the player object?

[Dev_BB1]

There’s explorer. The script at the bottom is for welcoming the player.

[Enclamatic (niite)]

You have to insert leaderstats into the player.

[Avallachi]

I don’t comprehend how you’re trying to index something which is never created locally nor server-side?

Though, you might have a look at the post I recently made for someone else regarding something quite similar for creating leaderstats:

New Leaderstats Help

If you mean pre-making the leaderstats instead of creating the leaderstats folder and its values with code, you can just set it up like this: [image] And clone the folder on .PlayerAdded like so: game.Players.PlayerAdded:Connect(function(Player) local leaderstats = script.leaderstats:Clone() leaderstats.Coins.Value = 1000 leaderstats.Gold.Value = 10 leaderstats.Exp.Value = 0 leaderstats.Parent = Player end) I’m not quite sure what you meant, so I’m just providin…

[color=#FFC900] Considering you mentioned that you’re new to scripting then I recommend that you pay specific attention to how the explorer in the post is set up and which script type (script or localscript) is being used for the code provided in the post I referred to.[/color]

[Dev_BB1]

I’m new to scripting. How exactly do I do that?

[cyswip]

You have to put the name of the folder inside the player or else it won’t work

[Dev_BB1]

Oh, and here’s a screen shot of the tutorial:

This is what I used to create the script.

[Enclamatic (niite)]

Insert a script into ServerScriptService and create a new folder named leaderstats whenever a player joins.
For example:

game.Players.PlayerAdded:Connect(function(player) --getting the player who joined
    local leaderstats = Instance.new("Folder", player) --making a new folder and inserting it into the player
    leaderstats.Name = "leaderstats"

    local cash = Instance.new("IntValue",leaderstats) --creating the cash value and inserting it into the folder
    cash.Name = "Cash"
    cash.Value = 500 --starting cash amount
end)

[colbert2677 (ImagineerColbert)]

A comment on your code: stay away from the parent argument of Instance.new.

[Avallachi]

The post I referred to already provides a code example for this + the way you’re creating the Instances isn’t performant and is rather poor practice.

[Enclamatic (niite)]

Will do, thanks for the tip

[Dev_BB1]

That actually worked. Thank you @Enclamatic and @rawbyte.

[Avallachi]

1. Remember to set and change the values on the server and not locally with a LocalScript - make sure to have a look at Remote Functions and Events for this.
2. I actually provided the correct code with no deprecated nor non-performant methods so my post is quite the more correct solution.

[Dev_BB1]

@rawbyte

I actually provided the correct code with no deprecated nor non-performant methods so my post is quite the more correct solution.

I just tried your method and the code didn’t work. @Enclamatic does work so i’m gonna use his method. But thank you for helping me though .

[Avallachi]

Then you implemented it incorrectly and didn’t set up the leaderstats folder on before-hand.

As I mentioned, pay attention to how I set it up.