Cloning doesn't return children

skelalie · January 21, 2021, 5:29am

Children of cloned bullet object are not recognized after the clone.

local b
		local start
		local tr
		if config:FindFirstChild('trailBullets') then
			if config.trailBullets.Value then
				b = game:GetService('ReplicatedStorage').trailBullet:Clone()
				b.outerTrail.Color = ColorSequence.new(rayColor.Value)
				start = CFrame.new(bPos,targetCF.p)
				tr = true
			else
				if not isLaser.Value then
					b = game:GetService('ReplicatedStorage').realBullet:Clone()
					start = CFrame.new(bPos,targetCF.p) * CFrame.new(0,0,-2)
				else
					b = game:GetService('ReplicatedStorage').bullet:Clone()
					b:FindFirstChild("SurfaceLight").Color = rayColor.Value
					b:FindFirstChild("ParticleEmitter").Color = ColorSequence.new(rayColor.Value)
					b:FindFirstChild("ParticleEmitter"):Emit(40)
					b:FindFirstChild("ParticleEmitter2").Color = ColorSequence.new(rayColor.Value)
					b:FindFirstChild("ParticleEmitter2"):Emit(.5)
					start = CFrame.new(bPos,targetCF.p) * CFrame.new(0,0,-2)
				end
			end
		else
			if not isLaser.Value then
				b = game:GetService('ReplicatedStorage').realBullet:Clone()
				start = CFrame.new(bPos,targetCF.p) * CFrame.new(0,0,-2)
			else
				b = game:GetService('ReplicatedStorage'):WaitForChild("bullet"):Clone()
				--b.SurfaceLight.Color = rayColor.Value
				b:WaitForChild("ParticleEmitter").Color = ColorSequence.new(rayColor.Value)
				b:FindFirstChild("ParticleEmitter"):Emit(50)
				b:FindFirstChild("ParticleEmitter2").Color = ColorSequence.new(rayColor.Value)
				b:FindFirstChild("ParticleEmitter2"):Emit(.5)
				start = CFrame.new(bPos,targetCF.p) * CFrame.new(0,0,-2)
			end
		end

This line -

b:WaitForChild(“ParticleEmitter”).Color = ColorSequence.new(rayColor.Value)

prints the following error message.

Line 213 is depicted here.

Image of bullet Model

I have tried changing around the initial parent of the bullet, but the clone script itself does not error. I have also tried changing out the normal ‘.’ that was there in between it and the object name, with ‘WaitForChild’.

Edit 1: Full Function if needed.

local fire = function(mP,bPos)
		
		shootAnim:Play()
		
		for _,v in next,barrel:GetChildren() do 
			if v:IsA('ParticleEmitter') then 
				v.Enabled = true 
				delay(.02,function() 
					for _,v in next,barrel:GetChildren() do 
						if v:IsA('ParticleEmitter') then 
							v.Enabled = false 
						end 
					end 
				end) 
			end 
		end
		local targetCF = mP + Vector3.new(rand:NextNumber(-config.spread.Value,config.spread.Value),rand:NextNumber(-config.spread.Value,config.spread.Value),0)
		
		local r
		
		local reflectFactor = math.rad(math.random(160,200))
		
		local b
		local start
		local tr
		if config:FindFirstChild('trailBullets') then
			if config.trailBullets.Value then
				b = game:GetService('ReplicatedStorage').trailBullet:Clone()
				b.outerTrail.Color = ColorSequence.new(rayColor.Value)
				start = CFrame.new(bPos,targetCF.p)
				tr = true
			else
				if not isLaser.Value then
					b = game:GetService('ReplicatedStorage').realBullet:Clone()
					start = CFrame.new(bPos,targetCF.p) * CFrame.new(0,0,-2)
				else
					b = game:GetService('ReplicatedStorage').bullet:Clone()
					b:FindFirstChild("SurfaceLight").Color = rayColor.Value
					b:FindFirstChild("ParticleEmitter").Color = ColorSequence.new(rayColor.Value)
					b:FindFirstChild("ParticleEmitter"):Emit(40)
					b:FindFirstChild("ParticleEmitter2").Color = ColorSequence.new(rayColor.Value)
					b:FindFirstChild("ParticleEmitter2"):Emit(.5)
					start = CFrame.new(bPos,targetCF.p) * CFrame.new(0,0,-2)
				end
			end
		else
			if not isLaser.Value then
				b = game:GetService('ReplicatedStorage').realBullet:Clone()
				start = CFrame.new(bPos,targetCF.p) * CFrame.new(0,0,-2)
			else
				b = game:GetService('ReplicatedStorage'):WaitForChild("bullet"):Clone()
				b.Parent = workspace.rayStorage
				b.SurfaceLight.Color = rayColor.Value
				b:WaitForChild("ParticleEmitter").Color = ColorSequence.new(rayColor.Value)
				b:FindFirstChild("ParticleEmitter"):Emit(50)
				b:FindFirstChild("ParticleEmitter2").Color = ColorSequence.new(rayColor.Value)
				b:FindFirstChild("ParticleEmitter2"):Emit(.5)
				start = CFrame.new(bPos,targetCF.p) * CFrame.new(0,0,-2)
			end
		end
		b.CFrame = start
		b.Parent = workspace.rayStorage
		flash(barrel.flash)
		fireSound:Play()
		if #plrs:GetPlayers() > 1 then
			render:FireServer(bPos,targetCF,rayColor.Value,speed.Value,ignores,isLaser.Value,reflectFactor,barrel,fireSound,tr)
		end
		ammo.Value = ammo.Value - 1
		updateGUI()
		
		local latency = 0
		local lastStep = bPos
		spawn(function()
			while (b.CFrame.p-start.p).magnitude < 3000 do
				latency = run.RenderStepped:Wait()
				if not isLaser.Value then
					b.CFrame = b.CFrame*CFrame.new(0,0,-latency*speed.Value)*CFrame.Angles(math.rad(-.1),0,0)
				else
					b.CFrame = b.CFrame*CFrame.new(0,0,-latency*speed.Value)
				end
				local part,position,norm = workspace:FindPartOnRayWithIgnoreList(Ray.new(lastStep,(b.Position-lastStep).unit*(lastStep-b.Position).magnitude),ignores)
				if part and part.Name == 'reflect' and not r then
					b.CFrame = b.CFrame*CFrame.Angles(0,reflectFactor,0)
					r = true
				end
			--[[	if part and part:IsDescendantOf(char) and r then
					if part.Parent:FindFirstChild('Humanoid') then
						damageEvent:FireServer(dmg.Value,part.Parent.Humanoid)
					elseif part.Parent.Parent:FindFirstChild('Humanoid') then
						damageEvent:FireServer(dmg.Value,part.Parent.Parent.Humanoid)
					end
				end]]
               if part and not part:IsDescendantOf(char) then
                    local h = game:GetService('ReplicatedStorage').hit:Clone()
                    h.Parent = workspace.rayStorage
                    h.CFrame = CFrame.new(position,position+norm)
					h.Smoke1:Emit(15)
					h.Smoke2:Emit(12)
					h.Sparks:Emit(30)
					h.Explosion:Emit(15)
                    h.Sound:Play()
                    game:GetService('Debris'):AddItem(h,2)
                    for _,v in next,h:GetChildren()do
                        if v:IsA('ParticleEmitter') or v:IsA('PointLight') then
                            v.Enabled = true
                        end
                    end 
                    delay(.1,function() 
                        for _,v in next,h:GetChildren()do 
                            if v:IsA('ParticleEmitter') or v:IsA('PointLight') then
                                v.Enabled = false
                            end
                        end 
                    end)

					if part.Name ~= 'reflect' then
			
						if exp.Value then
							explodeEvent:FireServer(position)
						end
						
						local hum = part.Parent:FindFirstChildOfClass('Humanoid') or part.Parent.Parent:FindFirstChildOfClass('Humanoid') or (part.Parent.Parent.Parent and part.Parent.Parent.Parent:FindFirstChildOfClass('Humanoid'))
						if hum then
							if tk.Value then
								damageEvent:FireServer(dmg.Value,hum)
								spawn(flashHitmarker)
								hitmark:Play()
							else
								local tplr = plrs:GetPlayerFromCharacter(hum.Parent)
								if tplr then
									if tplr.Team ~= plr.Team then
										damageEvent:FireServer(dmg.Value,hum)
										spawn(flashHitmarker)
										hitmark:Play()
									end
								else
									damageEvent:FireServer(dmg.Value,hum)
									spawn(flashHitmarker)
									hitmark:Play()
								end
							end
						end
					end
					break
				end
				lastStep = b.Position
			end
			if config:FindFirstChild('trailBullets') then
				if config.trailBullets.Value == true then
					wait(3)
					b:Destroy()
				else
					b:Destroy()
				end
			else
				b:Destroy()
			end
		end)
	end

polill00 · January 21, 2021, 5:32am

Idk why, but cloning objects don’t also clone the parent of the object.

Try changing the parent of the bullet directly after cloning it.

Edit: I just made a test script and discovered this isn’t the issue. I’ll get back to you when I figure out why.

skelalie · January 21, 2021, 5:37am

Apparantly the original bullet is not being cloned. Evidenced by the following error message after I added suggested line of code.

Note: Bullet is added to ReplicatedStorage via another script, however this shouldn’t be an issue because I used WaitForChild.

Edit: Perhaps an issue with using a pre-defined variable and cloning afterwards?
Edit 2: Full Function now available in original post.

skelalie · January 21, 2021, 5:43am

More info: This script will sporadically break between updates, sending the same error message each time it is broken. Perhaps explaining the pre-defined variable theory?

7z99 · January 21, 2021, 5:44am

From your error, it appears to be because b isn’t being assigned a value. Try adding print(b) above line 213. If it returns nil, try using :WaitForChild.

polill00 · January 21, 2021, 5:50am

You’re right, It’s a problem with the bullet, not the children. A unrecognized child error would look like this:

I’m not sure what you mean by this, If you’re referring to

local b

-- a bunch of stuff

b = game:GetService('ReplicatedStorage'):WaitForChild("bullet"):Clone()

This shouldn’t matter.

I am struggling to re-create your error message. The only way I’ve been able to is by toggling Archivable to false before.

local RS = game:GetService("ReplicatedStorage")

local b = Instance.new("Folder", RS)
b.Name = "Test"
b.Archivable = false

local T = RS:WaitForChild("Test"):Clone()

print(T.Name) -- ServerScriptService.Script:10: attempt to index nil with 'Name'

7z99 · January 21, 2021, 5:57am

You get the same error from trying to access a property from a nil/nonexistent instance.

For example,

print(workspace:FindFirstChild('NonexistentPart').Name)

It will print print(workspace:FindFirstChild('NonexistentPart').Name):1: attempt to index nil with 'Name'

Same thing with using methods

print(workspace:FindFirstChild('NonexistentPart'):WaitForChild('AnotherNonExistentPart'))

print(workspace:FindFirstChild('NonexistentPart'):WaitForChild('AnotherNonExistentPart')):1: attempt to index nil with 'WaitForChild'

skelalie · January 21, 2021, 5:59am

Will get back to these suggestions in a few hours. Thank you both for your assistance.

polill00 · January 21, 2021, 6:00am

Yes you’re correct but looking back at his code:

He’s able to clone the object beforehand…

When I try to clone it, I get this error message

local RS = game:GetService("ReplicatedStorage")

local T = RS:WaitForChild("NonExistantPart"):Clone()

print(T.Name)

7z99 · January 21, 2021, 6:02am

Yeah, :WaitForChild warns infinite yield, if you add a time to wait argument (ex. :WaitForChild(‘Name’, 1)) or if you use :FindFirstChild, it will return the attempt to index nil error. :WaitForChild pauses the thread until the instance can be found or until the time to wait argument is over.

For whatever reason, the script isn’t able to find the bullet in ReplicatedStorage. I am thinking maybe he should check if it’s there at runtime and if not, what is moving/destroying it.

7z99 · January 21, 2021, 6:36am

@polill00 and I went over it in DMs.

I looked over your script and the only thing I could see that may be modifying the b value for whatever reason, is the spawn function. Could you try commenting out the destroy functions near the bottom?