Code grabs players one by one, individually

[freakinlostmyacount]

Hi, so uh, I’m making a code based on a magnitude. Everything works properly except for one things, a minor bug that is confusing me.
When the script detects 2 or more people, it will indivually add and finish the particles, then move on and so forth. I would think by grabbing all rootparts, that it would find the magnitude of all players, but it doesn’t… please tell me where the error lies.

---

local Players = game:GetService("Players")
local Tool = script.Parent
local Fire = workspace.Fire
local players = game:GetService("Players")
local RepilcatedSpontaneousCombustion = game:GetService("ReplicatedStorage"):WaitForChild("Spontaneous Combustion")
local MagicCooldown = game:GetService("ReplicatedStorage"):WaitForChild("Cooldown")


Players.PlayerAdded:Connect(function(player)

	player.CharacterAdded:Connect(function(character)
			local rootpart = character:WaitForChild("HumanoidRootPart")
			local humanoid = character:WaitForChild("Humanoid")
			local Backpack = player:WaitForChild("Backpack")
		wait(RepilcatedSpontaneousCombustion)
		local SpontaneousCombustion = RepilcatedSpontaneousCombustion:Clone()
		SpontaneousCombustion.Parent = player:WaitForChild("Backpack")
			SpontaneousCombustion.Equipped:Connect(function(equipped)
			for _,v in pairs(game.Players:GetPlayers()) do
				MagicCooldown:FireClient(player)
				local allroots = v.Character:FindFirstChild("HumanoidRootPart")
				print(_,v)
				if allroots ~= rootpart then
					if ((allroots.Position - rootpart.Position).Magnitude > 20) == false then
						print(allroots)
						allroots.ParticleEmitter.Enabled = true
						wait(5)
						allroots.ParticleEmitter.Enabled = false
					end
				end
			end
		end)
	end)
end)

---

[Xitral (HersForever)]

You need to create a separate thread for each player if you want to make it run through all players simultaneously.

---

You can use task.spawn() for that:

task | Documentation - Roblox Creator Hub

Use task.spawn(function() to make the code run asynchronously.

---

The code wasn’t formatted in studio but it should work:

for _,v in pairs(game.Players:GetPlayers()) do
            task.spawn(function()
				MagicCooldown:FireClient(player)
				local allroots = v.Character:FindFirstChild("HumanoidRootPart")
				print(_,v)
				if allroots ~= rootpart then
					if ((allroots.Position - rootpart.Position).Magnitude > 20) == false then
						print(allroots)
						allroots.ParticleEmitter.Enabled = true
						wait(5)
						allroots.ParticleEmitter.Enabled = false
					end
				end
              end)
			end

---

Recommendations:

I also recommend using task.wait(5) instead of wait(5):

Task Library - Now Available!

Hey developers, We have just enabled a brand new library that you can use in your projects. The task library allows you to talk directly with our engine’s task scheduler to manage and schedule code. It features a number of new methods as well as some improvements to existing methods. Details task.spawn Takes a thread or function and resumes it immediately through the engine’s scheduler. Additional arguments are passed to the thread or function being resumed. void task.spawn(function | threa…

Also, you can replace your pairs with ipairs. ‘Indexed Pairs’ will run faster in comparison to Pairs:

Speed comparison : ipairs vs pairs vs numerical loop [benchmark]

I didn’t think this would fit anywhere else so I just put this here. The purpose of this is to share as information, the average of the time taken by various loops to execute and print a value, regardless of being numeric or generic from a numerically indexed table. Note: The criteria is is no way perfect or the correct method, but gives insight on how long different generators could take to return a value. Also, pairs is not being used for it’s intended purpose (that is iterating through di…

The only situation I know of where ipairs doesn’t work is when you’re working with dictionaries. :GetPlayers() is an array so ipairs will work for you.

---

Hope this helps!

[freakinlostmyacount]

Thank you so much. I didn’t know task was even a thing. I only have 2 clients set up to my computer, my camrecorder and my computer, so I need a 3rd person to test this, but theoretically it should work, thank you. (Also I was using pairs because it didn’t matter about the order, but now that I know ipairs is faster, I’ll definetly use that!)