Code to perpetually randomize the colors of tagged objects

[asadefa]

local Collection, Tween, Name, Table = game:GetService("CollectionService"), game:GetService("TweenService"), script.Name, {}
local function Color(Part)
	local function Check()
		while workspace:IsAncestorOf(Part) do
			Table.Color = Color3.new(math.random(), math.random(), math.random())
			local Tween = Tween:Create(Part, TweenInfo.new(math.random()+1, Enum.EasingStyle.Sine, Enum.EasingDirection.InOut), Table)
			task.defer(Tween.Play, Tween)
			Tween.Completed:Wait()
		end
	end
	Check()
	Part.AncestryChanged:Connect(Check)
end
Collection:GetInstanceAddedSignal(Name):Connect(Color)
for I, Part in ipairs(Collection:GetTagged(Name)) do
	Color(Part)
end

This code is designed to constantly randomize the color of certain objects via the TweenService. Any feedback?

[BilonGamer (Emmie)]

@asadefa

for I, Part in ipairs(Collection:GetTagged(Name)) do
	Color(Part)
end

@asadefa

	Check()

Since you’re not running the function in a separate thread, there is a situation where the for loop is gonna pause prematurely until the part is no longer in workspace since it entered the Check while loop.

@asadefa

	Check()
	Part.AncestryChanged:Connect(Check)

This is fine if the part starts out in workspace, but once it gets parented out of it and back the Check function will be called every single time it is reparented, so there is the possibility that the Check loop will be running multiple times for the same part, which I don’t think is behavior you desire. To fix it, maybe add some sort of flag which tells it to not start running the loop if one is already running.

[BilonGamer (Emmie)]

@GE_0E

if math.random returned -1 then the time will be 0 which means that it will not tween well

math.random returns values between 0 and 1. math | Documentation - Roblox Creator Hub

@GE_0E

since an empty math.random returns from -1 to 1 then there is a higher chance that the color will be black (0,0,0) most of the time

No. It returns values between 0 (inclusive) and 1 (exclusive).

@GE_0E

not sure about this but task.defer doesnot run the function immediately so Tween.Completed:Wait() mayn’t wait and if it did then it will yield the loop i think adding both of them to 1 task.defer/spawn would be better

task.defer running a bit later than the main thread does not change the fact that the code will wait for the tween to be completed. The yielding of the loop is necessary to make sure the colors of the part are tweened one after another, plus an infinite loop with no yielding will crash the game.

@GE_0E

if the part is parented to workspace or a specific folder then you can do
part.Parent == workspace/folder because workspace:IsAncestorOf(Part) can get slower if there are a lot of instances in the workspace because it checks for ancestors as well

What’s your source for this? Honestly just seems like a micro-optimization to me. How slower is it actually? And would it impact the OP’s code?

[GE_0E]

@BilonGamer

math.random returns values between 0 and 1. math | Documentation - Roblox Creator Hub

you are right, I remember that math.Random was returning numbers from -1 to 1 to me i may have confused it with something else idk

@BilonGamer

What’s your source for this? Honestly just seems like a micro-optimization to me. How slower is it actually? And would it impact the OP’s code?

I did a benchmark, and I am wrong, I thought that it will loop through all descendants, but I think it works differently

though thanks for the correction

[asadefa]

A:IsAncestorOf(B) only needs to find B.Parent, and then the parent of that, etc. until either A is found or nil is found. There is no need to loop through all the descendants of the workspace.

[GE_0E]

I realized that after I wrote the post, I didn’t think well when I was writing that post